1218431 – Remove unused options from hammer content-view version incremental-update

Red Hat Satellite engineering is moving the tracking of its product development work on Satellite to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "Satellite project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs will be migrated starting at the end of May. If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "Satellite project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/SAT-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1218431 - Remove unused options from hammer content-view version incremental-update

Summary: Remove unused options from hammer content-view version incremental-update

Keywords:
Status:	CLOSED CURRENTRELEASE
Alias:	None
Product:	Red Hat Satellite
Classification:	Red Hat
Component:	Hammer
Sub Component:
Version:	6.1.0
Hardware:	Unspecified
OS:	Unspecified
Priority:	unspecified
Severity:	medium
Target Milestone:	Unspecified
Assignee:	Eric Helms
QA Contact:	sthirugn@redhat.com
Docs Contact:
URL:	http://projects.theforeman.org/issues...
Whiteboard:
Depends On:
Blocks:
TreeView+	depends on / blocked

Reported:	2015-05-04 21:29 UTC by sthirugn@redhat.com
Modified:	2017-02-23 20:05 UTC (History)
CC List:	4 users (show)
Fixed In Version:
Doc Type:	Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:	2015-08-12 16:04:31 UTC
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)

Links
System	ID	Private	Priority	Status	Summary	Last Updated
Foreman Issue Tracker	10600	0	None	None	None	2016-04-22 16:37:38 UTC
Red Hat Bugzilla	1201021	0	unspecified	CLOSED	Incremental update of errata with --content-view-version-environments failed	2021-02-22 00:41:40 UTC

Internal Links: 1201021

Description sthirugn@redhat.com 2015-05-04 21:29:03 UTC

Description of problem:
Remove unused options from hammer content-view version incremental-update

Version-Release number of selected component (if applicable):
Satellite-6.1.0-RHEL-7-20150429.2

How reproducible:
Always

Steps to Reproduce:
# hammer -u admin -p changeme content-view version incremental-update --help
Usage:
    hammer content-view version incremental-update [OPTIONS]

Options:
 --async                                                               Do not wait for the task
 --content-view-version CONTENT_VIEW_VERSION_VERSION                   Content view version number
 --content-view-version-environments CONTENT_VIEW_VERSION_ENVIRONMENTS Comma separated list of values.
 --content-view-version-id CONTENT_VIEW_VERSION_ID                     Content view version identifier
 --description DESCRIPTION                                             The description for the new generated Content View Versions
 --environment-ids ENVIRONMENTS                                        list of environment IDs to update the content view version in
                                                                       Comma separated list of values.
 --environments ENVIRONMENT_NAMES                                      Comma separated list of values.
 --errata-ids ERRATA_IDS                                               Errata uuids to copy into the new versions.
                                                                       Comma separated list of values.
 --id ID                                                               ID of a content view version to incrementally update
...
...
...

Actual results:
--content-view-version-environments is a dupe of --environment-ids
--content-view-version-id           is a dupe of --id

Expected results:
Remove unused/dupe options:
--content-view-version-environments
--content-view-version-id


Additional info:
These options are not used and is very confusing.

Comment 1 sthirugn@redhat.com 2015-05-04 21:36:50 UTC

This bug was created while verifying https://bugzilla.redhat.com/show_bug.cgi?id=1201021

Comment 3 Eric Helms 2015-05-22 19:52:34 UTC

Created redmine issue http://projects.theforeman.org/issues/10600 from this bug

Comment 4 Eric Helms 2015-05-22 19:57:02 UTC

Proposed fix here: https://github.com/Katello/hammer-cli-katello/pull/295

Surech, please let me know what you think of this new output:

vagrant@katello-devel hammer-cli-katello (fixes-10600)$ hammer content-view version incremental-update --help
Usage:
hammer content-view version incremental-update [OPTIONS]

Options:
--async Do not wait for the task
--content-host-ids CONTENT_HOST_IDS IDs of content hosts to update
Comma separated list of values.
--content-view-version CONTENT_VIEW_VERSION_VERSION Content view version number
--content-view-version-id CONTENT_VIEW_VERSION_ID Content view version identifier
--description DESCRIPTION The description for the new generated Content View Versions
--environment-ids ENVIRONMENTS list of environment IDs to update the content view version in
Comma separated list of values.
--environments ENVIRONMENT_NAMES Comma separated list of values.
--errata-ids ERRATA_IDS Errata uuids to copy into the new versions.
Comma separated list of values.
--id ID ID of a content view version to incrementally update
--package-ids PACKAGE_IDS Package uuids to copy into the new versions.
Comma separated list of values.
--packages PACKAGE_NAMES Comma separated list of values.
--propagate-all-composites PROPAGATE_ALL_COMPOSITES If true, will publish a new composite version using any specified content_view_version_id that has been promoted to a lifecycle environment.
One of true/false, yes/no, 1/0.
--puppet-module-ids PUPPET_MODULE_IDS Puppet Modules to copy into the new versions.
Comma separated list of values.
--puppet-modules PUPPET_MODULE_NAMES Comma separated list of values.
--resolve-dependencies RESOLVE_DEPENDENCIES If true, when adding the specified errata or packages, any needed dependencies will be copied as well.
One of true/false, yes/no, 1/0.
--search SEARCH Search string for systems to perform an action on
--update-all-systems UPDATE_ALL_SYSTEMS Update all editable and applicable systems, not just ones using the selected Content View Versions and Environments
One of true/false, yes/no, 1/0.
-h, --help print help

Comment 5 sthirugn@redhat.com 2015-05-23 03:41:01 UTC

Are the following options not corresponding to the same id?

--content-view-version-id CONTENT_VIEW_VERSION_ID   Content view version identifier
--id ID                                             ID of a content view version to incrementally update

Comment 6 Eric Helms 2015-05-26 12:34:58 UTC

They are - if you would prefer one, which one?

Comment 7 sthirugn@redhat.com 2015-05-26 13:17:37 UTC

(In reply to Eric Helms from comment #6)
> They are - if you would prefer one, which one?

I think we can go with --content-view-version-id. Because using --id may confuse users between content view id and content view version id.

Comment 8 Bryan Kearney 2015-06-15 14:39:25 UTC

Moving to POST since upstream bug http://projects.theforeman.org/issues/10600 has been closed
-------------
Eric Helms
Applied in changeset commit:hammer-cli-katello|30b9ceff88462c265af4de3376145a5a7c08c3d2.

Comment 10 Bryan Kearney 2015-06-26 14:32:31 UTC

Delivered in Snap10

Comment 11 sthirugn@redhat.com 2015-07-07 20:47:26 UTC

Verified in Sat 6.1 GA Snap 11

Usage:
content-view version incremental-update [OPTIONS]

Options:
--async Do not wait for the task
--content-host-ids CONTENT_HOST_IDS IDs of content hosts to update
Comma separated list of values.
--content-view-version CONTENT_VIEW_VERSION_VERSION Content view version number
--content-view-version-id CONTENT_VIEW_VERSION_ID Content view version identifier
--description DESCRIPTION The description for the new generated Content View Versions
--environment-ids ENVIRONMENTS list of environment IDs to update the content view version in
Comma separated list of values.
--environments ENVIRONMENT_NAMES Comma separated list of values.
--errata-ids ERRATA_IDS Errata uuids to copy into the new versions.
Comma separated list of values.
--package-ids PACKAGE_IDS a package identifier
Comma separated list of values.
--packages PACKAGE_NAMES Comma separated list of values.
--propagate-all-composites PROPAGATE_ALL_COMPOSITES If true, will publish a new composite version using any specified
content_view_version_id that has been promoted to a lifecycle environment.
One of true/false, yes/no, 1/0.
--puppet-module-ids PUPPET_MODULE_IDS a puppet module identifier
Comma separated list of values.
--puppet-modules PUPPET_MODULE_NAMES Comma separated list of values.
--resolve-dependencies RESOLVE_DEPENDENCIES If true, when adding the specified errata or packages, any needed
dependencies will be copied as well.
One of true/false, yes/no, 1/0.
--search SEARCH Search string for systems to perform an action on
--update-all-systems UPDATE_ALL_SYSTEMS Update all editable and applicable systems, not just ones using the
selected Content View Versions and Environments
One of true/false, yes/no, 1/0.
-h, --help print help

Comment 12 Bryan Kearney 2015-08-12 16:04:31 UTC

This bug was fixed in Satellite 6.1.1 which was delivered on 12 August, 2015.

Note You need to log in before you can comment on or make changes to this bug.