Bug 1218602 - Remove replace-brick with data migration support from gluster cli
Summary: Remove replace-brick with data migration support from gluster cli
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: glusterd
Version: 3.7.0
Hardware: x86_64
OS: Linux
high
medium
Target Milestone: ---
Assignee: Gaurav Kumar Garg
QA Contact:
URL:
Whiteboard:
Depends On: 1074429 1094119 1212701 1255645
Blocks: 1074415
TreeView+ depends on / blocked
 
Reported: 2015-05-05 11:40 UTC by Kaushal
Modified: 2016-06-05 23:38 UTC (History)
9 users (show)

Fixed In Version: glusterfs-3.7.0
Clone Of: 1094119
Environment:
Last Closed: 2015-05-14 17:29:37 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Kaushal 2015-05-05 11:40:05 UTC
+++ This bug was initially created as a clone of Bug #1094119 +++

+++ This bug was initially created as a clone of Bug #1074429 +++

Description of problem:
-----------------------
Replace brick operation with data migration has been deprecated.
And this support for "replace-brick" with data migration should be removed from gluster-cli

Version-Release number of selected component (if applicable):
--------------------------------------------------------------
RHS 2.1 Update2 - glusterfs-3.4.0.59rhs-1.el6rhs

How reproducible:
-----------------
Not Applicable

Steps to Reproduce:
-------------------
Not Applicable

Actual results:
---------------
replace-brick with data migration was allowed from gluster-cli

Expected results:
-----------------
replace-brick with data migration should not be allowed

Additional info:
----------------
I ran in to data corruption / data loss cases, when performing replace brick using "replace-brick" command.

It is high-time to disable this replace-brick with data migration from gluster-cli

But replace-brick with force commit could be a useful scenario, where the dead brick could be replaced with new brick, without data migration.
So, replace-brick with "commit force", should only allowed from gluster-cli

--- Additional comment from Anand Avati on 2015-04-01 18:04:11 IST ---

REVIEW: http://review.gluster.org/10101 (glusterd: remove replace brick with data migration support form cli/glusterd) posted (#1) for review on master by Gaurav Kumar Garg (ggarg)

--- Additional comment from Anand Avati on 2015-04-02 16:14:06 IST ---

REVIEW: http://review.gluster.org/10101 (glusterd: remove replace brick with data migration support form cli/glusterd) posted (#2) for review on master by Gaurav Kumar Garg (ggarg)

--- Additional comment from Anand Avati on 2015-04-21 01:07:07 IST ---

REVIEW: http://review.gluster.org/10101 (glusterd: remove replace brick with data migration support form cli/glusterd) posted (#3) for review on master by Gaurav Kumar Garg (ggarg)

--- Additional comment from Anand Avati on 2015-04-25 15:18:11 IST ---

REVIEW: http://review.gluster.org/10101 (glusterd: remove replace brick with data migration support form cli/glusterd) posted (#4) for review on master by Gaurav Kumar Garg (ggarg)

--- Additional comment from Anand Avati on 2015-04-30 14:39:28 IST ---

REVIEW: http://review.gluster.org/10101 (glusterd: remove replace brick with data migration support form cli/glusterd) posted (#5) for review on master by Gaurav Kumar Garg (ggarg)

--- Additional comment from Anand Avati on 2015-04-30 18:53:49 IST ---

REVIEW: http://review.gluster.org/10101 (glusterd: remove replace brick with data migration support form cli/glusterd) posted (#6) for review on master by Gaurav Kumar Garg (ggarg)

--- Additional comment from Anand Avati on 2015-05-03 00:27:23 IST ---

REVIEW: http://review.gluster.org/10101 (glusterd: remove replace brick with data migration support form cli/glusterd) posted (#7) for review on master by Gaurav Kumar Garg (ggarg)

--- Additional comment from Anand Avati on 2015-05-04 14:17:37 IST ---

REVIEW: http://review.gluster.org/10101 (glusterd: remove replace brick with data migration support form cli/glusterd) posted (#8) for review on master by Gaurav Kumar Garg (ggarg)

Comment 1 Anand Avati 2015-05-05 11:42:10 UTC
REVIEW: http://review.gluster.org/10577 (glusterd: remove replace brick with data migration support form cli/glusterd) posted (#2) for review on release-3.7 by Gaurav Kumar Garg (ggarg)

Comment 2 Anand Avati 2015-05-07 07:08:19 UTC
COMMIT: http://review.gluster.org/10577 committed in release-3.7 by Kaushal M (kaushal) 
------
commit f9ebf5ab3cbec423f75e64c25385125d4b65e31b
Author: Gaurav Kumar Garg <ggarg>
Date:   Fri Mar 27 15:20:03 2015 +0530

    glusterd: remove replace brick with data migration support form cli/glusterd
    
    Replace-brick operation with data migration support have been
    deprecated from gluster.
    
    With this fix replace brick command will support only one commad
    
    gluster volume replace-brick <VOLNAME> <SOURCE-BRICK> <NEW-BRICK> {commit force}
    
    Change-Id: Ib81d49e5d8e7eaa4ccb5830cfec2bc081191b43b
    BUG: 1218602
    Signed-off-by: Gaurav Kumar Garg <ggarg>
    Reviewed-on: http://review.gluster.org/10577
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System
    Reviewed-by: Kaushal M <kaushal>

Comment 3 Niels de Vos 2015-05-14 17:29:37 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 4 Niels de Vos 2015-05-14 17:36:00 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 5 Niels de Vos 2015-05-14 17:38:21 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 6 Niels de Vos 2015-05-14 17:47:22 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.