Red Hat Satellite engineering is moving the tracking of its product development work on Satellite to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "Satellite project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs will be migrated starting at the end of May. If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "Satellite project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/SAT-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1218876 - UI should raise an error on creating a host with BMC interface, when BMC feature is not enabled on proxy
Summary: UI should raise an error on creating a host with BMC interface, when BMC feat...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: WebUI
Version: 6.1.0
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: Unspecified
Assignee: Shimon Shtein
QA Contact: Sachin Ghai
URL: http://projects.theforeman.org/issues...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-05-06 06:26 UTC by Sachin Ghai
Modified: 2017-02-23 20:05 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-08-12 16:04:32 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
UI is throwing error under BMC tab only and as a statement (31.80 KB, image/png)
2015-05-06 06:26 UTC, Sachin Ghai
no flags Details
UI raises error while configuring managed bmc interfaces and when no bmc feature is enabled on proxy (48.57 KB, image/png)
2015-07-20 08:46 UTC, Sachin Ghai
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Foreman Issue Tracker 10727 0 None None None 2016-04-22 16:03:47 UTC

Description Sachin Ghai 2015-05-06 06:26:24 UTC
Created attachment 1022487 [details]
UI is throwing error under BMC tab only and as a statement

Description of problem:
I was trying to provision a host and added a new BMC interface from new_host form. I submitted the form and later I realized I forgot to enable the BMC feature on proxy.

Provisioning on the host started without throwing any error on UI. However production.log raises a warning:

--
2015-05-06 11:43:25 [I] Processing by HostsController#bmc as HTML
2015-05-06 11:43:25 [I]   Parameters: {"id"=>"mac525400c75a5e.englab.pnq.redhat.com"}
2015-05-06 11:43:25 [I]   Rendered hosts/_bmc.html.erb (13.7ms)
2015-05-06 11:43:25 [W] Failed to fetch bmc information: ERF42-1518 [Foreman::Exception]: Unable to find a proxy with BMC feature
2015-05-06 11:43:25 [I]   Rendered text template (0.0ms)
2015-05-06 11:43:25 [I] Completed 200 OK in 52ms (Views: 0.7ms | ActiveRecord: 1.6ms)
---

Moreover, when I see the BMC tab on host details page and on clicking the 'BMC' tab, it was showing: Failure: ERF42-1518 [Foreman::Exception]: Unable to find a proxy with BMC feature


This is a usability issue, on submit the form, user should get a proper error message: "Unable to find a proxy with BMC feature" 

 and it should be popped-up on UI.

Version-Release number of selected component (if applicable):
sat6.1 GA Snap2 (Satellite-6.1.0-RHEL-7-20150429.2)

How reproducible:
always

Steps to Reproduce:
1. provision a host with BMC interface and without enabling BMC feature on proxy
2.
3.

Actual results:
when user provisioned a host with BMC interface and without enabling BMC feature, provisioning starts without throwing any error

Expected results:
on submit the form, user should get a proper error message: "Unable to find a proxy with BMC feature" 

 and it should be popped-up on UI.

Additional info:
Please see the BMC tab in attachment.. UI is throwing error under BMC tab only. It should be properly popped-up before actual provisioning starts.

Comment 2 Shimon Shtein 2015-06-08 08:13:54 UTC
Created redmine issue http://projects.theforeman.org/issues/10727 from this bug

Comment 3 Daniel Lobato Garcia 2015-06-08 16:13:43 UTC
I agree it can be more user friendly, however please don't block BMC interfaces creation without BMC proxies, just improve the message if anything. Users might want BMC in foreman just as inventory (seen this use case myself), or Discovery will populate the fields, and we don't want to block users from provisioning valid discovered hosts.

Comment 4 Shimon Shtein 2015-06-23 07:28:39 UTC
Created PR: https://github.com/theforeman/foreman/pull/2441

Comment 6 Bryan Kearney 2015-06-24 12:04:46 UTC
Moving to POST since upstream bug http://projects.theforeman.org/issues/10727 has been closed
-------------
Shimon Shtein
Applied in changeset commit:a9c70fb468054622c322f953949039373d2983c9.

Comment 10 Sachin Ghai 2015-07-20 08:18:15 UTC
I can still see the same error as reported in bz's description:

 ERF42-1518 [Foreman::Exception]: Unable to find a proxy with BMC feature

its is when interfaced is unmanaged. Now trying with managed interface to see the difference.

Comment 11 Sachin Ghai 2015-07-20 08:32:06 UTC
Verifying with Sat6.1.1 GA snap13. UI raises proper error while configuring a managed BMC interface when BMC feature is not enabled on proxy.

This change is applicable only when interface is managed. 

@ Shimon Shtein : could you please confirm if it is expected that UI raises error only when interface is configured as 'managed' ?

Comment 12 Sachin Ghai 2015-07-20 08:46:04 UTC
Created attachment 1053787 [details]
UI raises error while configuring managed bmc interfaces and when no bmc feature is enabled on proxy

Comment 13 Shimon Shtein 2015-07-20 09:43:39 UTC
(In reply to Sachin Ghai from comment #11)
> Verifying with Sat6.1.1 GA snap13. UI raises proper error while configuring
> a managed BMC interface when BMC feature is not enabled on proxy.
> 
> This change is applicable only when interface is managed. 
> 
> @ Shimon Shtein : could you please confirm if it is expected that UI raises
> error only when interface is configured as 'managed' ?

There is no point in checking for valid smart-proxy if the interface is not managed. Non-managed interfaces are not supposed to be provisioned.

Comment 14 Sachin Ghai 2015-07-20 09:45:22 UTC
Moving this to verified based on comments 10-13

Comment 15 Bryan Kearney 2015-08-12 16:04:32 UTC
This bug was fixed in Satellite 6.1.1 which was delivered on 12 August, 2015.


Note You need to log in before you can comment on or make changes to this bug.