Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1218940

Summary:	Spurious failures in fop-sanity.t
Product:	[Community] GlusterFS	Reporter:	Nithya Balachandran <nbalacha>
Component:	tests	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.0	CC:	bugs, gluster-bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1218951 (view as bug list)		Environment:
Last Closed:	2015-05-14 17:29:37 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1218951

Description Nithya Balachandran 2015-05-06 08:56:22 UTC

Description of problem:

tests/basic/fop-sanity.t fails randomly

Version-Release number of selected component (if applicable):


How reproducible:
Randomly on the regression systems
However, it is consistently reproducible if tests/basic/fop-sanity.c is modified to add the following line immediately before the call to open():
fprintf(stdout, "Test string");

Steps to Reproduce:
1.
2.
3.

Actual results:
Result: PASS
tests/basic/fops-sanity.t .. 
1..11
ok 1
ok 2
No volumes present
ok 3
ok 4
ok 5
ok 6
ok 7
ok 8
volume set: success
ok 9
read failed: No data available
read returning junk
fd based file operation 1 failed
read failed: No data available
read returning junk
fstat failed : No data available
fd based file operation 2 failed
read failed: No data available
read returning junk
dup fd based file operation failed
not ok 10 
FAILED COMMAND: ./fops-sanity damn
/home/nbalachandran/Projects/gluster/code/glusterfs
ok 11
Failed 1/11 subtests

Expected results:
Test should pass

Additional info:

Comment 1 Nithya Balachandran 2015-05-06 08:59:51 UTC

The man page for open() states that the mode must be passed in if the flags include O_CREAT. The calls to open() in the fops-sanity.c did not include the mode argument. This seemed to cause the file to be created with some random mode which ended up creating a 'T' file. DHT then proceeded to treat the file as a linkto file instead of a data file, causing the test to fail.

Fix:
Provide a mode argument to the open() calls.

Comment 2 Nithya Balachandran 2015-05-07 10:24:07 UTC

http://review.gluster.org/#/c/10627/

Comment 3 Anand Avati 2015-05-07 16:47:49 UTC

REVIEW: http://review.gluster.org/10627 (tests: Spurious failure in fop-sanity.t) posted (#2) for review on release-3.7 by N Balachandran (nbalacha)

Comment 4 Niels de Vos 2015-05-14 17:29:37 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 5 Niels de Vos 2015-05-14 17:36:00 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 6 Niels de Vos 2015-05-14 17:38:22 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 7 Niels de Vos 2015-05-14 17:47:22 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user