Bug 1218944 - Replace all instances of the term "Foreman" with "Red Hat Satellite"
Summary: Replace all instances of the term "Foreman" with "Red Hat Satellite"
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.4.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.4.0
Assignee: Harpreet Kataria
QA Contact: Jan Krocil
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-05-06 09:03 UTC by John Hardy
Modified: 2015-06-16 13:01 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-06-16 13:01:43 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2015:1100 0 normal SHIPPED_LIVE CFME 5.4.0 bug fixes, and enhancement update 2015-06-16 16:28:42 UTC

Description John Hardy 2015-05-06 09:03:35 UTC
Please replace any mention of the term "Foreman" with "Red Hat Satellite"

thanks

Comment 4 CFME Bot 2015-05-07 19:45:58 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/0e3c4278bf3e28e505a7b5e5f6dff194a9f3f66f

commit 0e3c4278bf3e28e505a7b5e5f6dff194a9f3f66f
Author:     Eric Winchell <ewinchel>
AuthorDate: Thu May 7 15:39:31 2015 -0400
Commit:     Eric Winchell <ewinchel>
CommitDate: Thu May 7 15:39:31 2015 -0400

    Added Satellite icons
    https://bugzilla.redhat.com/show_bug.cgi?id=1218944
    [skip ci]

 vmdb/public/images/icons/new/vendor-satellite.png        | Bin 0 -> 4209 bytes
 .../images/icons/new/vendor-satellite_configuration.png  | Bin 0 -> 4209 bytes
 2 files changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 vmdb/public/images/icons/new/vendor-satellite.png
 create mode 100644 vmdb/public/images/icons/new/vendor-satellite_configuration.png

Comment 5 CFME Bot 2015-05-08 14:00:54 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/d273522bed2b76303fe1ebdd95a6cab2502ee56b

commit d273522bed2b76303fe1ebdd95a6cab2502ee56b
Author:     Jason Frey <jfrey>
AuthorDate: Thu May 7 15:32:14 2015 -0400
Commit:     Jason Frey <jfrey>
CommitDate: Thu May 7 16:43:59 2015 -0400

    Avoid hardcoding the foreman image name to allow for subclassing.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1218944

 vmdb/app/helpers/provider_foreman_helper.rb            |  2 +-
 vmdb/app/models/provider.rb                            |  4 ++++
 vmdb/app/presenters/tree_node_builder.rb               | 13 ++++++++++---
 vmdb/app/views/layouts/quadicon/_single_quad.html.haml |  2 +-
 4 files changed, 16 insertions(+), 5 deletions(-)

Comment 6 CFME Bot 2015-05-08 21:17:29 UTC
New commit detected on cfme_productization/master:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme_productization.git;a=commit;h=d2b95f33cb3d6d02663df88747855cf09e27b9f5

commit d2b95f33cb3d6d02663df88747855cf09e27b9f5
Author:     Jason Frey <jfrey>
AuthorDate: Thu May 7 17:24:48 2015 -0400
Commit:     Jason Frey <jfrey>
CommitDate: Thu May 7 18:01:15 2015 -0400

    Add overrides for Foreman image_name methods to be "satellite"
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1218944

 linker.rb                                                 |  3 +++
 .../config/initializers/override_foreman_image_name.rb    | 15 +++++++++++++++
 2 files changed, 18 insertions(+)
 create mode 100644 manageiq/vmdb/config/initializers/override_foreman_image_name.rb

Comment 7 CFME Bot 2015-05-08 21:17:33 UTC
New commit detected on cfme_productization/master:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme_productization.git;a=commit;h=a0cb8d09f6b6815a85a4af1d854092536b1c13cb

commit a0cb8d09f6b6815a85a4af1d854092536b1c13cb
Merge: b60104b d2b95f3
Author:     Dan Clarizio <dclarizi>
AuthorDate: Fri May 8 17:15:19 2015 -0400
Commit:     Dan Clarizio <dclarizi>
CommitDate: Fri May 8 17:15:19 2015 -0400

    Merge branch 'override_foreman_image_name' into 'master'
    
    Add overrides for Foreman image_name methods to be "satellite"
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1218944
    
    See merge request !32

 linker.rb                                                 |  3 +++
 .../config/initializers/override_foreman_image_name.rb    | 15 +++++++++++++++
 2 files changed, 18 insertions(+)

Comment 8 CFME Bot 2015-05-08 22:18:00 UTC
New commit detected on cfme_productization/master:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme_productization.git;a=commit;h=4eca56076c9b19f3d6657f614c6033c4bb6e1250

commit 4eca56076c9b19f3d6657f614c6033c4bb6e1250
Author:     Harpreet Kataria <hkataria>
AuthorDate: Fri May 8 18:03:36 2015 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Fri May 8 18:03:36 2015 -0400

    Changes to use dictionary lookup to show correct label for "Foreman" in UI
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1218944

 manageiq/vmdb/config/locales/en_productization.yml | 2 ++
 1 file changed, 2 insertions(+)

Comment 9 CFME Bot 2015-05-08 22:18:05 UTC
New commit detected on cfme_productization/master:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme_productization.git;a=commit;h=32df14fca165ae23e7c2d8f876d8d7740e83d273

commit 32df14fca165ae23e7c2d8f876d8d7740e83d273
Merge: a0cb8d0 4eca560
Author:     Dan Clarizio <dclarizi>
AuthorDate: Fri May 8 18:17:39 2015 -0400
Commit:     Dan Clarizio <dclarizi>
CommitDate: Fri May 8 18:17:39 2015 -0400

    Merge branch 'foreman_label_changes' into 'master'
    
    Changes to use dictionary lookup to show correct label for "Foreman" in UI
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1218944
    
    @dclarizio please review/test.
    
    See merge request !35

 manageiq/vmdb/config/locales/en_productization.yml | 2 ++
 1 file changed, 2 insertions(+)

Comment 10 CFME Bot 2015-05-08 22:20:59 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/1a650ce93f7051917a368c3ef5d22485b7df9cf9

commit 1a650ce93f7051917a368c3ef5d22485b7df9cf9
Author:     Harpreet Kataria <hkataria>
AuthorDate: Fri May 8 16:42:04 2015 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Fri May 8 17:10:28 2015 -0400

    Changes to use dictionary lookup to show "Foreman" in UI
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1218944

 vmdb/app/assets/javascripts/miq_dhtmlxaccordion.js |  2 +-
 .../app/controllers/provider_foreman_controller.rb | 22 +++++++++---------
 vmdb/app/helpers/application_helper.rb             |  2 ++
 vmdb/app/models/ems_refresh/parsers/foreman.rb     |  4 ++--
 .../miq_provision_configured_system_request.rb     |  2 +-
 vmdb/app/models/miq_request.rb                     |  2 +-
 vmdb/app/presenters/tree_builder.rb                |  8 +++++--
 vmdb/config/locales/en.yml                         |  2 ++
 vmdb/config/locales/manageiq.pot                   | 12 ----------
 vmdb/db/fixtures/miq_product_features.yml          | 26 +++++++++++-----------
 vmdb/lib/vmdb/global_methods.rb                    |  6 +++++
 ...rovision_configured_system_foreman_dialogs.yaml |  2 +-
 .../configuration_profile_foreman_center_tb.yaml   | 14 ++++++------
 .../toolbars/provider_foreman_center_tb.yaml       |  4 ++--
 .../provider_foreman_controller_spec.rb            |  4 ++--
 vmdb/spec/models/miq_request_spec.rb               |  2 +-
 16 files changed, 59 insertions(+), 55 deletions(-)

Comment 14 Jan Krocil 2015-06-05 06:57:48 UTC
Verified fixed in 5.4.0.4 (5.4.0.4.20150528174021_88cc76c).

Checked the UI and made a thorough code inspection and couldn't find any mention of foreman where it shouldn't be ("foreman" is still obviously present in models, routes etc but not in the UI).

Comment 16 errata-xmlrpc 2015-06-16 13:01:43 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1100.html


Note You need to log in before you can comment on or make changes to this bug.