Bug 1219432 - Default chroot_scan plug-in config, if uncommented, doesn't exclude procfs files
Summary: Default chroot_scan plug-in config, if uncommented, doesn't exclude procfs files
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: mock
Version: 23
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Miroslav Suchý
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-05-07 10:36 UTC by David Howells
Modified: 2015-10-07 04:06 UTC (History)
6 users (show)

Fixed In Version: 1.2.13-2.fc22 mock-1.2.13-2.fc21 mock-1.2.13-2.el7 mock-1.2.13-2.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-09-23 04:10:01 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1190763 0 unspecified CLOSED RFE: Can Koji be made to grab logs from a tree it has just built or failed to build? 2021-02-22 00:41:40 UTC

Internal Links: 1190763

Description David Howells 2015-05-07 10:36:17 UTC
Description of problem:

If I uncomment the chroot_scan plugin options in site-defaults.cfg so as to gather logs and core files, it seems to sit for a long time in this state:

16724 pts/0    S+     0:00          |   \_ /usr/bin/python /usr/bin/fedpkg mockbuild
16748 pts/0    S+     0:04          |       \_ /usr/bin/python -tt /usr/sbin/mock -r fedora-20-x86_64 --resultdir /data/fedora/cross-binutils/results_cross-binutils/2.25/3.fc20 --rebuild /data/fedora/cross-binutils/cross-binutils-2.25-3.fc20.src.rpm
 9142 pts/0    R+     0:10          |           \_ cp --parents /var/lib/mock/fedora-20-x86_64/root/proc/kcore /data/fedora/cross-binutils/results_cross-binutils/2.25/3.fc20/chroot_scan

It appears that the config, as below:

config_opts['plugin_conf']['chroot_scan_enable'] = True
config_opts['plugin_conf']['chroot_scan_opts'] = {
# Regexp of files which should be copied from buildroot to resultdir.
   'regexes': [ "core(\.\d+)?", "\.log$",],
# If set to True files are copied only if build failed.
   'only_failed': False,
}

doesn't exclude procfs files such as /proc/kcore.

Version-Release number of selected component (if applicable):

mock-1.2.8-1.fc21.noarch

How reproducible:

100%

Steps to Reproduce:
1. Uncomment config lines
2. fedpkg mockbuild something.  I'm using cross-binutils with the specfile modified to have build_all set to 0 and build_x86_64 set to 1.

Actual results:

Sits for a long time copying /proc/kcore (I assume it finishes at some point, but will sit for at least 15 minutes).

Expected results:

Shouldn't pick up /proc/kcore, but should pick up various config.log files generated by the build.

Additional info:

See also: https://bugzilla.redhat.com/show_bug.cgi?id=1190763

Comment 1 Miroslav Suchý 2015-07-07 15:54:06 UTC
I changed the regexp to:
  "^[^k]?core(\.\d+)?"
It is not ideal and robust, but should work in this case. I have robust regexp, but it is hard to read and understand and I do not think such string should be in examples.

Ideas for regexp which does not match kcore but match usual coredumps names are welcome.

Fixed in commit:
* be95515 do not include kcore in default regexp for chroot_scan plugin [RHBZ#1219432]

Comment 2 Jan Kurik 2015-07-15 14:11:18 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle.
Changing version to '23'.

(As we did not run this process for some time, it could affect also pre-Fedora 23 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23

Comment 3 Fedora Update System 2015-09-16 20:02:16 UTC
mock-1.2.13-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16053

Comment 4 Fedora Update System 2015-09-16 20:05:12 UTC
mock-1.2.13-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16054

Comment 5 Fedora Update System 2015-09-16 20:07:16 UTC
mock-1.2.13-2.fc21 has been submitted as an update to Fedora 21. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16056

Comment 6 Fedora Update System 2015-09-16 20:08:55 UTC
mock-1.2.13-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8114

Comment 7 Fedora Update System 2015-09-16 20:10:02 UTC
mock-1.2.13-2.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8115

Comment 8 Fedora Update System 2015-09-17 21:30:25 UTC
mock-1.2.13-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update mock'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16054

Comment 9 Fedora Update System 2015-09-18 05:21:16 UTC
mock-1.2.13-2.fc21 has been pushed to the Fedora 21 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update mock'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16056

Comment 10 Fedora Update System 2015-09-18 16:24:51 UTC
mock-1.2.13-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update mock'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16053

Comment 11 Fedora Update System 2015-09-19 03:20:11 UTC
mock-1.2.13-2.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update mock'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8115

Comment 12 Fedora Update System 2015-09-19 03:22:00 UTC
mock-1.2.13-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update mock'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8114

Comment 13 Fedora Update System 2015-09-23 04:09:03 UTC
mock-1.2.13-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2015-09-24 08:22:31 UTC
mock-1.2.13-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2015-10-05 22:51:02 UTC
mock-1.2.13-2.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2015-10-07 03:05:29 UTC
mock-1.2.13-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2015-10-07 04:05:47 UTC
mock-1.2.13-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.