Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1219622

Summary:	CustomDeviceProperties in engine-config should be mergeable
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Marina Kalinin <mkalinin>
Component:	ovirt-engine-config	Assignee:	Eli Mesika <emesika>
Status:	CLOSED WONTFIX	QA Contact:	Jiri Belka <jbelka>
Severity:	low	Docs Contact:
Priority:	medium
Version:	3.5.1	CC:	ecohen, gklein, lsurette, myakove, oourfali, pstehlik, rbalakri, Rhev-m-bugs, yeylon
Target Milestone:	---
Target Release:	3.6.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	infra
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-07-27 14:19:44 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Infra	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Marina Kalinin 2015-05-07 20:00:02 UTC

CustomDeviceProperties in engine config should be mergeable.
Today, the definition in /etc/ovirt-engine/engine-config/engine-config.properties is:
~~~
CustomDeviceProperties.description="Definition of custom properties per each device type"
CustomDeviceProperties.type=DeviceCustomProperties
~~~

Customer is asking to have it also mergeable and with delimiter ';'.
Since ';' is already the default behaviour, what is needed is just to add this line to the properties file:

CustomDeviceProperties.description="Definition of custom properties per each device type"
CustomDeviceProperties.type=DeviceCustomProperties
+CustomDeviceProperties.mergable=true


Easy fix, imo.
Of course, the workaround is to update this in the properties file itself manually.

Comment 1 Eli Mesika 2015-07-27 14:19:44 UTC

Seems that this property had some non trivial merging rules [1]
The mergable property can be set only for keys that support appending values using a custom delimiter 

Closing this as WONTFIX since there is no simple/generic way to achieve that 

For more information see the comments on 
https://gerrit.ovirt.org/#/c/40708/

Comment 2 Marina Kalinin 2017-03-04 04:12:35 UTC

So, I am reading this bug again and I still do not understand how this config should behave.

For instance, if we want to follow the instructions in this bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1400366 and run this:
# engine-config -s CustomDeviceProperties='{type=interface;prop={default_route=^(true|false)$}}'

How can I modify this parameter with this new value and without deleting the current default value it has, the "SecurityGroups" one? Isn't it what the Merge option for?

See more details here:
http://pastebin.test.redhat.com/461487

Meni, maybe you can help please?

Comment 3 Marina Kalinin 2017-03-07 03:34:54 UTC

Ok, figured that out:
https://access.redhat.com/solutions/2956461