Spec URL: http://www.cora.nwra.com/~orion/fedora/python-terminado.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/python-terminado-0.5-1.fc21.src.rpm Description: This is a Tornado websocket backend for the term.js Javascript terminal emulator library. Fedora Account System Username: orion http://koji.fedoraproject.org/koji/taskinfo?taskID=9681632
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Issues ===== - version in last changelog entry is not latest ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. Note: version in last changelog entry is not latest [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-terminado-0.5-1.fc23.noarch.rpm python3-terminado-0.5-1.fc23.noarch.rpm python-terminado-0.5-1.fc23.src.rpm python-terminado.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j python-terminado.noarch: W: spelling-error Summary(en_US) websockets -> web sockets, web-sockets, sockets python-terminado.noarch: W: spelling-error %description -l en_US websocket -> web socket, web-socket, socket python-terminado.noarch: W: spelling-error %description -l en_US backend -> backed, back end, back-end python-terminado.noarch: W: spelling-error %description -l en_US js -> dis, ks, j python-terminado.noarch: W: incoherent-version-in-changelog 0.2.2-1 ['0.5-1.fc23', '0.5-1'] python3-terminado.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j python3-terminado.noarch: W: spelling-error Summary(en_US) websockets -> web sockets, web-sockets, sockets python3-terminado.noarch: W: spelling-error %description -l en_US websocket -> web socket, web-socket, socket python3-terminado.noarch: W: spelling-error %description -l en_US backend -> backed, back end, back-end python3-terminado.noarch: W: spelling-error %description -l en_US js -> dis, ks, j python-terminado.src: W: spelling-error Summary(en_US) js -> dis, ks, j python-terminado.src: W: spelling-error Summary(en_US) websockets -> web sockets, web-sockets, sockets python-terminado.src: W: spelling-error %description -l en_US websocket -> web socket, web-socket, socket python-terminado.src: W: spelling-error %description -l en_US backend -> backed, back end, back-end python-terminado.src: W: spelling-error %description -l en_US js -> dis, ks, j 3 packages and 0 specfiles checked; 0 errors, 16 warnings. Rpmlint (installed packages) ---------------------------- python3-terminado.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j python3-terminado.noarch: W: spelling-error Summary(en_US) websockets -> web sockets, web-sockets, sockets python3-terminado.noarch: W: spelling-error %description -l en_US websocket -> web socket, web-socket, socket python3-terminado.noarch: W: spelling-error %description -l en_US backend -> backed, back end, back-end python3-terminado.noarch: W: spelling-error %description -l en_US js -> dis, ks, j python-terminado.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j python-terminado.noarch: W: spelling-error Summary(en_US) websockets -> web sockets, web-sockets, sockets python-terminado.noarch: W: spelling-error %description -l en_US websocket -> web socket, web-socket, socket python-terminado.noarch: W: spelling-error %description -l en_US backend -> backed, back end, back-end python-terminado.noarch: W: spelling-error %description -l en_US js -> dis, ks, j python-terminado.noarch: W: incoherent-version-in-changelog 0.2.2-1 ['0.5-1.fc23', '0.5-1'] 2 packages and 0 specfiles checked; 0 errors, 11 warnings. Requires -------- python3-terminado (rpmlib, GLIBC filtered): python(abi) python3-ptyprocess python3-tornado python-terminado (rpmlib, GLIBC filtered): python(abi) python-ptyprocess python-tornado Provides -------- python3-terminado: python3-terminado python-terminado: python-terminado Source checksums ---------------- https://github.com/takluyver/terminado/archive/0.5.tar.gz#/terminado-0.5.tar.gz : CHECKSUM(SHA256) this package : 54c64d1416686f58103163310621875ce691b056bf0aa7e3efd8a6c59532223c CHECKSUM(SHA256) upstream package : 54c64d1416686f58103163310621875ce691b056bf0aa7e3efd8a6c59532223c Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04 Command line :/usr/bin/fedora-review -b 1219662 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Sorry, this got lost while on vacation. Spec URL: http://www.cora.nwra.com/~orion/fedora/python-terminado.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/python-terminado-0.5-2.fc21.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=10331229 * Fri Jul 10 2015 Orion Poplawski <orion.com> - 0.5-2 - Build python2/3 from same tree - BR/R tornado 4.0.0 - Fix changelog version number
(In reply to John Trowbridge from comment #1) Will you take this review or I can take it?
Spec URL: http://www.cora.nwra.com/~orion/fedora/python-terminado.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/python-terminado-0.5-3.fc21.src.rpm * Mon Jul 27 2015 Orion Poplawski <orion.com> - 0.5-3 - Add python2-terminado provides
(In reply to William Moreno from comment #3) > (In reply to John Trowbridge from comment #1) > > > Will you take this review or I can take it? Go for it. Thanks!
Hi 1- There are some new cool macros for packaging python: %py2_build %py3_build %py2_install %py3_install than you can use. 2- The python-tornado versión needed it is only in F23 on, there is a python-tornado package in RHEL7 but I am not sure about the versión, the python-tornado version need if is not available in epel6. 3- There is python-sphinx documentation directory in https://github.com/takluyver/terminado/tree/master/doc than you build with python-sphinx and include in a -doc subpackage.
Hi, do want to continue with this review?
Yes, but I've been on vacation. Will address issues soon.
I'm unable to run the ipython notebook in fedora 23. The terminal states that the module terminado is unavailable. I assume that this package is a requirement for the notebook.: python-terminado python3-terminado Is this correct? Could someone advise regarding how to use the ipython notebook in fedora 23? If this missing package is the problem can someone summarize what needs to be done?
orion's scratch build of python-terminado-0.6-1.fc24.src.rpm for f24-candidate failed http://koji.fedoraproject.org/koji/taskinfo?taskID=13101706
orion's scratch build of python-terminado-0.6-1.fc24.src.rpm for f24-candidate completed http://koji.fedoraproject.org/koji/taskinfo?taskID=13102226
* Mon Feb 22 2016 Orion Poplawski <orion.com> - 0.6-1 - Update to 0.6 - Modernize spec Spec URL: http://www.cora.nwra.com/~orion/fedora/python-terminado.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/python-terminado-0.6-1.fc24.src.rpm
Given that William Moreno changed the assignee to nobody, I will take this review. I sent him email and am happy to give it back to him if desired.
Just FYI mock build on CentOS7 fails: DEBUG util.py:435: Error: No Package found for python2-nose DEBUG util.py:435: Error: No Package found for python2-ptyprocess DEBUG util.py:435: Error: No Package found for python2-tornado >= 4.0.0 DEBUG util.py:435: Error: No Package found for python34-ptyprocess Koji EPEL7 build: https://koji.fedoraproject.org/koji/taskinfo?taskID=17248219 same result, of course :) Koji builds for F24, F25, rawhide all ok. F24: https://koji.fedoraproject.org/koji/taskinfo?taskID=17248224 F25: https://koji.fedoraproject.org/koji/taskinfo?taskID=17248221 rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=17248273 Had an issue with fedora-review on F24: error: line 29: Package does not exist: %description -n python2-terminado having proxy issues on my F25 box, so more later.
Confirmed that William is busy, so I will continue with the review.
nosetests → nosetests -v
* Thu Feb 23 2017 Orion Poplawski <orion.com> - 0.6-2 - Run tests verbosely - Do build for python2 on EPEL Spec URL: http://www.cora.nwra.com/~orion/fedora/python-terminado.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/python-terminado-0.6-2.fc26.src.rpm EPEL7 needs https://bodhi.fedoraproject.org/updates/python-ptyprocess-0.5.1-6.el7 which has a buildroot override.
In Comment 17, I believe you meant "Do NOT build for python2 on EPEL", which is what it says in the ChangeLog (python2-tornado package is too old on EPEL). [x] Latest version is packaged [x] nosetests -v (tests run verbosely) Builds and all tests pass on F26 Rawhide and EPEL7 (Bonus, thank you!). All review comments have been properly addressed. I am not including the result of fedora-review since it is not significantly different than the first review (except for the above two resolved issues). APPROVED
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-terminado
python-terminado-0.6-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-4a054377c6
python-terminado-0.6-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f4b16616ba
python-terminado-0.6-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0235809c7f
python-terminado-0.6-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-4a054377c6
python-terminado-0.6-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-0235809c7f
python-terminado-0.6-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f4b16616ba
python-terminado-0.6-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
python-terminado-0.6-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
python-terminado-0.6-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.