Spec URL: https://dshea.fedorapeople.org/requests/python-requests-file.spec SRPM URL: https://dshea.fedorapeople.org/requests/python-requests-file-1.2-1.fc21.src.rpm Description: Requests-File is a transport adapter for use with the Requests Python library to allow local filesystem access via file:// URLs. Fedora Account System Username: dshea
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-requests-file-1.2-1.fc20.noarch.rpm python3-requests-file-1.2-1.fc20.noarch.rpm python-requests-file-1.2-1.fc20.src.rpm python-requests-file.noarch: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically python3-requests-file.noarch: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically python-requests-file.src: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically 3 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- python-requests-file.noarch: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically python3-requests-file.noarch: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Requires -------- python-requests-file (rpmlib, GLIBC filtered): python(abi) python-requests python-six python3-requests-file (rpmlib, GLIBC filtered): python(abi) python3-requests python3-six Provides -------- python-requests-file: python-requests-file python3-requests-file: python3-requests-file Source checksums ---------------- https://pypi.python.org/packages/source/r/requests-file/requests-file-1.2.tar.gz : CHECKSUM(SHA256) this package : becc9a00923f662a9435987190eed4c3f405b7d187de25e0b71cfcffc9bea97e CHECKSUM(SHA256) upstream package : becc9a00923f662a9435987190eed4c3f405b7d187de25e0b71cfcffc9bea97e
Blah, blah, blah. I'll let you decide if "filesystem" is a typo. I think we made that two words in anaconda. Also there doesn't appear to be a %check that runs the tests/ directory.
(In reply to Chris Lumens from comment #2) > Blah, blah, blah. > > I'll let you decide if "filesystem" is a typo. I think we made that two > words in anaconda. We do, I'll change it in the spec. > Also there doesn't appear to be a %check that runs the tests/ directory. There is not, because it failed in copr due to locale junk that I assume is not available in mock. I promise to run the checks before I upload to pypi.
(In reply to David Shea from comment #3) > > Also there doesn't appear to be a %check that runs the tests/ directory. > > There is not, because it failed in copr due to locale junk that I assume is > not available in mock. I promise to run the checks before I upload to pypi. And that was apparently something copr messed up. It worked fine in a scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9687495 Whatever. I'll revert https://github.com/dashea/requests-file/commit/164144e52f77c3e400cde7e0e297d660aef5b7d1
New Package SCM Request ======================= Package Name: python-requests-file Short Description: Transport adapter for using file:// URLs with python-requests Upstream URL: https://github.com/dashea/requests-file Owners: dshea Branches: f21 f22 InitialCC:
Git done (by process-git-requests).
python-requests-file-1.2-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-requests-file-1.2-1.fc22
python-requests-file-1.2-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-requests-file-1.2-1.fc21
python-requests-file-1.2-1.fc22 has been pushed to the Fedora 22 testing repository.
python-requests-file-1.2-1.fc21 has been pushed to the Fedora 21 stable repository.
python-requests-file-1.2-1.fc22 has been pushed to the Fedora 22 stable repository.