The bug wasn't fixed,
steps to repurduce the bug :
1. create 20 vm's from pool
2. select all the vms and start them and the shutdown the vm very quickly.
3. look at mom log.
you can still see the error :
2015-05-28 11:13:02,600 - mom.vdsmInterface - ERROR - Virtual machine does not exist
2015-05-28 11:13:02,600 - mom.vdsmInterface - ERROR - Traceback (most recent call last):
File "/usr/lib/python2.6/site-packages/mom/HypervisorInterfaces/vdsmInterface.py", line 171, in getVmCpuTuneInfo
self._check_status(response)
File "/usr/lib/python2.6/site-packages/mom/HypervisorInterfaces/vdsmInterface.py", line 46, in _check_status
raise vdsmException(response, self.logger)
vdsmException
tried to verify on :
MOM version : mom-0.4.1-5.el6ev.noarch
RHEVM Version: 3.5.3-0.2.el6ev
But the log is still supposed to contain the traceback. The patch just adds the explanation message.
Commit message:
The stacktrace will still get logged, but there will be human readable
reason why it happened. Please note that this situation is rare so we shouldn't
have problems with log floods
i think that the fix should be change because it was not implemented correctly
as jmoskovc wrote:
The proper fix here is to handle the exception in nicer way and just print a warning that the VM dissapeared while mom was processing it.
in the fix, the message is not more clear, it's still writen that "the vm does not exists" instead of "the VM dissapeared while mom was processing it"
also, it should be a warning and not an error.
The bug wasn't fixed, steps to repurduce the bug : 1. create 20 vm's from pool 2. select all the vms and start them and the shutdown the vm very quickly. 3. look at mom log. you can still see the error : 2015-05-28 11:13:02,600 - mom.vdsmInterface - ERROR - Virtual machine does not exist 2015-05-28 11:13:02,600 - mom.vdsmInterface - ERROR - Traceback (most recent call last): File "/usr/lib/python2.6/site-packages/mom/HypervisorInterfaces/vdsmInterface.py", line 171, in getVmCpuTuneInfo self._check_status(response) File "/usr/lib/python2.6/site-packages/mom/HypervisorInterfaces/vdsmInterface.py", line 46, in _check_status raise vdsmException(response, self.logger) vdsmException tried to verify on : MOM version : mom-0.4.1-5.el6ev.noarch RHEVM Version: 3.5.3-0.2.el6ev