Bug 1220131 - Review Request: perl-Test-Deep-Type - Test::Deep plugin for validating type constraints
Summary: Review Request: perl-Test-Deep-Type - Test::Deep plugin for validating type c...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-05-10 10:25 UTC by Emmanuel Seyman
Modified: 2015-05-14 09:57 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-05-14 09:57:47 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Emmanuel Seyman 2015-05-10 10:25:08 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Test-Deep-Type/perl-Test-Deep-Type.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Test-Deep-Type/perl-Test-Deep-Type-0.006-1.fc21.src.rpm
Description:
Test::Deep::Type provides the sub is_type to indicate that the data being
tested must validate against the passed type. This is an actual type
object, not a string name -- for example something provided via
MooseX::Types, or a plain old coderef that returns a bool (such as what
might be used in a Moo type constraint).

Fedora Account System Username: eseyman

This package is needed to update MooseX-Storage to its latest version

Comment 1 Jitka Plesnikova 2015-05-11 09:03:39 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Test-Deep-Type-0.006-1.fc23.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.20.2)
      1 perl(Exporter)
      1 perl(Safe::Isa)
      1 perl(Scalar::Util)
      1 perl(Test::Deep::Cmp)
      1 perl(Try::Tiny)
      1 perl(namespace::clean)
      1 perl(parent)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Test-Deep-Type-0.006-1.fc23.noarch.rpm | sort | uniq -c
      1 perl(Test::Deep::Type) = 0.006
      1 perl-Test-Deep-Type = 0.006-1.fc23
Binary provides are Ok.

$ rpmlint ./perl-Test-Deep-Type*
perl-Test-Deep-Type.noarch: W: spelling-error %description -l en_US coderef -> code ref, code-ref, coder
perl-Test-Deep-Type.noarch: W: spelling-error %description -l en_US bool -> biol, boil, book
perl-Test-Deep-Type.src: W: spelling-error %description -l en_US coderef -> code ref, code-ref, coder
perl-Test-Deep-Type.src: W: spelling-error %description -l en_US bool -> biol, boil, book
2 packages and 1 specfiles checked; 0 errors, 4 warnings.

Rpmlint is ok

FIX: Please add BR perl(if), perl(overload), perl(strict) and
     perl(warnings)

TODO: You can add examples/ to the doc.

Otherwise package is good.
APPROVED.

Comment 2 Emmanuel Seyman 2015-05-11 14:23:30 UTC
(In reply to Jitka Plesnikova from comment #1)
> 
> FIX: Please add BR perl(if), perl(overload), perl(strict) and
>      perl(warnings)

Done.

> TODO: You can add examples/ to the doc.

Done.

> APPROVED.

Thank you, Jikta. Requesting SCM.


New Package SCM Request
=======================
Package Name: perl-Test-Deep-type
Short Description: Test::Deep plugin for validating type constraints
Upstream URL: http://search.cpan.org/dist/Test-Deep-Type/
Owners: eseyman
Branches: f22
InitialCC: perl-sig

Comment 3 Gwyn Ciesla 2015-05-11 18:10:01 UTC
WARNING: Requested package name perl-Test-Deep-type doesn't match bug
summary perl-Test-Deep-Type

Comment 4 Emmanuel Seyman 2015-05-12 15:04:21 UTC
Once more, with the correct case.

New Package SCM Request
=======================
Package Name: perl-Test-Deep-Type
Short Description: Test::Deep plugin for validating type constraints
Upstream URL: http://search.cpan.org/dist/Test-Deep-Type/
Owners: eseyman
Branches: f22
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2015-05-12 17:45:36 UTC
Git done (by process-git-requests).

Comment 6 Emmanuel Seyman 2015-05-14 09:57:47 UTC
Built for rawhide.


Note You need to log in before you can comment on or make changes to this bug.