Bug 1221095 - Fix nfs/mount3.c build warnings reported in Koji
Summary: Fix nfs/mount3.c build warnings reported in Koji
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: nfs
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Vijay Bellur
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1222198
TreeView+ depends on / blocked
 
Reported: 2015-05-13 09:33 UTC by Vijay Bellur
Modified: 2016-06-16 13:00 UTC (History)
4 users (show)

Fixed In Version: glusterfs-3.8rc2
Clone Of:
: 1222198 (view as bug list)
Environment:
Last Closed: 2016-06-16 13:00:40 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Vijay Bellur 2015-05-13 09:33:50 UTC
Description of problem:

This was observed in koji. Reported by Kaleb Keithley.

mount3.c: In function '__mnt3_build_mountid_from_path':
mount3.c:705:24: warning: 'sizeof' on array function parameter 'mountid' will return size of 'unsigned char *' [-Wsizeof-array-argument]
         length = sizeof(mountid);
                        ^
mount3.c:699:58: note: declared here
 __mnt3_build_mountid_from_path (const char *path, uuid_t mountid)
                                                          ^
mount3.c: In function '__mnt3_get_mount_id':
mount3.c:732:24: warning: 'sizeof' on array function parameter 'mountid' will return size of 'unsigned char *' [-Wsizeof-array-argument]
         length = sizeof(mountid);
                        ^
mount3.c:726:46: note: declared here
 __mnt3_get_mount_id (xlator_t *mntxl, uuid_t mountid)

Version-Release number of selected component (if applicable): mainline

Comment 1 Anand Avati 2015-05-13 09:43:35 UTC
REVIEW: http://review.gluster.org/10765 (nfs: Use uuid_clear() instead of memset) posted (#1) for review on master by Vijay Bellur (vbellur)

Comment 2 Anand Avati 2015-05-13 11:53:22 UTC
REVIEW: http://review.gluster.org/10765 (nfs: Use uuid_clear() instead of memset) posted (#2) for review on master by Vijay Bellur (vbellur)

Comment 3 Anand Avati 2015-05-16 08:23:33 UTC
COMMIT: http://review.gluster.org/10765 committed in master by Niels de Vos (ndevos) 
------
commit df12f00851a234b0e892af4b958e606a1fa660ed
Author: Vijay Bellur <vbellur>
Date:   Wed May 13 11:41:31 2015 +0200

    nfs: Use uuid_clear() instead of memset
    
    Fixes the following incorrect usage:
    
    mount3.c: In function '__mnt3_build_mountid_from_path':
    mount3.c:705:24: warning: 'sizeof' on array function parameter 'mountid' will
    return size of 'unsigned char *' [-Wsizeof-array-argument]
             length = sizeof(mountid);
                            ^
    mount3.c:699:58: note: declared here
     __mnt3_build_mountid_from_path (const char *path, uuid_t mountid)
                                                              ^
    mount3.c: In function '__mnt3_get_mount_id':
    mount3.c:732:24: warning: 'sizeof' on array function parameter 'mountid' will
    return size of 'unsigned char *' [-Wsizeof-array-argument]
             length = sizeof(mountid);
                            ^
    mount3.c:726:46: note: declared here
     __mnt3_get_mount_id (xlator_t *mntxl, uuid_t mountid)
    
    Change-Id: I08f46c5994578fc99a7b61681e808d1115e41d71
    BUG: 1221095
    Signed-off-by: Vijay Bellur <vbellur>
    Reviewed-on: http://review.gluster.org/10765
    Reviewed-by: Niels de Vos <ndevos>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Tested-by: Gluster Build System <jenkins.com>

Comment 4 Nagaprasad Sathyanarayana 2015-10-25 14:42:43 UTC
Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

Comment 5 Nagaprasad Sathyanarayana 2015-10-25 14:53:40 UTC
Fix for this bug is already made in a GlusterFS release. The cloned BZ has details of the fix and the release. Hence closing this mainline BZ.

Comment 6 Niels de Vos 2016-06-16 13:00:40 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.