Bug 1221189 - Add warning when adding external FCP lun to VM although it is part of existing storage domain
Summary: Add warning when adding external FCP lun to VM although it is part of existin...
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: General
Version: ---
Hardware: Unspecified
OS: Unspecified
Target Milestone: ovirt-4.0.0-alpha
: 4.0.0
Assignee: Idan Shaby
QA Contact: Elad
Depends On:
TreeView+ depends on / blocked
Reported: 2015-05-13 13:05 UTC by Aharon Canan
Modified: 2016-07-05 07:57 UTC (History)
14 users (show)

Fixed In Version: ovirt 4.0.0 alpha1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2016-07-05 07:57:31 UTC
oVirt Team: Storage
rule-engine: ovirt-4.0.0+
rule-engine: planning_ack+
tnisan: devel_ack+
acanan: testing_ack+

Attachments (Terms of Use)

System ID Private Priority Status Summary Last Updated
oVirt gerrit 51721 0 master MERGED frontend: add missing warning label to FcpStorageView 2020-11-17 15:45:57 UTC

Description Aharon Canan 2015-05-13 13:05:42 UTC
Description of problem:
When adding external lun to a VM I can choose luns that are part of an existing storage domain.
My storage domain build on top of 2 FC luns, while getting the luns list to add as external to a VM, both can be selected.

Very problematic as it can lead to Data corruption

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. Create storage domain based on 2 FC luns
2. Create VM with a virtual disk
3. add external lun to this VM

Actual results:
In the list of luns to add, we can choose the storage domain luns as well

Expected results:
both luns should be greyed out.

Additional info:
appear in our rhevm-3 setup, Can share access for analysis if needed.

Comment 1 Allon Mureinik 2015-05-13 14:59:50 UTC
The ability itself is by design - it's the basis for CFME's fleecing capabilities.

I agree it's ugly that this is also exposed in the GUI, but there's nothing urgent about it. 
Reducing severity and removing z-stream flag.

Not sure if changing the GUI is the right call though - there is merit in keeping GUI and REST aligned.
Leaving this up to PM to decide.

Comment 2 Tal Nisan 2015-05-25 12:59:21 UTC
Scott/Yaniv, your thoughts?

Comment 3 Yaniv Lavi 2015-05-28 09:32:33 UTC
(In reply to Tal Nisan from comment #2)
> Scott/Yaniv, your thoughts?

We will not block a ability that is needed for cloudforms. We can add a warning on doing this to make sure users really want to do things that might lead to corruption.

Comment 4 Sandro Bonazzola 2015-10-26 12:45:20 UTC
this is an automated message. oVirt 3.6.0 RC3 has been released and GA is targeted to next week, Nov 4th 2015.
Please review this bug and if not a blocker, please postpone to a later release.
All bugs not postponed on GA release will be automatically re-targeted to

- 3.6.1 if severity >= high
- 4.0 if severity < high

Comment 5 Red Hat Bugzilla Rules Engine 2015-11-30 19:10:31 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 6 Elad 2016-04-19 07:55:22 UTC
A warning message is presented when adding a FC direct LUN which is already part of a FC storage domain that exists in the system.

This operation might be unrecoverable and destructive!
The following LUNs are already part of Storage Domains:
- 3514f0c5a51600021 (LUN is already part of Storage Domain: fc1)

Verified using:

Comment 7 Sandro Bonazzola 2016-07-05 07:57:31 UTC
oVirt 4.0.0 has been released, closing current release.

Note You need to log in before you can comment on or make changes to this bug.