Spec URL: http://goldmann.fedorapeople.org/package_review/python-docker-scripts/1/python-docker-scripts.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/python-docker-scripts/1/python-docker-scripts-0.3.4-1.fc22.src.rpm Fedora Account System Username: goldmann Description: A swiss-knife tool that could be useful for people working with Docker. This is a collection of scripts to deal with Docker images and not only. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9723444
Updated to 0.3.6. Spec URL: http://goldmann.fedorapeople.org/package_review/python-docker-scripts/2/python-docker-scripts.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/python-docker-scripts/2/python-docker-scripts-0.3.6-1.fc22.src.rpm Koji scratch build (Rawhide): http://koji.fedoraproject.org/koji/taskinfo?taskID=9733333 Koji scratch build (EPEL7): http://koji.fedoraproject.org/koji/taskinfo?taskID=9733342
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package installs properly. Note: No installation test done (mock unavailable) [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python2.7/site- packages/docker_scripts, /usr/lib/python3.4/site- packages/docker_scripts [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python2.7/site- packages/docker_scripts, /usr/lib/python3.4/site- packages/docker_scripts [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: Using prebuilt rpms. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package does not contain duplicates in %files. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3 -docker-scripts [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-docker-scripts-0.3.6-1.fc23.noarch.rpm python3-docker-scripts-0.3.6-1.fc23.noarch.rpm python-docker-scripts-0.3.6-1.fc23.src.rpm python-docker-scripts.noarch: W: spelling-error %description -l en_US swiss -> swiz, Swiss, swigs python-docker-scripts.noarch: W: no-manual-page-for-binary docker-scripts python3-docker-scripts.noarch: W: spelling-error %description -l en_US swiss -> swiz, Swiss, swigs python3-docker-scripts.noarch: W: no-manual-page-for-binary docker-scripts3 python-docker-scripts.src: W: spelling-error %description -l en_US swiss -> swiz, Swiss, swigs 3 packages and 0 specfiles checked; 0 errors, 5 warnings. Requires -------- python3-docker-scripts (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3-docker-py python3-setuptools python3-six python-docker-scripts (rpmlib, GLIBC filtered): /usr/bin/python python(abi) python-docker-py python-setuptools python-six Provides -------- python3-docker-scripts: python3-docker-scripts python-docker-scripts: python-docker-scripts Source checksums ---------------- https://github.com/goldmann/docker-scripts/archive/0.3.6.tar.gz : CHECKSUM(SHA256) this package : ba97e569526f615c79f2ffd897390624d14e53a4caa1feb85b99436573cd1c89 CHECKSUM(SHA256) upstream package : ba97e569526f615c79f2ffd897390624d14e53a4caa1feb85b99436573cd1c89 # Notes Please correct this: ``` $ rpm -qf /usr/lib/python2.7/site-packages/docker_scripts/ file /usr/lib/python2.7/site-packages/docker_scripts is not owned by any package ``` manpage would be also nice (not required) Otherwise LGTM.
Thanks for the review! Spec URL: http://goldmann.fedorapeople.org/package_review/python-docker-scripts/3/python-docker-scripts.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/python-docker-scripts/3/python-docker-scripts-0.3.7-1.fc22.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9749133 Changes: - Upstream release 0.3.7 - Make sure the /usr/lib/python2.7/site-packages/docker_scripts is owned by this package Man page will be probably added later.
Thank you! New Package SCM Request ======================= Package Name: python-docker-scripts Short Description: Collection of scripts to help manage Docker Upstream URL: https://github.com/goldmann/docker-scripts Owners: goldmann Branches: f21 f22 epel7
Git done (by process-git-requests).
Thanks, built for Rawhide.