Spec URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-normalize-git-url/nodejs-normalize-git-url.spec SRPM URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-normalize-git-url/nodejs-normalize-git-url-1.0.0-1.fc21.src.rpm Description: Normalizes Git URLs. For npm, but you can use it too. Fedora Account System Username: zvetlik
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Issues ===== [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [!]: Buildroot is not present Note: Invalid buildroot found: %{_tmppath}/%{pkg_name}-%{version}-%{release}-root-%(%{__id_u} -n) See: http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Rpmlint is run on all installed packages. nodejs-normalize-git-url.noarch: W: summary-ended-with-dot C Normalizes Git URLs. For npm, but you can use it too. nodejs-normalize-git-url.src: W: summary-ended-with-dot C Normalizes Git URLs. For npm, but you can use it too. nodejs-normalize-git-url.src: W: strange-permission normalize-git-url-1.0.0.tgz 0755L nodejs-normalize-git-url.src:60: W: macro-in-comment %license nodejs-normalize-git-url.src:18: W: mixed-use-of-spaces-and-tabs (spaces: line 8, tab: line 18) ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 2 files have unknown license. Detailed output of licensecheck in /home/tom/1221293-nodejs-normalize-git- url/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [!]: Buildroot is not present Note: Invalid buildroot found: %{_tmppath}/%{pkg_name}-%{version}-%{release}-root-%(%{__id_u} -n) See: http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: nodejs-normalize-git-url-1.0.0-1.fc23.noarch.rpm nodejs-normalize-git-url-1.0.0-1.fc23.src.rpm nodejs-normalize-git-url.noarch: W: spelling-error Summary(en_US) npm -> pm, rpm, ppm nodejs-normalize-git-url.noarch: W: summary-ended-with-dot C Normalizes Git URLs. For npm, but you can use it too. nodejs-normalize-git-url.noarch: W: spelling-error %description -l en_US npm -> pm, rpm, ppm nodejs-normalize-git-url.noarch: W: only-non-binary-in-usr-lib nodejs-normalize-git-url.src: W: spelling-error Summary(en_US) npm -> pm, rpm, ppm nodejs-normalize-git-url.src: W: summary-ended-with-dot C Normalizes Git URLs. For npm, but you can use it too. nodejs-normalize-git-url.src: W: spelling-error %description -l en_US npm -> pm, rpm, ppm nodejs-normalize-git-url.src: W: strange-permission normalize-git-url-1.0.0.tgz 0755L nodejs-normalize-git-url.src:60: W: macro-in-comment %license nodejs-normalize-git-url.src:18: W: mixed-use-of-spaces-and-tabs (spaces: line 8, tab: line 18) 2 packages and 0 specfiles checked; 0 errors, 10 warnings. Rpmlint (installed packages) ---------------------------- nodejs-normalize-git-url.noarch: W: spelling-error Summary(en_US) npm -> pm, rpm, ppm nodejs-normalize-git-url.noarch: W: summary-ended-with-dot C Normalizes Git URLs. For npm, but you can use it too. nodejs-normalize-git-url.noarch: W: spelling-error %description -l en_US npm -> pm, rpm, ppm nodejs-normalize-git-url.noarch: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 4 warnings. Requires -------- nodejs-normalize-git-url (rpmlib, GLIBC filtered): nodejs(engine) Provides -------- nodejs-normalize-git-url: nodejs-normalize-git-url npm(normalize-git-url) Source checksums ---------------- http://registry.npmjs.org/normalize-git-url/-/normalize-git-url-1.0.0.tgz : CHECKSUM(SHA256) this package : c4a050c30bf1e5e6530ebb5e792d6e9a43f107170df4fbd31ceec77048f76e61 CHECKSUM(SHA256) upstream package : c4a050c30bf1e5e6530ebb5e792d6e9a43f107170df4fbd31ceec77048f76e61 Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04 Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 1221293 Buildroot used: compton-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Note that as this is an ISC license you will need to add it locally until upstream does.
Rebuilt with new release. Spec URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-normalize-git-url/nodejs-normalize-git-url.spec SRPM URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-normalize-git-url/nodejs-normalize-git-url-1.0.1-1.fc21.src.rpm
Email addresses need adding to the spec changelog, but if you do that then this will be good so I'll approve it now.
New Package SCM Request ======================= Package Name: nodejs-normalize-git-url Short Description: Normalizes Git URLs. For npm, but you can use it too. Upstream URL: https://github.com/npm/normalize-git-url Owners: zvetlik Branches: f20 f21 f22 el6 epel7
Git done (by process-git-requests).
nodejs-normalize-git-url-1.0.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-normalize-git-url-1.0.1-1.fc20
nodejs-normalize-git-url-1.0.1-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-normalize-git-url-1.0.1-1.fc21
nodejs-normalize-git-url-1.0.1-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/nodejs-normalize-git-url-1.0.1-1.fc22
nodejs-normalize-git-url-1.0.1-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-normalize-git-url-1.0.1-1.el7
nodejs-normalize-git-url-1.0.1-1.el7 has been pushed to the Fedora EPEL 7 testing repository.
nodejs-normalize-git-url-1.0.1-1.fc22 has been pushed to the Fedora 22 stable repository.
nodejs-normalize-git-url-1.0.1-1.fc20 has been pushed to the Fedora 20 stable repository.
nodejs-normalize-git-url-1.0.1-1.fc21 has been pushed to the Fedora 21 stable repository.
nodejs-normalize-git-url-1.0.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository.