Description of problem: `rlRun ""` => PASS although I believe it should fail to warn user about potential error. This can happen when you feed rlRun with some variable which is mistakenly left blank. It might make debugging bit harder. Version-Release number of selected component (if applicable): beakerlib-1.10-2.el5 How reproducible: always Steps to Reproduce: # . /usr/bin/rhts-environment.sh # . /usr/lib/beakerlib/beakerlib.sh # rlJournalStart # rlPhaseStartTest "Test rlRun" [...] # rlRun "" :: [ BEGIN ] :: Running '' :: [ PASS ] :: Command '' (Expected 0, got 0) Actual results: PASS Expected results: FAIL Additional info: This happened to me when I did `rlRun "$( ... )"` and '...' did not produced expected output. Also I do not see valid use-case for intentionally running `rlRun ""` besides some testing so maybe this can be doable.
Personally I do not see this very useful. Moreover other people may want to make it pass if the command is empty. -1 Let see what others thinks of it.
I'm not sure about the merit itself. However, if we decide to catch the empty input for rlRun, I'd suggest to make the check optional for the sake of keeping backwards compatibility.
I see ""=>PASS as a special case of "wrong input" => "actual result". This falls into the same category (not a duplicate though) as BZ#1206272 - [RFE] Add syntax check inside rlRun Both deal with the weird design feature that invalid input generates valid and misleading results instead of producing an error. +1 by me.
(In reply to Ales Zelinka from comment #3) > Both deal with the weird design feature that invalid input generates valid > and misleading results instead of producing an error. We need to agree on what is valid and what is invalid. From bash point of view the empty code is valid.
I'm still not sure if we can/should change behavior, rlRun is implemented by by eval and there is possibility there are users using is like eval. Generally it could be same solution like BZ#1206272 but I'm afraid to change current behavior.
(In reply to Dalibor Pospíšil from comment #4) > We need to agree on what is valid and what is invalid. Agreed. Lets ask the actual users/customers. /me writes to beaker-user-list.
(In reply to Jakub Prokes from comment #5) > I'm still not sure if we can/should change behavior, rlRun is implemented by > by eval and there is possibility there are users using is like eval. If people are relying on implementation rather than the contract (documentation), they are doint it wrong. I'm generally in favor of sanity checking input. I've seen too many "working" (=PASSing) tests which were broken and really not testing anything.
This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle. Changing version to '23'. (As we did not run this process for some time, it could affect also pre-Fedora 23 development cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.) More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23
fixed by https://git.fedorahosted.org/cgit/beakerlib.git/commit/?h=devel&id=b66563a3e4dd111a15da325adcb4ae129f055cb8
beakerlib-1.11-1.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-f36ff57e84
beakerlib-1.11-1.fc21 has been pushed to the Fedora 21 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update beakerlib' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-4c96e73472
beakerlib-1.11-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update beakerlib' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-ba802d1bd6
beakerlib-1.11-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update beakerlib' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-7ab9feeb42
beakerlib-1.11-1.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'yum --enablerepo=epel-testing update beakerlib' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-0e03df1475
beakerlib-1.11-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'yum --enablerepo=epel-testing update beakerlib' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8f65d5290a
beakerlib-1.11-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'yum --enablerepo=epel-testing update beakerlib' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-f36ff57e84
beakerlib-1.11-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
beakerlib-1.11-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
beakerlib-1.11-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.
beakerlib-1.11-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.
beakerlib-1.11-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
beakerlib-1.11-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.