Spec URL: https://msrb.fedorapeople.org/jruby-maven-plugins.spec SRPM URL: https://msrb.fedorapeople.org/jruby-maven-plugins-1.0.10-1.fc23.src.rpm Description: This package contains set of utilities to handle RubyGems in a Maven way. It also includes support for rspec, rails, cucumber, rake, etc. Fedora Account System Username: msrb
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find license.txt in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text IGNORE ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 284 files have unknown license. Detailed output of licensecheck in /home/gil/1221469-jruby-maven-plugins/review-jruby- maven-plugins/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/licenses, /usr/share/maven-metadata [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/licenses, /usr/share /maven-metadata [?]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: Using prebuilt rpms. jruby-openssl:0.8.2 see ./ruby-tools/src/main/java/de/saumya/mojo/ruby/gems/GemsInstaller.java https://github.com/jruby/jruby-openssl [?]: Package contains no bundled libraries without FPC exception. ./ruby-tools/src/main/resources/rails-templates/datamapper/application.rb ./ruby-tools/src/main/resources/rails-templates/datamapper/config.rb ./ruby-tools/src/main/resources/rails-templates/datamapper/database.yml.rb ./ruby-tools/src/main/resources/rails-templates/datamapper/gemfile.rb https://github.com/datamapper [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=9732924 [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in jruby- maven-plugins-javadoc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: jruby-maven-plugins-1.0.10-1.fc23.noarch.rpm jruby-maven-plugins-javadoc-1.0.10-1.fc23.noarch.rpm jruby-maven-plugins-1.0.10-1.fc23.src.rpm jruby-maven-plugins.noarch: W: spelling-error %description -l en_US rspec -> spec, r spec jruby-maven-plugins.noarch: W: no-documentation jruby-maven-plugins.src: W: spelling-error %description -l en_US rspec -> spec, r spec 3 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- jruby-maven-plugins (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(org.apache.ant:ant) mvn(org.apache.maven:maven-artifact) mvn(org.apache.maven:maven-core) mvn(org.apache.maven:maven-model) mvn(org.apache.maven:maven-plugin-api) mvn(org.codehaus.plexus:plexus-archiver) mvn(org.codehaus.plexus:plexus-classworlds) mvn(org.codehaus.plexus:plexus-component-annotations) mvn(org.codehaus.plexus:plexus-utils) mvn(org.codehaus.plexus:plexus-velocity) mvn(org.jruby:jruby-core) mvn(org.sonatype.plexus:plexus-build-api) mvn(org.yaml:snakeyaml) jruby-maven-plugins-javadoc (rpmlib, GLIBC filtered): jpackage-utils Provides -------- jruby-maven-plugins: jruby-maven-plugins mvn(de.saumya.mojo:bundler-maven-plugin) mvn(de.saumya.mojo:bundler-maven-plugin:pom:) mvn(de.saumya.mojo:cucumber-maven-plugin) mvn(de.saumya.mojo:cucumber-maven-plugin:pom:) mvn(de.saumya.mojo:gem-assembly-descriptors) mvn(de.saumya.mojo:gem-assembly-descriptors:pom:) mvn(de.saumya.mojo:gem-extension) mvn(de.saumya.mojo:gem-extension:pom:) mvn(de.saumya.mojo:gem-maven-plugin) mvn(de.saumya.mojo:gem-maven-plugin:pom:) mvn(de.saumya.mojo:gem-parent-mojo:pom:) mvn(de.saumya.mojo:gem-with-jar-extension) mvn(de.saumya.mojo:gem-with-jar-extension:pom:) mvn(de.saumya.mojo:jruby-maven-plugin) mvn(de.saumya.mojo:jruby-maven-plugin:pom:) mvn(de.saumya.mojo:jruby-maven-plugins:pom:) mvn(de.saumya.mojo:minitest-maven-plugin) mvn(de.saumya.mojo:minitest-maven-plugin:pom:) mvn(de.saumya.mojo:parent-mojo:pom:) mvn(de.saumya.mojo:rails3-maven-plugin) mvn(de.saumya.mojo:rails3-maven-plugin:pom:) mvn(de.saumya.mojo:rake-maven-plugin) mvn(de.saumya.mojo:rake-maven-plugin:pom:) mvn(de.saumya.mojo:rspec-maven-plugin) mvn(de.saumya.mojo:rspec-maven-plugin:pom:) mvn(de.saumya.mojo:ruby-tools) mvn(de.saumya.mojo:ruby-tools:pom:) mvn(de.saumya.mojo:runit-maven-plugin) mvn(de.saumya.mojo:runit-maven-plugin:pom:) mvn(de.saumya.mojo:tests-parent-mojo:pom:) jruby-maven-plugins-javadoc: jruby-maven-plugins-javadoc Source checksums ---------------- https://github.com/torquebox/jruby-maven-plugins/archive/jruby-maven-plugins-1.0.10.tar.gz : CHECKSUM(SHA256) this package : 2f1d9cffbe9c13e32ed303e0a4a2e8b05d9c22560483f38b49040658a63d946b CHECKSUM(SHA256) upstream package : 2f1d9cffbe9c13e32ed303e0a4a2e8b05d9c22560483f38b49040658a63d946b Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -vpn jruby-maven-plugins -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
NON blocking issues
forgotten: ./History.txt ./README.md .TODO can you manage the above txt file with %%doc macro? suppress this warning jruby-maven-plugins.noarch: W: no-documentation
(In reply to gil cattaneo from comment #1) > [?]: All build dependencies are listed in BuildRequires, except for any that > are listed in the exceptions section of Packaging Guidelines. > Note: Using prebuilt rpms. > jruby-openssl:0.8.2 see > ./ruby-tools/src/main/java/de/saumya/mojo/ruby/gems/GemsInstaller.java > https://github.com/jruby/jruby-openssl This fine should by fine IMO. > [?]: Package contains no bundled libraries without FPC exception. > ./ruby-tools/src/main/resources/rails-templates/datamapper/application.rb > ./ruby-tools/src/main/resources/rails-templates/datamapper/config.rb > ./ruby-tools/src/main/resources/rails-templates/datamapper/database.yml.rb > ./ruby-tools/src/main/resources/rails-templates/datamapper/gemfile.rb > https://github.com/datamapper > Good catch. I missed those. I will check whether those are needed for now. If not, I will remove them.
(In reply to gil cattaneo from comment #3) > forgotten: > ./History.txt > ./README.md > .TODO > can you manage the above txt file with %%doc macro? > suppress this warning jruby-maven-plugins.noarch: W: no-documentation Will do, probably without TODO file - it shouldn't be needed.
Fixed spec+srpm: Spec URL: https://msrb.fedorapeople.org/review/2/jruby-maven-plugins.spec SRPM URL: https://msrb.fedorapeople.org/review/2/jruby-maven-plugins-1.0.10-2.fc23.src.rpm I removed bundled files and disabled rails3-maven-plugin. I don't expect it to be needed anytime soon in Fedora.
Thanks for the review! New Package SCM Request ======================= Package Name: jruby-maven-plugins Short Description: JRuby Maven plugins Upstream URL: https://github.com/torquebox/jruby-maven-plugins Owners: msrb mizdebsk msimacek Branches: f22 InitialCC: java-sig
Git done (by process-git-requests).
Thanks for the review and the repo. The package is now in Rawhide.