Bug 1221716 - Log depot URI is escaped wrong
Summary: Log depot URI is escaped wrong
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.4.0
Hardware: Unspecified
OS: Unspecified
high
urgent
Target Milestone: GA
: 5.4.0
Assignee: Aparna Karve
QA Contact: Milan Falešník
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-05-14 16:04 UTC by Milan Falešník
Modified: 2015-06-16 13:02 UTC (History)
6 users (show)

Fixed In Version: 5.4.0.2
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-06-16 13:02:29 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2015:1100 0 normal SHIPPED_LIVE CFME 5.4.0 bug fixes, and enhancement update 2015-06-16 16:28:42 UTC

Description Milan Falešník 2015-05-14 16:04:08 UTC
Description of problem:
Cannot specify an URI with special character (/, ...), it gets improperly escaped

Version-Release number of selected component (if applicable):
5.4.0.1

How reproducible:
always

Steps to Reproduce:
1. Go to Configure / Configuration / Diagnostics / Server / Collect logs
2. Click Edit
3. Select a log depot type that has an URI
4. Specify an URI that has eg. / in it (let's say "foo.bar/baz"
5. Save

Actual results:
Summary screen and edit screen show foo.bar%2Fbaz, which disables log collection

Expected results:
Proper URI displayed in the summary and subsequent edits

Additional info:
Probably introduced with angularization.

Comment 2 CFME Bot 2015-05-14 21:07:36 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/91d65424c00f791ad64b4c8d684a9fcb8233b88d

commit 91d65424c00f791ad64b4c8d684a9fcb8233b88d
Author:     Aparna Karve <akarve>
AuthorDate: Thu May 14 11:18:59 2015 -0700
Commit:     Aparna Karve <akarve>
CommitDate: Thu May 14 11:18:59 2015 -0700

    Used decodeURIComponent to escape URL params
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1221716

 .../javascripts/controllers/ops/log_collection_form_controller.js       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 3 CFME Bot 2015-05-15 14:05:26 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=d1888a6356cf11345e9d4c1751f8720c89b79ec2

commit d1888a6356cf11345e9d4c1751f8720c89b79ec2
Author:     Aparna Karve <akarve>
AuthorDate: Thu May 14 11:18:59 2015 -0700
Commit:     Aparna Karve <akarve>
CommitDate: Thu May 14 16:41:33 2015 -0700

    Used decodeURIComponent to escape URL params
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1221716
    
    clean cherry-pick (commit -91d65424c00f791ad64b4c8d684a9fcb8233b88d)
    
    PR -  https://github.com/ManageIQ/manageiq/pull/2924

 .../javascripts/controllers/ops/log_collection_form_controller.js       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 4 CFME Bot 2015-05-15 14:05:33 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=37cede9dedfb52b135b0534bf0ea1b5487afc520

commit 37cede9dedfb52b135b0534bf0ea1b5487afc520
Merge: 0e05250 d1888a6
Author:     Dan Clarizio <dclarizi>
AuthorDate: Fri May 15 10:03:10 2015 -0400
Commit:     Dan Clarizio <dclarizi>
CommitDate: Fri May 15 10:03:10 2015 -0400

    Merge branch '5.4.z' into '5.4.z'
    
    Used decodeURIComponent to escape URL params
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1221716
    
    clean cherry-pick (commit - 91d65424c00f791ad64b4c8d684a9fcb8233b88d)
    
    PR -  https://github.com/ManageIQ/manageiq/pull/2924
    
    See merge request !64

 .../javascripts/controllers/ops/log_collection_form_controller.js       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 6 Milan Falešník 2015-05-21 11:47:11 UTC
Verified in 5.4.0.2

Comment 8 errata-xmlrpc 2015-06-16 13:02:29 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1100.html


Note You need to log in before you can comment on or make changes to this bug.