Created attachment 1025616 [details] saved setting summary Description of problem: OPS/Diagnostics Server, Collect Logs edit form does not populate saved log depot settings Version-Release number of selected component (if applicable): How reproducible: 100% Steps to Reproduce: 1. Go To Configure/Configuration/Diagnostics/Server 2. Go to Collect Logs tab 3. Add log depot settings, for example Depot name: test, URI: nfs://foo.bar/bar 4. Press save. IT shows correct data on summary screen, now press Edit Log Depot settings button again, it doesn't populate edit form with previously saved values. 5 Noticed error in log, maybe that's preventing log depot edit form settings from loading [----] F, [2015-05-14T17:47:54.853783 #5043:6fde98] FATAL -- : Error caught: [NameError] uninitialized constant OpsController::Diagnostics::FileDepotFtpAnonymousRedhatDropbox /home/hkataria/dev/manageiq/vmdb/lib/extensions/as_const_missing_with_sti.rb:43:in `const_missing_with_sti' /home/hkataria/dev/manageiq/vmdb/app/controllers/ops_controller/diagnostics.rb:394:in `build_rh_dropbox_json' /home/hkataria/dev/manageiq/vmdb/app/controllers/ops_controller/diagnostics.rb:359:in `log_collection_form_fields' Actual results: Blank form Expected results: Should populate previously saved log depot settings. Additional info:
https://github.com/ManageIQ/manageiq/pull/5286
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/e4327e65d53ad28a598062f636a17f31b4de8cee commit e4327e65d53ad28a598062f636a17f31b4de8cee Author: Aparna Karve <akarve> AuthorDate: Mon Nov 2 09:55:00 2015 -0800 Commit: Aparna Karve <akarve> CommitDate: Wed Nov 4 14:36:57 2015 -0800 Avoid making specific references to productization models (like FileDepotFtpAnonymousRedhatDropbox) https://bugzilla.redhat.com/show_bug.cgi?id=1221821 .../ops/log_collection_form_controller.js | 25 +++++++++++++++------- .../javascripts/services/miq_db_backup_service.js | 24 +++++---------------- app/controllers/ops_controller/diagnostics.rb | 17 +++++++-------- app/views/ops/_log_collection.html.haml | 17 +++++++++------ config/routes.rb | 1 + spec/routing/ops_routing_spec.rb | 1 + 6 files changed, 43 insertions(+), 42 deletions(-)
New commit detected on cfme/5.5.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=3e5d4a8f6054bf26aa2d7e8db18635a9568832e6 commit 3e5d4a8f6054bf26aa2d7e8db18635a9568832e6 Author: Aparna Karve <akarve> AuthorDate: Mon Nov 2 09:55:00 2015 -0800 Commit: Aparna Karve <akarve> CommitDate: Thu Nov 5 15:09:13 2015 -0800 Avoid making specific references to productization models (like FileDepotFtpAnonymousRedhatDropbox) https://bugzilla.redhat.com/show_bug.cgi?id=1221821 .../ops/log_collection_form_controller.js | 25 +++++++++++++++------- .../javascripts/services/miq_db_backup_service.js | 24 +++++---------------- app/controllers/ops_controller/diagnostics.rb | 17 +++++++-------- app/views/ops/_log_collection.html.haml | 17 +++++++++------ config/routes.rb | 1 + spec/routing/ops_routing_spec.rb | 1 + 6 files changed, 43 insertions(+), 42 deletions(-)
New commit detected on cfme/5.5.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=b95a10f6be64d725d4ad5cda9e4764050034cbae commit b95a10f6be64d725d4ad5cda9e4764050034cbae Merge: a1ec8ba 63d3b10 Author: Dan Clarizio <dclarizi> AuthorDate: Fri Nov 6 11:25:53 2015 -0500 Commit: Dan Clarizio <dclarizi> CommitDate: Fri Nov 6 11:25:53 2015 -0500 Merge branch 'bz1221821_fix_log_collection_form' into '5.5.z' Bz1221821 fix log collection form Clean cherry-pick. Upstream PR - https://github.com/ManageIQ/manageiq/pull/5286 1. Make the controller code agnostic to productization models like ```FileDepotFtpAnonymousRedhatDropbox``` https://bugzilla.redhat.com/show_bug.cgi?id=1221821 2. Added Password field changes See merge request !377 .../credentials/credentials_controller.js | 9 ++++ .../ops/log_collection_form_controller.js | 42 +++++++++++---- app/assets/javascripts/directives/autofocus.js | 14 ++++- .../javascripts/services/miq_db_backup_service.js | 24 ++------- app/controllers/ops_controller/diagnostics.rb | 39 ++++++++------ ..._log_depot_settings_angular_bootstrap.html.haml | 22 ++++---- app/views/ops/_log_collection.html.haml | 21 +++++--- config/routes.rb | 1 + .../controllers/ops_controller/diagnostics_spec.rb | 60 +++++++++++++++++++++- .../ops/log_collection_form_controller_spec.js | 36 +++++++++++-- .../services/miq_db_backup_service_spec.js | 21 -------- spec/routing/ops_routing_spec.rb | 1 + 12 files changed, 198 insertions(+), 92 deletions(-)
Verified against 5.5.0.11. When modifying Log Depot Settings for Server, form is populated with previously saved values, so it is working as expected. No errrors in CFME logs: [root@10-16-7-187 vmdb]# tail -f log/*.log | grep nfs [----] I, [2015-11-23T11:52:47.583871 #2926:c2798c] INFO -- : Started POST "/ops/log_depot_edit/1?button=save&depot_name=test&uri=nfs://foo.bar/bar&uri_prefix=nfs&log_protocol=NFS&log_password=[FILTERED]&log_verify=[FILTERED]" for 127.0.0.1 at 2015-11-23 11:52:47 -0500 [----] I, [2015-11-23T11:52:47.590815 #2926:c2798c] INFO -- : Parameters: {"button"=>"save", "depot_name"=>"test", "uri"=>"nfs://foo.bar/bar", "uri_prefix"=>"nfs", "log_protocol"=>"NFS", "log_password"=>"[FILTERED]", "log_verify"=>"[FILTERED]", "id"=>"1"} 25993 25144 root 20 0 112652 980 844 S 0.0 0.0 0:00.00 grep --color=auto nfs [----] I, [2015-11-23T11:53:25.612266 #2926:c2798c] INFO -- : Started POST "/ops/log_depot_edit/1?button=save&depot_name=test&uri=foo.bar/bar&uri_prefix=nfs&log_protocol=NFS&log_password=[FILTERED]&log_verify=[FILTERED]" for 127.0.0.1 at 2015-11-23 11:53:25 -0500 [----] I, [2015-11-23T11:53:25.615359 #2926:c2798c] INFO -- : Parameters: {"button"=>"save", "depot_name"=>"test", "uri"=>"foo.bar/bar", "uri_prefix"=>"nfs", "log_protocol"=>"NFS", "log_password"=>"[FILTERED]", "log_verify"=>"[FILTERED]", "id"=>"1"} [----] I, [2015-11-23T11:53:37.497653 #2926:c2798c] INFO -- : Started POST "/ops/log_depot_edit/1?button=save&depot_name=test&uri=foo.bar/bar1&uri_prefix=nfs&log_protocol=NFS&log_password=[FILTERED]&log_verify=[FILTERED]" for 127.0.0.1 at 2015-11-23 11:53:37 -0500 [----] I, [2015-11-23T11:53:37.500077 #2926:c2798c] INFO -- : Parameters: {"button"=>"save", "depot_name"=>"test", "uri"=>"foo.bar/bar1", "uri_prefix"=>"nfs", "log_protocol"=>"NFS", "log_password"=>"[FILTERED]", "log_verify"=>"[FILTERED]", "id"=>"1"}
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2015:2551