Spec URL: https://raw.githubusercontent.com/siwinski/rpms/5f2e3330a1e798538fd2095d82ce28ad6f1dcbe2/php-pimple1/php-pimple1.spec SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-pimple1-1.1.1-1.fc21.src.rpm Description: Pimple is a small dependency injection container for PHP that consists of just one file and one class. Fedora Account System Username: siwinski ----- php-Pimple package was updated to version 3 but version 1 is still required.
Add missing %{_bindir}/phpab build dependency Spec URL: https://raw.githubusercontent.com/siwinski/rpms/273dabcdc286f396074ec99d747b897e9972b1cd/php-pimple1/php-pimple1.spec SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-pimple1-1.1.1-2.fc21.src.rpm
Created attachment 1027200 [details] phpci.log phpCompatInfo version 4.2.0 DB built May 19 2015 11:12:39 CEST static analyze results
Created attachment 1027203 [details] review.txt Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
[!]: If the package is a rename of another package, proper Obsoletes and Provides are present. You cannot obsolete yourself (see rpmlint warning) I think it is safe to drop the provide (php-Pimple still exists) and package using it, should use composer require. [!]: Package does not generate any conflict. As this package is not PSR-0 compliant, perhaps you can use another top dir (ex /usr/share/php/Pimple1) and thus avoid the conflicts with new version ? I can't test what happens when php-pimple1 and php-Pimple 3 are in the repo. Will the package be update, or replace ?
(In reply to Remi Collet from comment #4) > [!]: If the package is a rename of another package, proper Obsoletes and > Provides are present. > You cannot obsolete yourself (see rpmlint warning) > I think it is safe to drop the provide (php-Pimple still exists) > and package using it, should use composer require. > > [!]: Package does not generate any conflict. > As this package is not PSR-0 compliant, perhaps you can > use another top dir (ex /usr/share/php/Pimple1) and thus > avoid the conflicts with new version ? I was against this when I first read it, but the more I thought about it the more I liked it. Implemented. Diff = https://github.com/siwinski/rpms/commit/2bff02a18a7c12c39c8be74973266f4451ca19f1 > I can't test what happens when php-pimple1 and php-Pimple 3 are in the repo. > Will the package be update, or replace ? adamwill updated php-Pimple for owncloud -- https://admin.fedoraproject.org/updates/search/php-Pimple-3.0.0 Note that for the long-run I still want to move ahead with bug 1131731 so the extension is available as well. I will update that review request soon. Spec URL: https://raw.githubusercontent.com/siwinski/rpms/2bff02a18a7c12c39c8be74973266f4451ca19f1/php-pimple1/php-pimple1.spec SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-pimple1-1.1.1-3.fc21.src.rpm
[-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package does not generate any conflict. All blockers fixed. == APPROVED ==
THANKS for the review! New Package SCM Request ======================= Package Name: php-pimple1 Short Description: A simple dependency injection container for PHP Upstream URL: https://github.com/silexphp/Pimple/tree/1.1 Owners: siwinski Branches: f21 f22 el6 epel7 InitialCC:
Git done (by process-git-requests).
php-pimple1-1.1.1-4.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/php-pimple1-1.1.1-4.fc22
php-pimple1-1.1.1-4.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/php-pimple1-1.1.1-4.fc21
php-pimple1-1.1.1-4.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/php-pimple1-1.1.1-4.el7
php-pimple1-1.1.1-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-pimple1-1.1.1-4.el6
php-pimple1-1.1.1-4.fc22 has been pushed to the Fedora 22 stable repository.
php-pimple1-1.1.1-4.fc21 has been pushed to the Fedora 21 stable repository.
php-pimple1-1.1.1-4.el7 has been pushed to the Fedora EPEL 7 stable repository.
php-pimple1-1.1.1-4.el6 has been pushed to the Fedora EPEL 6 stable repository.