1222724 – [RFE] Please add auto approval function and auto mail function to VM's reconfigure operation

Bug 1222724 - [RFE] Please add auto approval function and auto mail function to VM's reconfigure operation

Summary: [RFE] Please add auto approval function and auto mail function to VM's reconf...

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Red Hat CloudForms Management Engine
Classification:	Red Hat
Component:	Automate
Sub Component:
Version:	5.3.0
Hardware:	Unspecified
OS:	Unspecified
Priority:	high
Severity:	high
Target Milestone:	GA
Target Release:	5.6.0
Assignee:	William Fitzgerald
QA Contact:	Niyaz Akhtar Ansari
Docs Contact:
URL:
Whiteboard:	vm:reconfigure
Depends On:
Blocks:
TreeView+	depends on / blocked

Reported:	2015-05-19 00:26 UTC by Yoshinori Takahashi
Modified:	2016-06-29 14:55 UTC (History)
CC List:	10 users (show)
Fixed In Version:	5.6.0.1
Doc Type:	Enhancement
Doc Text:	There was a feature request to add auto approval and auto mail function to virtual machine's reconfigure operation, similar to auto approval for provisioning. Previously, when selecting reconfigure, the request would need to be approved and would wait for someone to approve it. Also, there was no email to confirm that the virtual machine was reconfigured. With this fix, the VM will be auto approved and an email will be sent that your VM was reconfigured (if email is configured in your server).
Clone Of:
Environment:
Last Closed:	2016-06-29 14:55:40 UTC
Category:	---
Cloudforms Team:	---
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)

Links
System	ID	Private	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2016:1348	0	normal	SHIPPED_LIVE	CFME 5.6.0 bug fixes and enhancement update	2016-06-29 18:50:04 UTC

Comment 2 CFME Bot 2016-03-16 20:45:48 UTC

https://github.com/ManageIQ/manageiq/pull/7337

Comment 3 CFME Bot 2016-03-18 17:45:47 UTC

https://github.com/ManageIQ/manageiq/pull/7399

Comment 4 CFME Bot 2016-04-11 18:15:41 UTC

New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/43b74d8f70bf4ab9d7d54dfcd6d169096ca1a0be

commit 43b74d8f70bf4ab9d7d54dfcd6d169096ca1a0be
Author:     william fitzgerald <wfitzger>
AuthorDate: Fri Mar 18 13:31:22 2016 -0400
Commit:     william fitzgerald <wfitzger>
CommitDate: Fri Apr 8 19:44:01 2016 -0400

    Automate - Added auto approval and email for Vm reconfigure (7337)
    
    Created Policy Event instances for vmreconfigure_request approved and created
    
    Created Rconfigure namespace and Email class in /Infrastructure/VM/
    
    Created auto approval and reconfigure complete instances and methods
    
    Created specs for testing
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1222724

 .../VM/Reconfigure/Email.class/__class__.yaml      | 93 ++++++++++++++++++++++
 .../__methods__/vmreconfigure_request_approved.rb  | 45 +++++++++++
 .../vmreconfigure_request_approved.yaml            | 12 +++
 .../__methods__/vmreconfigure_task_complete.rb     | 47 +++++++++++
 .../__methods__/vmreconfigure_task_complete.yaml   | 12 +++
 .../Email.class/vmreconfigurerequestapproved.yaml  | 12 +++
 .../Email.class/vmreconfiguretaskcomplete.yaml     | 12 +++
 .../VM/Reconfigure/__namespace__.yaml              | 11 +++
 .../MiqEvent/POLICY.class/vm_reconfigure.yaml      | 12 +++
 .../vmreconfigure_request_auto_approve.rb          |  5 ++
 .../vmreconfigure_request_auto_approve.yaml        | 12 +++
 .../vmreconfigurerequest_approved.yaml             | 12 +++
 .../Policy.class/vmreconfigurerequest_created.yaml | 12 +++
 .../vm_reconfigure_request_approved_spec.rb        | 17 ++++
 .../vm_reconfigure_task_complete_spec.rb           | 18 +++++
 15 files changed, 332 insertions(+)
 create mode 100644 db/fixtures/ae_datastore/ManageIQ/Infrastructure/VM/Reconfigure/Email.class/__class__.yaml
 create mode 100644 db/fixtures/ae_datastore/ManageIQ/Infrastructure/VM/Reconfigure/Email.class/__methods__/vmreconfigure_request_approved.rb
 create mode 100644 db/fixtures/ae_datastore/ManageIQ/Infrastructure/VM/Reconfigure/Email.class/__methods__/vmreconfigure_request_approved.yaml
 create mode 100644 db/fixtures/ae_datastore/ManageIQ/Infrastructure/VM/Reconfigure/Email.class/__methods__/vmreconfigure_task_complete.rb
 create mode 100644 db/fixtures/ae_datastore/ManageIQ/Infrastructure/VM/Reconfigure/Email.class/__methods__/vmreconfigure_task_complete.yaml
 create mode 100644 db/fixtures/ae_datastore/ManageIQ/Infrastructure/VM/Reconfigure/Email.class/vmreconfigurerequestapproved.yaml
 create mode 100644 db/fixtures/ae_datastore/ManageIQ/Infrastructure/VM/Reconfigure/Email.class/vmreconfiguretaskcomplete.yaml
 create mode 100644 db/fixtures/ae_datastore/ManageIQ/Infrastructure/VM/Reconfigure/__namespace__.yaml
 create mode 100644 db/fixtures/ae_datastore/ManageIQ/System/Event/MiqEvent/POLICY.class/vm_reconfigure.yaml
 create mode 100644 db/fixtures/ae_datastore/ManageIQ/System/Policy.class/__methods__/vmreconfigure_request_auto_approve.rb
 create mode 100644 db/fixtures/ae_datastore/ManageIQ/System/Policy.class/__methods__/vmreconfigure_request_auto_approve.yaml
 create mode 100644 db/fixtures/ae_datastore/ManageIQ/System/Policy.class/vmreconfigurerequest_approved.yaml
 create mode 100644 db/fixtures/ae_datastore/ManageIQ/System/Policy.class/vmreconfigurerequest_created.yaml
 create mode 100644 spec/automation/unit/method_validation/vm_reconfigure_request_approved_spec.rb
 create mode 100644 spec/automation/unit/method_validation/vm_reconfigure_task_complete_spec.rb

Comment 5 Niyaz Akhtar Ansari 2016-04-21 10:17:39 UTC

Can you please Add steps?

Comment 6 Niyaz Akhtar Ansari 2016-04-21 12:23:44 UTC

Please add verification steps

Comment 7 William Fitzgerald 2016-04-28 18:10:48 UTC

Before this fix, when you selected reconfigure, the request would need to be approved and would wait for someone to approve it.  Also, there was no email to confirm that the Vm was reconfigured.

With this fix, the Vm will be auto approved and an email will be sent that your Vm was reconfigured (if email is configured in your server).


Steps to Reproduce:
1. Check that you have the fix. 
2. Goto /Infrastructure/VM/Reconfigure/Email class.
3. Verify that these methods exist 
       : vmreconfigure_request_approved
       : vmreconfigure_task_complete
4: Goto Infrastructure/Virtual Machines
5. Select a Vm.
6. Click on 'Configuration' pull down button and select 'Reconfigure Selected items'.
7. Click on Memory and/or Processors.
8. Change something and click on 'Submit'  


Expected results:

Vm will be auto approved and an email will be sent.


Hopefully this helps.  If you have any more questions. please let me know .

Comment 8 Niyaz Akhtar Ansari 2016-05-03 09:08:56 UTC

Auto approval and email function of vm reconfiguration is working successfully. 

Verified in 5.6.0.4-beta2.3.20160421172650_719e256

Comment 10 errata-xmlrpc 2016-06-29 14:55:40 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1348

Note You need to log in before you can comment on or make changes to this bug.