This is an automatically created tracking bug! It was created to ensure that one or more security vulnerabilities are fixed in affected versions of Fedora EPEL. For comments that are specific to the vulnerability please use bugs filed against the "Security Response" product referenced in the "Blocks" field. For more information see: http://fedoraproject.org/wiki/Security/TrackingBugs When submitting as an update, use the fedpkg template provided in the next comment(s). This will include the bug IDs of this tracking bug as well as the relevant top-level CVE bugs. Please also mention the CVE IDs being fixed in the RPM changelog and the fedpkg commit message. NOTE: this issue affects multiple supported versions of Fedora EPEL. While only one tracking bug has been filed, please correct all affected versions at the same time. If you need to fix the versions independent of each other, you may clone this bug as appropriate. [bug automatically created by: add-tracking-bugs]
Use the following template to for the 'fedpkg update' request to submit an update for this issue as it contains the top-level parent bug(s) as well as this tracking bug. This will ensure that all associated bugs get updated when new packages are pushed to stable. ===== # bugfix, security, enhancement, newpackage (required) type=security # testing, stable request=testing # Bug numbers: 1234,9876 bugs=1222816,1222820 # Description of your update notes=Security fix for # Enable request automation based on the stable/unstable karma thresholds autokarma=True stable_karma=3 unstable_karma=-3 # Automatically close bugs when this marked as stable close_bugs=True # Suggest that users restart after update suggest_reboot=False ====== Additionally, you may opt to use the bodhi update submission link instead: https://admin.fedoraproject.org/updates/new/?type_=security&bugs=1222816,1222820
Created attachment 1030781 [details] Attempt at backporting xsrf patch Here's a quick attempt at backporting the xsrf patch. However the tests fail with: + python -m unittest discover -s tornado/test -p '*test.py' ...........................................................................................................WARNING:root:403 POST / (127.0.0.1): XSRF cookie does not match POST argument WARNING:root:403 POST / (127.0.0.1) 0.45ms WARNING:root:403 POST / (127.0.0.1): XSRF cookie does not match POST argument WARNING:root:403 POST / (127.0.0.1) 0.41ms ..FFWARNING:root:403 POST / (127.0.0.1): XSRF cookie does not match POST argument WARNING:root:403 POST / (127.0.0.1) 0.59ms .WARNING:root:403 POST / (127.0.0.1): '_xsrf' argument missing from POST WARNING:root:403 POST / (127.0.0.1) 0.35ms .WARNING:root:403 POST / (127.0.0.1): '_xsrf' argument missing from POST WARNING:root:403 POST / (127.0.0.1) 0.48ms .......................................................................................... ====================================================================== FAIL: test_refresh_token (web_test.XSRFTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/export/home/orion/fedora/python-tornado/tornado-2.2.1/tornado/test/web_test.py", line 801, in test_refresh_token self.assertEqual(len(tokens_seen), 6) AssertionError: 1 != 6 ====================================================================== FAIL: test_versioning (web_test.XSRFTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/export/home/orion/fedora/python-tornado/tornado-2.2.1/tornado/test/web_test.py", line 815, in test_versioning self.assertNotEqual(v1_token, v2_token) AssertionError: 'f91143889e31427f8fc6d9c9cacd2628' == 'f91143889e31427f8fc6d9c9cacd2628' ---------------------------------------------------------------------- so I don't think it's doing anything. I don't know how backwards incompatible tornado versions are. It may be worth updating to a somewhat newer tornado in EL6 first.
I've made a couple attempts at backporting this, but it's beyond me. I don't think we can upgrade due to too many backwards incompatible changes as well. Some notes from upstream: I don't think there were any relevant changes to cookie handling between 2.2.1 and 3.2.2, so the diff should apply more or less cleanly. While you're applying the XSRF cookie changes in 3.2.2 you'll also want to pick up the signed cookie fixes from 3.2.1. These cookie changes are interesting from a backwards-compatibility perspective: they're API-compatible with the previous release, but they're still disruptive because deploying them will invalidate any existing cookies (applications will have to opt-in to cookie versioning to avoid disruption). I would encourage you to upgrade to a more current release of Tornado but I don't think it would make a difference for this issue. A high-level summary: 2.3 and 2.4 are low-risk upgrades. 3.0 removed some deprecated features (including support for python 2.5), and 4.0 made some changes to thread-safety semantics (although I think the things that changed in 4.0 were new in 3.0, so you might be fine to jump straight to 4.x if you're crossing the 3.0 boundary).
This message is a reminder that EPEL 6 is nearing its end of life. Fedora will stop maintaining and issuing updates for EPEL 6 on 2020-11-30. It is our policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a 'version' of 'el6'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later EPEL version. Thank you for reporting this issue and we are sorry that we were not able to fix it before EPEL 6 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above.
This message is a reminder that EPEL 6 is nearing its end of life. Fedora will stop maintaining and issuing updates for EPEL 6 on 2020-11-30. It is policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a 'version' of 'el6'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later EPEL version. Thank you for reporting this issue and we are sorry that we were not able to fix it before EPEL 6 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version, you are encouraged to change the 'version' to a later version prior this bug is closed as described in the policy above.
EPEL el6 changed to end-of-life (EOL) status on 2020-11-30. EPEL el6 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of EPEL please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.