Spec URL: https://gil.fedorapeople.org/rxjava.spec SRPM URL: https://gil.fedorapeople.org/rxjava-1.0.10-1.fc20.src.rpm Description: RxJava a library for composing asynchronous and event-based programs using observable sequences for the Java VM. Fedora Account System Username: gil Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=9789928
Spec URL: https://gil.fedorapeople.org/rxjava.spec SRPM URL: https://gil.fedorapeople.org/rxjava-1.0.10-1.fc20.src.rpm - remove bundle JCTools library
Spec URL: https://gil.fedorapeople.org/rxjava.spec SRPM URL: https://gil.fedorapeople.org/rxjava-1.0.11-1.fc20.src.rpm - update to 1.0.11
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=9854590
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 194560 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [!]: Package uses upstream build method (ant/maven/etc.) Upstream uses gradle, but the package uses Maven - fine by me [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rxjava-1.0.11-1.fc23.noarch.rpm rxjava-javadoc-1.0.11-1.fc23.noarch.rpm rxjava-1.0.11-1.fc23.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- rxjava (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(org.jctools:jctools-core) rxjava-javadoc (rpmlib, GLIBC filtered): jpackage-utils Provides -------- rxjava: mvn(io.reactivex:rxjava) mvn(io.reactivex:rxjava:pom:) osgi(io.reactivex.rxjava) rxjava rxjava-javadoc: rxjava-javadoc Source checksums ---------------- https://github.com/ReactiveX/RxJava/archive/v1.0.11.tar.gz : CHECKSUM(SHA256) this package : 92de268e3e9fce0e8fce8a84488bf5bda7f31cf055d114fba0e75e3583554831 CHECKSUM(SHA256) upstream package : 92de268e3e9fce0e8fce8a84488bf5bda7f31cf055d114fba0e75e3583554831 http://central.maven.org/maven2/io/reactivex/rxjava/1.0.11/rxjava-1.0.11.pom : CHECKSUM(SHA256) this package : eed2f9b1d387750467a4ba2d09a20f08ed95bb4d7b6f39c4ee212dcb22dab6f1 CHECKSUM(SHA256) upstream package : eed2f9b1d387750467a4ba2d09a20f08ed95bb4d7b6f39c4ee212dcb22dab6f1 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -b 1223024 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 Just one thing: # These test fails for various reasons rm -r src/test/java/rx/observers/TestObserverTest.java \ src/test/java/rx/observers/TestSubscriberTest.java \ src/test/java/rx/internal/operators/OperatorPublishTest.java I tried to comment this part of the specfile out, and it looks like all tests are passing (at least on my machine). Could you please double-check? If those tests fail for you, please try to add more descriptive comment. Tests run: 1375, Failures: 0, Errors: 0, Skipped: 2 Otherwise the package looks good. Approved.
(In reply to Michal Srb from comment #4) > Just one thing: > # These test fails for various reasons > rm -r src/test/java/rx/observers/TestObserverTest.java \ > src/test/java/rx/observers/TestSubscriberTest.java \ > > src/test/java/rx/internal/operators/OperatorPublishTest.java > > I tried to comment this part of the specfile out, and it looks like all > tests are passing (at least on my machine). Could you please double-check? > If those tests fail for you, please try to add more descriptive comment. > > Tests run: 1375, Failures: 0, Errors: 0, Skipped: 2 > > Otherwise the package looks good. Approved. Seem a problem with Java7 (README.md explain the minimal requirement: Java 8 lambda support) I forgot to remove that part, for F > 22 Failed tests: TestSubscriberTest.testAssertNotMatchCount:59 Number of items does not match. Provided: 1 Actual: 2 TestSubscriberTest.testAssertNotMatchValue:74 Value at index: 1 expected to be [3] (Integer) but was: [2] (Integer) TestSubscriberTest.testAssertTerminalEventNotReceived:93 No terminal events received. TestObserverTest.testAssertNotMatchCount:59 Number of items does not match. Provided: 1 Actual: 2 TestObserverTest.testAssertNotMatchValue:73 Value at index: 1 expected to be [3] (Integer) but was: [2] (Integer) TestObserverTest.testAssertTerminalEventNotReceived:92 No terminal events received. on x86_64 build fine Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=9862861 on i386 as above Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=9862874 on ARM take too much time (is still running) Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=9862886
Thanks! New Package SCM Request ======================= Package Name: rxjava Short Description: Reactive Extensions for the JVM Upstream URL: https://github.com/ReactiveX/RxJava Owners: gil InitialCC: java-sig
Git done (by process-git-requests).
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=986575