Red Hat Satellite engineering is moving the tracking of its product development work on Satellite to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "Satellite project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs will be migrated starting at the end of May. If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "Satellite project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/SAT-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1223776 - [RFE] hammer import does not handle invalid csv files correctly
Summary: [RFE] hammer import does not handle invalid csv files correctly
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Transitions
Version: Unspecified
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: Unspecified
Assignee: Clifford Perry
QA Contact: Roman Plevka
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-05-21 12:36 UTC by Roman Plevka
Modified: 2019-09-26 16:26 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-07-27 09:15:39 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:1501 0 normal SHIPPED_LIVE Red Hat Satellite 6.2 Capsule and Server 2016-07-27 12:28:58 UTC

Description Roman Plevka 2015-05-21 12:36:47 UTC
Description of problem:
If user passes a csv file containing only a header and an empty line (invalid csv file), the import sub commands accept and process it.

Version-Release number of selected component (if applicable):
hammer_cli_import (0.10.14)

Steps to reproduce:
e.g.
# cat CHANNELS/export.csv 
org_id,channel_id,channel_label,channel_name

#
# hammer import content-view --csv-file CHANNELS/export.csv --verbose
Importing from CHANNELS/export.csv
Caught Errno::ENOENT:No such file or directory - /root/exports/CHANNELS/0/0.csv while processing CSV line:
{"org_id"=>nil, "channel_id"=>nil, "channel_label"=>nil, "channel_name"=>nil}
Summary
  No action taken.

This applies to all sub commands.

Expected results:
the file should not be accepted and no action should be taken.

Comment 1 RHEL Program Management 2015-05-21 12:42:37 UTC
Since this issue was entered in Red Hat Bugzilla, the release flag has been
set to ? to ensure that it is properly evaluated for this release.

Comment 3 Grant Gainey 2015-05-21 13:48:18 UTC
The request here is to replace the ugly 

Caught Errno::ENOENT:No such file or directory - /root/exports/CHANNELS/0/0.csv while processing CSV line:
{"org_id"=>nil, "channel_id"=>nil, "channel_label"=>nil, "channel_name"=>nil}

with some meaningful error message like "Invalid CSV CHANNELS/export.csv detected, skipping"

Resetting for 6.2

Comment 4 Tomas Lestach 2015-06-03 15:39:06 UTC
This was addressed with

hammer-cli-import.git: f518fbdca8015270eaab1fc4ba4fc31861f209bc

Comment 7 Roman Plevka 2016-03-25 23:19:59 UTC
VERIFIED

# hammer -u admin -p changeme import content-view --csv-file export.csv --verbose
Importing from export.csv
Exiting: Broken CSV in export.csv: 4 columns expected but found 0
Summary
  No action taken.

tested with SNAP5.1

Comment 10 errata-xmlrpc 2016-07-27 09:15:39 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1501


Note You need to log in before you can comment on or make changes to this bug.