Spec URL: https://jchaloup.fedorapeople.org/reviews/anymarkup/python-anymarkup.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/anymarkup/python-anymarkup-0.4.1-1.fc20.src.rpm Description: Parse or serialize any markup. Currently supports ini, json, xml and yaml. Fedora Account System Username: jchaloup Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=9817763 $ rpmlint /home/jchaloup/rpmbuild/SRPMS/python-anymarkup-0.4.1-1.fc20.src.rpm /home/jchaloup/rpmbuild/RPMS/noarch/python-anymarkup-0.4.1-1.fc20.noarch.rpm python-anymarkup.src: W: spelling-error %description -l en_US ini -> uni, in, ii python-anymarkup.src: W: spelling-error %description -l en_US json -> son, j son python-anymarkup.src: W: spelling-error %description -l en_US xml -> XML, ml, x ml python-anymarkup.src: W: spelling-error %description -l en_US yaml -> yam, yams, yawl python-anymarkup.noarch: W: spelling-error %description -l en_US ini -> uni, in, ii python-anymarkup.noarch: W: spelling-error %description -l en_US json -> son, j son python-anymarkup.noarch: W: spelling-error %description -l en_US xml -> XML, ml, x ml python-anymarkup.noarch: W: spelling-error %description -l en_US yaml -> yam, yams, yawl 2 packages and 0 specfiles checked; 0 errors, 8 warnings.
An .egg-info file is not bundled, you can remove that line. The summary is repeated in the description; "Parse or serialize any markup." can be omitted. The upstream supports Python 3, so you should build a python3 subpackage as well. (You can use pyp2rpm -p3 . If you want to support RHEL6 with the same spec, there are some definitions to do -- se the guidelines, or another pagkage [0].) [0] for example, https://git.fedorahosted.org/cgit/python-pytest-multihost.git/tree/python-pytest-multihost.spec
Sorry, ignore my comment about the .egg-info
Upstream: https://github.com/bkabrda/anymarkup
Spec file and srpm updated. Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=9827187
Just one more issue: you're missing Requires for the python3 version. (The Fedora packages are: python3-configobj python3-six python3-xmltodict python3-PyYAML)
Also, I've noticed that upstream tests don't pass due to some mistake in generating the tarball. I've filed the issue [0], after it's fixed you'll be able to add a %check. [0] https://github.com/bkabrda/anymarkup/issues/4
Thanks Petr. I have intentionally removed runtime dependency on python as installing python modules without python being installed on system does not make sense. But if there is a good intention in requiring it I will update the spec file. Thanks for the %check section issue. Jan
I wasn't clear. I meant a Requirements line for the Python3 subpackage is missing altogether. (rpmbuild finds the Python dependency automatically) Requires -------- python3-anymarkup (rpmlib, GLIBC filtered): python(abi) python3-pytest python-anymarkup (rpmlib, GLIBC filtered): PyYAML pytest python(abi) python-configobj python-six python-xmltodict
Version 4.2 was released upstream, fixing the testsuite issue, so you can add a %check section. I don't see running tests documented upstream but it should work like this: %check %{__python2} -m pytest %if 0%{?with_python3} pushd %{py3dir} %{__python3} -m pytest popd %endif (Plus add all Requires also as BuildRequires to make the tests run.)
With 0.4.2 some tests still fail: 8 failed, 45 passed in 0.36 seconds
Scratch build [1] looks good. ============================= test session starts ============================== platform linux2 -- Python 2.7.9 -- py-1.4.26 -- pytest-2.7.1 rootdir: /builddir/build/BUILD/anymarkup-0.4.2, inifile: collected 53 items test/test_parse.py ........................................ test/test_serialize.py ............. ========================== 53 passed in 0.27 seconds =========================== ~/build/BUILD/python3-python-anymarkup-0.4.2-1.fc23 ~/build/BUILD/anymarkup-0.4.2 + pushd /builddir/build/BUILD/python3-python-anymarkup-0.4.2-1.fc23 + /usr/bin/python3 -m pytest ============================= test session starts ============================== platform linux -- Python 3.4.3 -- py-1.4.26 -- pytest-2.7.1 rootdir: /builddir/build/BUILD/python3-python-anymarkup-0.4.2-1.fc23, inifile: collected 53 items test/test_parse.py ........................................ test/test_serialize.py ............. ========================== 53 passed in 0.34 seconds =========================== Spec file [2] and srpm [3] updated. [1] http://koji.fedoraproject.org/koji/taskinfo?taskID=9850931 [2] https://jchaloup.fedorapeople.org/reviews/anymarkup/python-anymarkup.spec [3] https://jchaloup.fedorapeople.org/reviews/anymarkup/python-anymarkup-0.4.2-1.fc20.src.rpm
Three problems -- sorry for missing some of these earlier: - The Source0 URL is wrong, should be https://pypi.python.org/packages/source/a/%{pypi_name}/%{pypi_name}-%{version}.tar.gz - The LICENSE file is installed as %doc. (This is a bug in my template, apologies!) - Requires: python3-pytest is unnecessary - tests aren't required at run-time.
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=9875343 SRPM: https://jchaloup.fedorapeople.org/reviews/anymarkup/python-anymarkup-0.4.2-1.fc23.src.rpm Spec: https://jchaloup.fedorapeople.org/reviews/anymarkup/python-anymarkup.spec
Good to go! Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X]: License field in the package spec file matches the actual license. [X]: License file installed when any subpackage combination is installed. [X]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [X]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [X]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [X]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [X]: A package which is used by another package via an egg interface should provide egg info. [X]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [X]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: python3-anymarkup is an independent subpackage [X]: Package functions as described. [X]: Latest version is packaged. [X]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [X]: Package should compile and build into binary rpms on all supported architectures. [X]: %check is present and all tests pass. [X]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-anymarkup-0.4.2-1.fc21.noarch.rpm python3-anymarkup-0.4.2-1.fc21.noarch.rpm python-anymarkup-0.4.2-1.fc21.src.rpm python-anymarkup.noarch: W: spelling-error %description -l en_US ini -> uni, in, ii python-anymarkup.noarch: W: spelling-error %description -l en_US json -> son, j son python-anymarkup.noarch: W: spelling-error %description -l en_US xml -> XML, ml, x ml python-anymarkup.noarch: W: spelling-error %description -l en_US yaml -> yam, yams, yawl python3-anymarkup.noarch: W: spelling-error %description -l en_US ini -> uni, in, ii python3-anymarkup.noarch: W: spelling-error %description -l en_US json -> son, j son python3-anymarkup.noarch: W: spelling-error %description -l en_US xml -> XML, ml, x ml python3-anymarkup.noarch: W: spelling-error %description -l en_US yaml -> yam, yams, yawl python-anymarkup.src: W: spelling-error %description -l en_US ini -> uni, in, ii python-anymarkup.src: W: spelling-error %description -l en_US json -> son, j son python-anymarkup.src: W: spelling-error %description -l en_US xml -> XML, ml, x ml python-anymarkup.src: W: spelling-error %description -l en_US yaml -> yam, yams, yawl python-anymarkup.src: W: file-size-mismatch anymarkup-0.4.2.tar.gz = 10303, https://pypi.python.org/packages/source/a/anymarkup/anymarkup-0.4.2.tar.gz = 12647 3 packages and 0 specfiles checked; 0 errors, 13 warnings. Rpmlint (installed packages) ---------------------------- python3-anymarkup.noarch: W: spelling-error %description -l en_US ini -> uni, in, ii python3-anymarkup.noarch: W: spelling-error %description -l en_US json -> son, j son python3-anymarkup.noarch: W: spelling-error %description -l en_US xml -> XML, ml, x ml python3-anymarkup.noarch: W: spelling-error %description -l en_US yaml -> yam, yams, yawl python-anymarkup.noarch: W: spelling-error %description -l en_US ini -> uni, in, ii python-anymarkup.noarch: W: spelling-error %description -l en_US json -> son, j son python-anymarkup.noarch: W: spelling-error %description -l en_US xml -> XML, ml, x ml python-anymarkup.noarch: W: spelling-error %description -l en_US yaml -> yam, yams, yawl 2 packages and 0 specfiles checked; 0 errors, 8 warnings. Requires -------- python3-anymarkup (rpmlib, GLIBC filtered): python(abi) python3 python3-PyYAML python3-configobj python3-six python3-xmltodict python-anymarkup (rpmlib, GLIBC filtered): PyYAML pytest python(abi) python-configobj python-six python-xmltodict Provides -------- python3-anymarkup: python3-anymarkup python-anymarkup: python-anymarkup Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04 Command line :/usr/bin/fedora-review -b 1223843 Buildroot used: fedora-21-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
New Package SCM Request ======================= Package Name: python-anymarkup Short Description: Parse or serialize any markup in Python Upstream URL: https://github.com/bkabrda/anymarkup Owners: jchaloup pviktori Branches: f22 f21 f20 el6 el7 InitialCC:
Git done (by process-git-requests).
python-anymarkup-0.4.2-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-anymarkup-0.4.2-1.fc22
python-anymarkup-0.4.2-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-anymarkup-0.4.2-1.fc21
python-anymarkup-0.4.2-1.fc21 has been pushed to the Fedora 21 testing repository.
python-anymarkup-0.4.3-2.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-anymarkup-0.4.3-2.fc22
python-anymarkup-0.4.3-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-anymarkup-0.4.3-2.fc21
jgrulich's scratch build of kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 for f22-candidate and git://pkgs.fedoraproject.org/kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11212117
Jan, are you planning to push the update to f22/f23 stable?
Push to stable request for f22, f23 was rawhide build built by that time.
Ah, sorry, I meant f21/f22. Or, whatever needs to be done to close this bug :)
python-anymarkup-0.4.3-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.