Bug 1223947 - Syntax errors in gfind_missing_files shell scripts
Summary: Syntax errors in gfind_missing_files shell scripts
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: scripts
Version: 3.7.6
Hardware: All
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Kotresh HR
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-05-21 18:39 UTC by Patrick Matthäi
Modified: 2016-07-20 13:55 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.7.13
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-07-20 13:55:16 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:

Attachments (Terms of Use)
Patch for fixing issue (2.23 KB, patch)
2015-11-09 09:49 UTC, Patrick Matthäi 		no flags Details | Diff
View All

Description Patrick Matthäi 2015-05-21 18:39:38 UTC 
$ sh -n ./tools/gfind_missing_files/gfid_to_path.sh
./tools/gfind_missing_files/gfid_to_path.sh: 14: ./tools/gfind_missing_files/gfid_to_path.sh: Syntax error: "(" unexpected

$ sh -n ./tools/gfind_missing_files/gfind_missing_files.sh 
./tools/gfind_missing_files/gfind_missing_files.sh: 17: ./tools/gfind_missing_files/gfind_missing_files.sh: Syntax error: "(" unexpected
Comment 1 Patrick Matthäi 2015-11-09 09:49:14 UTC 
Created attachment 1091671 [details]
Patch for fixing issue
Comment 2 Patrick Matthäi 2015-11-09 09:49:38 UTC 
Hello,

patch attached. Please add it for 3.7.7
Comment 3 Vijay Bellur 2016-06-22 09:58:50 UTC 
REVIEW: http://review.gluster.org/14774 (scripts: bash-isms in scripts) posted (#1) for review on release-3.7 by Kotresh HR (khiremat)
Comment 4 Vijay Bellur 2016-06-22 10:09:32 UTC 
REVIEW: http://review.gluster.org/14774 (scripts: bash-isms in scripts) posted (#2) for review on release-3.7 by Kotresh HR (khiremat)
Comment 5 Vijay Bellur 2016-06-24 16:42:34 UTC 
COMMIT: http://review.gluster.org/14774 committed in release-3.7 by Kaleb KEITHLEY (kkeithle) 
------
commit cdaa5dd7f91d93fce3d900e4321dd83d021e96dd
Author: Kaleb S KEITHLEY <kkeithle>
Date:   Tue May 17 11:06:07 2016 -0400

    scripts: bash-isms in scripts
    
    Backport of http://review.gluster.org/14401/
    
    Change-Id: I05f8718fb73c16dbb37c1f7460bb7b55cc0ffe97
    BUG: 1223947
    Reported-by: Patrick Matthäi <pmatthaei>
    Signed-off-by: Kotresh HR <khiremat>
    Original-Author: Kaleb S KEITHLEY <kkeithle>
    (cherry picked from commit 2df72780e473709128a4f5d7f274a9063b288252)
    Reviewed-on: http://review.gluster.org/14774
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
Comment 6 Kaushal 2016-07-20 13:55:16 UTC 
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.13, please open a new bug report.

glusterfs-3.7.13 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-users/2016-July/027604.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user
Note You need to log in before you can comment on or make changes to this bug.