Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1224093

Summary: AS7Based product plugins should not require changing JBossProductType when there is a change in slot value
Product: [JBoss] JBoss Operations Network Reporter: Libor Zoubek <lzoubek>
Component: Plugin -- JBoss EAP 6Assignee: Simeon Pinder <spinder>
Status: CLOSED WONTFIX QA Contact: Mike Foley <mfoley>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: JON 3.3.0CC: fbrychta, loleary, rhatlapa, theute
Target Milestone: ---   
Target Release: One-off release   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-01-21 14:55:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Libor Zoubek 2015-05-22 08:08:16 UTC 
Description of problem:

Our poor design of JBossProductType enum limits us in extending it. In order to fix Bug 1218307 we need to define just another value in JBossProductType enum, because the discovery code fails, in case it is not able to determine productType based on slot value in product.conf or a using homeDir name as a fallback.

Long time ago, we implemented DiscoverCallback feature to plugin descriptor to handle these kind of situations, but this is not enough. DiscoveryCallback would work, if JBossProductType enum is detected (in case proudct.conf ie. contains slot=eap). Plugin extending AS7Plugin could then fix plugin configuration like https://github.com/gatein/gatein-rhq/blob/master/src/main/java/org/gatein/rhq/plugins/PortalDiscoveryCallback.java does. Given code is only a workaround to a fact, that gatein plugin has slot defined to "jpp" or "eap", and at runtime DMR returns "Portal" string as a response to :read-attribute(name=product-name). Gatein plugin (an all other AS7based plugins) still relies on AS7plugin and JBossProductType.


Version-Release number of selected component (if applicable):
JON 3.3.x


Actual results: new AS7 Based plugin which manages product with slot=foo new requires fix in AS7 plugin - defining JBossProductType, otherwise product server discovery fails on bugs similar to Bug 1218307


Expected results: new AS7 based plugin which manages product with slot=foo must not require fix & rebuild of base AS7 plugin


Additional info:
Comment 1 Libor Zoubek 2015-05-22 08:35:39 UTC 
Initial idea was transforming JBossProductType from enum to class and use java ServiceLoader interface, so other plugin could contribute to some "known products registry" living in base AS7 plugin. This did not work because of plugin container design and plugin classloader's isolation. 

To fix this issue I'll introduce JBossProductType to JBossProduct class and redo product type discovery logic (creating JBossProduct instance based on slot value) into JBossProduct instance. Product Discovery logic in Base plugin will return JBossProduct.unknown() in case it detects slot value, which it cannot assign to any known product definition. This unknown product type could then be detected by DiscoveryCallback implementations, which can then set correct values to pluginConfiguration and properly set resource name and description version. I'll introduce abstract DiscoveryCallback implementation which plugin can extend and only define it's JBossProduct.
Comment 4 Larry O'Leary 2016-01-21 14:55:05 UTC 
Closing as won't fix. 

Although this capability would be very helpful for Red Hat and JBoss branding as it would no longer require a completely new EAP plug-in pack each time a new product was introduced or changed its name or identifier, the risk and effort is not worth the return. This is because we are so late in the 3.3 maintenance cycle and many of the naming changes that have occurred over the past 24 months have slowed down.

Additionally, we have decided to introduce a change in the EAP plug-in (tracked in bug 1300727) that will treat any unknown or unidentifiable EAP based product as a community AS instance. This will provide basic application server monitoring and management for the edge cases in where a rebrand may occur.