Description of problem: peers which are probed and awaiting connection, when get connected in between a transaction, cause unexpected behaviour with the operation. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
REVIEW: http://review.gluster.org/10895 (glusterd: Fix conf->generation to stop new peers participating in a transaction, while the transaction is in progress.) posted (#1) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/10895 (glusterd: Fix conf->generation to stop new peers participating in a transaction, while the transaction is in progress.) posted (#2) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/10895 (glusterd: Fix conf->generation to stop new peers participating in a transaction, while the transaction is in progress.) posted (#3) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/10895 (glusterd: Fix conf->generation to stop new peers participating in a transaction, while the transaction is in progress.) posted (#4) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/10895 (glusterd: Fix conf->generation to stop new peers participating in a transaction, while the transaction is in progress.) posted (#5) for review on master by Avra Sengupta (asengupt)
COMMIT: http://review.gluster.org/10895 committed in master by Kaushal M (kaushal) ------ commit d1ff9dead1f26151f89d154fab8252437601d22f Author: Avra Sengupta <asengupt> Date: Fri May 22 18:38:23 2015 +0530 glusterd: Fix conf->generation to stop new peers participating in a transaction, while the transaction is in progress. Every peer gets a generation number, during it's inception. This generation number is used to identify the peer throiughout it's lifetime. This number is assigned based on the current generation number of the system, which is incremented with every peer that is added. The problem arises when we add a peer, and before it gets a rpc_connect we begin a transaction. In such a case, the peer gets considered in the transaction, but doesn't participate in it coz it isn't connected yet. The moment it gets the rpc notification and is connected, it starts participating in the transaction and all hell breaks loose. To resolve it, we should assign the peerinfo a new generation number everytime it's connected, so that this number will be greater than the generation number that the transaction is acting upon, and even though the peer is connected it will not participate in the transaction. We should also assign the new generation number of the peer to the peerctx, so that the framework that searches for peerinfos based on the generation number, will still function in the same manner. Removing ./tests/basic/volume-snapshot-clone.t from bad-tests. Also removed the duplicate entry of ./tests/bugs/snapshot/bug-1112559.t from bad-tests. Original entry was removed in http://review.gluster.org/10840 Change-Id: Ie25e3ecf59b19535b9cded7449e944221fac97a0 BUG: 1224290 Signed-off-by: Avra Sengupta <asengupt> Reviewed-on: http://review.gluster.org/10895 Reviewed-by: Kaushal M <kaushal> Tested-by: Kaushal M <kaushal>
Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report. glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/ [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user