Bug 1224290 - peers connected in the middle of a transaction are participating in the transaction
Summary: peers connected in the middle of a transaction are participating in the trans...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: glusterd
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Avra Sengupta
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1224292 1225371
TreeView+ depends on / blocked
 
Reported: 2015-05-22 13:01 UTC by Avra Sengupta
Modified: 2016-06-16 13:04 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.8rc2
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1224292 (view as bug list)
Environment:
Last Closed: 2016-06-16 13:04:41 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Avra Sengupta 2015-05-22 13:01:10 UTC
Description of problem:
peers which are probed and awaiting connection, when get connected in between a transaction, cause unexpected behaviour with the operation.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2015-05-22 14:08:45 UTC
REVIEW: http://review.gluster.org/10895 (glusterd: Fix conf->generation to stop new peers participating in a transaction, while the transaction is in progress.) posted (#1) for review on master by Avra Sengupta (asengupt)

Comment 2 Anand Avati 2015-05-26 10:13:22 UTC
REVIEW: http://review.gluster.org/10895 (glusterd: Fix conf->generation to stop new peers participating in a transaction, while the transaction is in progress.) posted (#2) for review on master by Avra Sengupta (asengupt)

Comment 3 Anand Avati 2015-05-26 12:59:10 UTC
REVIEW: http://review.gluster.org/10895 (glusterd: Fix conf->generation to stop new peers participating in a transaction, while the transaction is in progress.) posted (#3) for review on master by Avra Sengupta (asengupt)

Comment 4 Anand Avati 2015-05-27 06:59:56 UTC
REVIEW: http://review.gluster.org/10895 (glusterd: Fix conf->generation to stop new peers participating in a transaction, while the transaction is in progress.) posted (#4) for review on master by Avra Sengupta (asengupt)

Comment 5 Anand Avati 2015-05-27 07:02:56 UTC
REVIEW: http://review.gluster.org/10895 (glusterd: Fix conf->generation to stop new peers participating in a transaction, while the transaction is in progress.) posted (#5) for review on master by Avra Sengupta (asengupt)

Comment 6 Anand Avati 2015-05-27 08:28:50 UTC
COMMIT: http://review.gluster.org/10895 committed in master by Kaushal M (kaushal) 
------
commit d1ff9dead1f26151f89d154fab8252437601d22f
Author: Avra Sengupta <asengupt>
Date:   Fri May 22 18:38:23 2015 +0530

    glusterd: Fix conf->generation to stop new peers participating in
    a transaction, while the transaction is in progress.
    
    Every peer gets a generation number, during it's inception.
    This generation number is used to identify the peer throiughout
    it's lifetime. This number is assigned based on the current
    generation number of the system, which is incremented with every
    peer that is added.
    
    The problem arises when we add a peer, and before it gets a rpc_connect
    we begin a transaction. In such a case, the peer gets considered in the
    transaction, but doesn't participate in it coz it isn't connected yet.
    The moment it gets the rpc notification and is connected, it starts
    participating in the transaction and all hell breaks loose.
    
    To resolve it, we should assign the peerinfo a new generation number
    everytime it's connected, so that this number will be greater than the
    generation number that the transaction is acting upon, and even though
    the peer is connected it will not participate in the transaction.
    
    We should also assign the new generation number of the peer to the peerctx,
    so that the framework that searches for peerinfos based on the generation
    number, will still function in the same manner.
    
    Removing ./tests/basic/volume-snapshot-clone.t from bad-tests.
    Also removed the duplicate entry of ./tests/bugs/snapshot/bug-1112559.t
    from bad-tests. Original entry was removed in
    http://review.gluster.org/10840
    
    Change-Id: Ie25e3ecf59b19535b9cded7449e944221fac97a0
    BUG: 1224290
    Signed-off-by: Avra Sengupta <asengupt>
    Reviewed-on: http://review.gluster.org/10895
    Reviewed-by: Kaushal M <kaushal>
    Tested-by: Kaushal M <kaushal>

Comment 7 Nagaprasad Sathyanarayana 2015-10-25 14:59:51 UTC
Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

Comment 8 Niels de Vos 2016-06-16 13:04:41 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.