Bug 1224420 - Review Request: iio-sensor-proxy - IIO accelerometer sensor to input device proxy
Summary: Review Request: iio-sensor-proxy - IIO accelerometer sensor to input device p...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-05-22 21:50 UTC by Igor Gnatenko
Modified: 2015-07-03 18:49 UTC (History)
3 users (show)

Fixed In Version: iio-sensor-proxy-1.0-6.fc22
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-07-03 18:49:48 UTC
Type: ---
Embargoed:
rdieter: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Igor Gnatenko 2015-05-22 21:50:04 UTC
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/iio-sensor-proxy.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/iio-sensor-proxy-1.0-1.fc23.src.rpm
Description: IIO accelerometer sensor to input device proxy.
Fedora Account System Username: ignatenkobrain

Comment 1 Rex Dieter 2015-05-23 15:00:17 UTC
initial inspection looks good, just one small non-blocking suggestion:

1.  consider using %{_udevrulesdir} macro instead of home-brewed %{udevdir}/rules.d

Comment 2 Igor Gnatenko 2015-05-23 15:06:30 UTC
(In reply to Rex Dieter from comment #1)
> initial inspection looks good, just one small non-blocking suggestion:
> 
> 1.  consider using %{_udevrulesdir} macro instead of home-brewed
> %{udevdir}/rules.d
Fixed

Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/iio-sensor-proxy.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/iio-sensor-proxy-1.0-2.fc23.src.rpm

Comment 3 Rex Dieter 2015-05-23 15:40:19 UTC
naming: ok

sources: ok
c63fd69023a52adf369a371d22cc2ece  iio-sensor-proxy-1.0.tar.xz


2.  %build SHOULD be verbose, please add
%configure --disable-silent-rules
or use
%make_build V=1

macros: ok

scriptlets ok

3. license: NOT ok, most(many?) sources are GPLv2 only, so MUST use:
License: GPLv2

builds/installs/uninstalls: ok


Only real blocker is the minor licensing tag, since it's mostly cosmetic, please fix prior to importing.


APPROVED.

Comment 4 Igor Gnatenko 2015-05-23 16:07:22 UTC
New Package SCM Request
=======================
Package Name: iio-sensor-proxy
Short Description: IIO accelerometer sensor to input device proxy
Upstream URL: https://github.com/hadess/iio-sensor-proxy
Owners: ignatenkobrain hadess
Branches: f22

Comment 5 Gwyn Ciesla 2015-05-24 20:37:10 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2015-05-24 21:38:25 UTC
iio-sensor-proxy-1.0-3.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/iio-sensor-proxy-1.0-3.fc22

Comment 7 Fedora Update System 2015-05-27 16:25:42 UTC
iio-sensor-proxy-1.0-3.fc22 has been pushed to the Fedora 22 testing repository.

Comment 8 Fedora Update System 2015-06-23 08:17:05 UTC
iio-sensor-proxy-1.0-6.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/iio-sensor-proxy-1.0-6.fc22

Comment 9 Fedora Update System 2015-07-03 18:49:48 UTC
iio-sensor-proxy-1.0-6.fc22 has been pushed to the Fedora 22 stable repository.


Note You need to log in before you can comment on or make changes to this bug.