Bug 1224596 - [RFE] Provide hourly scrubbing option
Summary: [RFE] Provide hourly scrubbing option
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: bitrot
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Venky Shankar
QA Contact: RajeshReddy
bugs@gluster.org
URL:
Whiteboard:
Depends On:
Blocks: 1224647 1226132
TreeView+ depends on / blocked
 
Reported: 2015-05-25 03:57 UTC by Venky Shankar
Modified: 2016-07-13 22:35 UTC (History)
5 users (show)

Fixed In Version: glusterfs-3.8rc2
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1224647 (view as bug list)
Environment:
Last Closed: 2016-06-16 13:04:41 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Venky Shankar 2015-05-25 03:57:51 UTC
Description of problem:
Provide an option to scrub the filesystem every hour.

Version-Release number of selected component (if applicable):
mainline

Comment 1 Anand Avati 2015-05-25 05:39:47 UTC
REVIEW: http://review.gluster.org/10893 (features/bitrot: reimplement scrubbing frequency) posted (#3) for review on master by Venky Shankar (vshankar)

Comment 2 Anand Avati 2015-05-25 05:39:49 UTC
REVIEW: http://review.gluster.org/10892 (contrib/timer-wheel: mod_timer() and friends) posted (#3) for review on master by Venky Shankar (vshankar)

Comment 3 Anand Avati 2015-05-25 06:12:57 UTC
REVIEW: http://review.gluster.org/10901 (contrib/timer-wheel: mod_timer() and friends) posted (#1) for review on release-3.7 by Venky Shankar (vshankar)

Comment 4 Anand Avati 2015-05-25 06:12:59 UTC
REVIEW: http://review.gluster.org/10902 (features/bitrot: reimplement scrubbing frequency) posted (#1) for review on release-3.7 by Venky Shankar (vshankar)

Comment 5 Anand Avati 2015-05-27 12:43:07 UTC
REVIEW: http://review.gluster.org/10892 (contrib/timer-wheel: mod_timer() and friends) posted (#4) for review on master by Venky Shankar (vshankar)

Comment 6 Anand Avati 2015-05-27 12:43:57 UTC
REVIEW: http://review.gluster.org/10893 (features/bitrot: reimplement scrubbing frequency) posted (#4) for review on master by Venky Shankar (vshankar)

Comment 7 Anand Avati 2015-05-28 11:19:33 UTC
COMMIT: http://review.gluster.org/10893 committed in master by Vijay Bellur (vbellur) 
------
commit 6fc12a43f3e20ea24969e5a3c949f7c27d9c1893
Author: Venky Shankar <vshankar>
Date:   Thu May 21 19:55:02 2015 +0530

    features/bitrot: reimplement scrubbing frequency
    
    This patch reimplments existing scrub-frequency mechanism used
    to schedule scrubber runs. Existing mechanism uses periodic
    sleeps (waking up periodically on minimum granularity) and
    performing a number of tracking checks based on counters and
    sleep times. This patch does away with all the nifty counters
    and uses timer-wheel to schedule scrub runs.
    
    Scheduling changes are peformed by merely calculating the new
    expiry time and calling mod_timer() [mod_timer_pending() in
    some cases] making the code more debuggable and easier to
    follow. This also introduces "hourly" scrubbing tunable as an
    aid for testing scrubbing during development/testing cycle.
    
    One could also implement on-demand scrubbing with ease: by
    invoking mod_timer() with an expiry of one (1) second, thereby
    scheduling a scrub run the very next second.
    
    Change-Id: I6c7c5f0c6c9f886bf574d88c04cde14b76e60a8b
    BUG: 1224596
    Signed-off-by: Venky Shankar <vshankar>
    Reviewed-on: http://review.gluster.org/10893
    Reviewed-by: Gaurav Kumar Garg <ggarg>
    Tested-by: NetBSD Build System
    Reviewed-by: Vijay Bellur <vbellur>

Comment 8 Nagaprasad Sathyanarayana 2015-10-25 15:09:23 UTC
Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

Comment 9 Niels de Vos 2016-06-16 13:04:41 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.