Bug 1224966 - Review Request: perl-MouseX-StrictConstructor - Make your object constructors blow up on unknown attributes
Summary: Review Request: perl-MouseX-StrictConstructor - Make your object constructors...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-05-26 10:02 UTC by Jitka Plesnikova
Modified: 2015-05-27 06:47 UTC (History)
2 users (show)

Fixed In Version: perl-MouseX-StrictConstructor-0.02-1.fc23
Clone Of:
Environment:
Last Closed: 2015-05-27 06:47:45 UTC
Type: ---
Embargoed:
psabata: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Jitka Plesnikova 2015-05-26 10:02:05 UTC
Spec URL: https://jplesnik.fedorapeople.org/perl-MouseX-StrictConstructor/perl-MouseX-StrictConstructor.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-MouseX-StrictConstructor/perl-MouseX-StrictConstructor-0.02-1.fc23.src.rpm
Description:
Simply loading this module makes your constructors "strict". If your
constructor is called with an attribute argument that your class does not
declare, then it dies. This is a great way to catch small typos.

Fedora Account System Username: jplesnik

Comment 1 Petr Šabata 2015-05-26 13:10:02 UTC
Tip: Instead of commenting it out, you could just delete the line in your patch.

Tip: If you want to cut the dep list, you could also remove the auto_set_repository() call and get rid of Module::Install::Repository.  Since we don't ship META.* files, it's rather useless.

I can't see `strict' being used anywhere.  I suppose you can safely drop it.  Although it won't really change much.

Add a version constraint to the autodetected `Mouse' dependency and filter out the unversioned one.

I don't consider any of this a review blocker.  Approving.

Comment 2 Jitka Plesnikova 2015-05-26 13:41:49 UTC
New Package SCM Request
=======================
Package Name: perl-MouseX-StrictConstructor
Short Description: Make your object constructors blow up on unknown attributes
Upstream URL: http://search.cpan.org/dist/MouseX-StrictConstructor/
Owners: jplesnik ppisar psabata
Branches:
InitialCC: perl-sig

Comment 3 Gwyn Ciesla 2015-05-26 19:21:46 UTC
Git done (by process-git-requests).

Comment 4 Jitka Plesnikova 2015-05-27 06:47:45 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.