Bug 1225115 - "mock --quiet --scrub=all" prints "finishing: scrub ['all']"
Summary: "mock --quiet --scrub=all" prints "finishing: scrub ['all']"
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: mock
Version: 23
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Miroslav Suchý
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-05-26 15:37 UTC by Radek Holy
Modified: 2015-10-07 04:06 UTC (History)
8 users (show)

Fixed In Version: 1.2.13-2.fc22 mock-1.2.13-2.fc21 mock-1.2.13-2.el7 mock-1.2.13-2.el6
Clone Of:
Environment:
Last Closed: 2015-09-23 04:10:37 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
delete redundant output (728 bytes, patch)
2015-06-25 13:00 UTC, Mikhail Campos
no flags Details | Diff

Description Radek Holy 2015-05-26 15:37:51 UTC
Description of problem:
The command "--scrub" prints an unnecessary output even if the "--quiet" switch is used. Basically the output says that the requested action have been finished. I believe that I can deduce the same from the fact that the process has exited. I need to work around this by redirecting the standard output in my scripts.


Version-Release number of selected component (if applicable):
mock-1.2.8-1.fc22.noarch


How reproducible:
always


Steps to Reproduce:
1. mock --quiet --scrub=all


Actual results:
"finishing: scrub ['all']" printed to the standard output


Expected results:
the message is not printed at least when the "--quiet" switch is used

Comment 1 Mikhail Campos 2015-06-25 13:00:47 UTC
Created attachment 1043098 [details]
delete redundant output

This is redundant message. We can simply delete it.

Comment 2 Radek Holy 2015-06-25 14:17:15 UTC
Oops, I just noticed (because of the patch), that it prints "finish*ing*", not "finish*ed*". So, maybe if the "finish" method can take some time, it's relevant. But still, I think that the "--quiet" option should suppress it.

Comment 3 Mikhail Campos 2015-06-26 08:28:17 UTC
State printing stuff should be processed by State class only, which will result in correct printing when "--quiet" is used. Also, state.finish() takes little time to execute (it is just a simple logger), so problem message is not relevant in any case.

Comment 4 Miroslav Suchý 2015-07-07 15:23:31 UTC
Patch applied as:
* dba769a Deleted unnecessary output [RHBZ#1225115]

Thanks Mikhail for the patch.

Comment 5 Jan Kurik 2015-07-15 14:06:24 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle.
Changing version to '23'.

(As we did not run this process for some time, it could affect also pre-Fedora 23 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23

Comment 6 Fedora Update System 2015-09-16 20:02:14 UTC
mock-1.2.13-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16053

Comment 7 Fedora Update System 2015-09-16 20:05:11 UTC
mock-1.2.13-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16054

Comment 8 Fedora Update System 2015-09-16 20:07:14 UTC
mock-1.2.13-2.fc21 has been submitted as an update to Fedora 21. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16056

Comment 9 Fedora Update System 2015-09-16 20:08:52 UTC
mock-1.2.13-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8114

Comment 10 Fedora Update System 2015-09-16 20:10:00 UTC
mock-1.2.13-2.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8115

Comment 11 Fedora Update System 2015-09-17 21:30:23 UTC
mock-1.2.13-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update mock'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16054

Comment 12 Fedora Update System 2015-09-18 05:21:14 UTC
mock-1.2.13-2.fc21 has been pushed to the Fedora 21 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update mock'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16056

Comment 13 Fedora Update System 2015-09-18 16:24:24 UTC
mock-1.2.13-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update mock'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16053

Comment 14 Fedora Update System 2015-09-19 03:20:09 UTC
mock-1.2.13-2.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update mock'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8115

Comment 15 Fedora Update System 2015-09-19 03:21:58 UTC
mock-1.2.13-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update mock'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8114

Comment 16 Fedora Update System 2015-09-23 04:09:33 UTC
mock-1.2.13-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2015-09-24 08:23:12 UTC
mock-1.2.13-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 18 Fedora Update System 2015-10-05 22:51:00 UTC
mock-1.2.13-2.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.

Comment 19 Fedora Update System 2015-10-07 03:05:27 UTC
mock-1.2.13-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

Comment 20 Fedora Update System 2015-10-07 04:05:44 UTC
mock-1.2.13-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.