Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/7e86cbbaca398381ff70279f4e51f82ce658a79b/composer/composer.spec SRPM URL: http://rpms.famillecollet.com/SRPMS/composer-1.0.0-0.5.20150525git69210d5.remi.src.rpm Description: Composer helps you declare, manage and install dependencies of PHP projects, ensuring you have the right stack everywhere. Documentation: https://getcomposer.org/doc/ Fedora Account System Username: remi -- This package is not about changing packaging of PHP libraries / applications, but only about providing the composer command.
Perhaps "/usr/share/composer/res" could change to "/usr/share/composer/COMPOSER_VENDOR/COMPOSER_PROJECT/res" and then we could reuse "/usr/share/composer" for all packages to put their non-license, non-doc, and non-lib files in? Since all files are RPM packaged and versioned, don't we (or shouldn't we) need to remove \Composer\Util\SpdxLicensesUpdater::update()? Nice... I didn't see the removal of the self update command in the spec but I notice upstream now only loads that command if using Composer as a PHAR :)
(In reply to Shawn Iwinski from comment #1) > Perhaps "/usr/share/composer/res" could change to > "/usr/share/composer/COMPOSER_VENDOR/COMPOSER_PROJECT/res" and then we could > reuse "/usr/share/composer" for all packages to put their non-license, > non-doc, and non-lib files in? Each package can own its /usr/share/<package> directory... I don't see the benefit of this proposal... (as explain in description, I don't plan to change packaging Guildelines, just want to offer the "composer" command) > Since all files are RPM packaged and versioned, don't we (or shouldn't we) > need to remove \Composer\Util\SpdxLicensesUpdater::update()? This is "only" dead code, as we don't provide the update-spdx-licenses command > Nice... I didn't see the removal of the self update command in the spec but > I notice upstream now only loads that command if using Composer as a PHAR :) ;)
(In reply to Remi Collet from comment #2) > (In reply to Shawn Iwinski from comment #1) > > Perhaps "/usr/share/composer/res" could change to > > "/usr/share/composer/COMPOSER_VENDOR/COMPOSER_PROJECT/res" and then we could > > reuse "/usr/share/composer" for all packages to put their non-license, > > non-doc, and non-lib files in? > > Each package can own its /usr/share/<package> directory... > I don't see the benefit of this proposal... (as explain in description, I > don't plan to change packaging Guildelines, just want to offer the > "composer" command) I thought at one point you mentioned it would be nice to have a location to put composer.json files other than /usr/share/doc/PKG/. This is what I was thinking with this comment.
(In reply to Shawn Iwinski from comment #3) > I thought at one point you mentioned it would be nice to have a location to > put composer.json files other than /usr/share/doc/PKG/. This is what I was > thinking with this comment. Yes, but such change will imply that all packages dropping a file in this directory will have to require "composer" for directory ownership, when it is really unneeded at runtime.
Spec: https://raw.githubusercontent.com/remicollet/remirepo/06ff2084094794e8e88521ff3c5c5b0505e9b711/composer/composer.spec Srpm: http://rpms.famillecollet.com/SRPMS/composer-1.0.0-0.5.20150614git8e9659b.remi.src.rpm
Created attachment 1041338 [details] fedora-review-build-2015-06-20.log
See attachment fedora-review-build-2015-06-20.log from comment #6 for fedora-review build failure.
Damn test which need internet... I open https://github.com/composer/composer/pull/4169 And so: http://koji.fedoraproject.org/koji/taskinfo?taskID=10172691
Update: https://github.com/remicollet/remirepo/commit/6af0c68c6b681acad788cec7f9d6753a4901aab2 Spec: https://raw.githubusercontent.com/remicollet/remirepo/ef5c018778b1c35d7e9d291665062fa98c35579c/composer/composer.spec Srpm: http://rpms.famillecollet.com/SRPMS/composer-1.0.0-0.5.20150620gitd0ff016.remi.src.rpm
Created attachment 1041463 [details] phpcompatinfo-all.log phpCompatInfo version 4.2.0 DB built May 22 2015 19:29:18 CEST
Created attachment 1041464 [details] phpcompatinfo-src.log phpCompatInfo version 4.2.0 DB built May 22 2015 19:29:18 CEST
Created attachment 1041490 [details] fedora-review.txt Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1225134 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [!]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [!]: Buildroot is not present Note: Buildroot: present but not needed [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required As usual, remove EPEL5 bits after initial import. The phpcompatinfo regular requires seem to be a mix of build requires and regular requires while the build requires seem very sparse. Also, the regular requires is missing php-dom. I'll let you choose the details there though. No blockers. ===== APPROVED =====
Thanks for this review ! New Package SCM Request ======================= Package Name: composer Short Description: Dependency Manager for PHP Upstream URL: https://getcomposer.org/ Owners: remi Branches: f21 f22 epel7 InitialCC:
Git done (by process-git-requests).
composer-1.0.0-0.5.20150620gitd0ff016.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/composer-1.0.0-0.5.20150620gitd0ff016.fc21
composer-1.0.0-0.5.20150620gitd0ff016.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/composer-1.0.0-0.5.20150620gitd0ff016.fc22
composer-1.0.0-0.5.20150620gitd0ff016.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/composer-1.0.0-0.5.20150620gitd0ff016.el7
@remi I forgot to mention, with Symfony 2.7 coming soon, you'll want to update your autoloader to use "ClassLoader" instead of "UniversalClassLoader" ("deprecated since version 2.4, to be removed in 3.0. Use the ClassLoader class instead").
composer-1.0.0-0.5.20150620gitd0ff016.fc22 has been pushed to the Fedora 22 testing repository.
composer-1.0.0-0.5.20150620gitd0ff016.fc22 has been pushed to the Fedora 22 stable repository.
composer-1.0.0-0.5.20150620gitd0ff016.fc21 has been pushed to the Fedora 21 stable repository.
composer-1.0.0-0.5.20150620gitd0ff016.el7 has been pushed to the Fedora EPEL 7 stable repository.