Bug 1225698 - BRMS Quickstarts has dependencies on parent pom.xml.
Summary: BRMS Quickstarts has dependencies on parent pom.xml.
Keywords:
Status: CLOSED EOL
Alias: None
Product: JBoss BPMS Platform 6
Classification: Retired
Component: Quickstarts
Version: 6.2.0
Hardware: Unspecified
OS: Unspecified
medium
unspecified
Target Milestone: ER3
: 6.2.0
Assignee: Bill Rainford
QA Contact: Tomas David
URL:
Whiteboard:
Depends On: 1227861
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-05-28 02:42 UTC by Ryan Zhang
Modified: 2020-03-27 20:06 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-03-27 20:06:27 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Ryan Zhang 2015-05-28 02:42:51 UTC
Description of problem:
This issue is copied from https://issues.jboss.org/browse/BPMSPL-167
Thanks Rafael Benevides for reporting this issue.

"BRMS Quickstarts are now using parent pom.xml. This should be avoid because it causes errors when importing individual Quickstarts to JBDS (cc Max Rydahl Andersen ).
This commit: https://github.com/jboss-developer/jboss-brms-quickstarts/commit/2108562ebcccc6c66dc24f7a45a464372e19753a should be reverted.
"

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Rafael Benevides 2015-05-28 14:42:03 UTC
A little bit more investigation:

The error shown is "Plugin execution not covered by lifecycle configuration: org.commonjava.maven.plugins:project-sources-
 maven-plugin:0.3:archive (execution: project-sources-archive, phase: initialize)"

It's is showing at the line for <parent /> definition which made me think that JBDS was not resolving the parent pom.xml dependencies.

The fact is:

- The error is not related to parent pom.xml dependency.
- Anyway parent pom.xml dependency should be avoided in quickstarts (as it can be imported individually)


Thanks.

Comment 2 Ryan Zhang 2015-06-02 05:25:09 UTC
(In reply to Rafael Benevides from comment #1)
> A little bit more investigation:
> 
> The error shown is "Plugin execution not covered by lifecycle configuration:
> org.commonjava.maven.plugins:project-sources-
>  maven-plugin:0.3:archive (execution: project-sources-archive, phase:
> initialize)"
> 
> It's is showing at the line for <parent /> definition which made me think
> that JBDS was not resolving the parent pom.xml dependencies.
> 
> The fact is:
> 
> - The error is not related to parent pom.xml dependency.
> - Anyway parent pom.xml dependency should be avoided in quickstarts (as it
> can be imported individually)
> 
> 
> Thanks.

Hi, Rafael
Thanks for your investigation!
 I am re-thinking on this issue. To revert the parent pom.xml dependency will cause certain code duplication. It 's error prone to maintain those properties. 
Could you let me know which usercase it would cause problem when imported individually. 
I thought that the parent pom should be available though maven repository, right?

Comment 3 Rafael Benevides 2015-06-02 15:21:41 UTC
Hi Ryan.

In the beginning, the EAP Quickstarts used to have all properties in the parent pom.xml, but we had issues when importing individually the quickstarts. It seems that this issue doesn't happen anymore today with JBDS.

I don't see any issue/bug if we can build it individually. We can change the focus of this bugzilla to investigate the "Plugin execution not covered by lifecycle configuration" by JBDS.

Comment 4 Ryan Zhang 2015-06-03 05:51:52 UTC
(In reply to Rafael Benevides from comment #3)
> Hi Ryan.
> 
> In the beginning, the EAP Quickstarts used to have all properties in the
> parent pom.xml, but we had issues when importing individually the
> quickstarts. It seems that this issue doesn't happen anymore today with JBDS.
> 
> I don't see any issue/bug if we can build it individually. We can change the
> focus of this bugzilla to investigate the "Plugin execution not covered by
> lifecycle configuration" by JBDS.

OK, I see. 
Is it worth to create one bugzilla for JBDS for investigating the "Plugin execution not covered by lifecycle configuration"? If so, could you please raise a new one?  Then I can close this one.

Comment 5 Rafael Benevides 2015-06-03 16:29:28 UTC
Sounds good.

I opened https://bugzilla.redhat.com/show_bug.cgi?id=1227861 and I'll also start a discussion on jboss-developer list about non supported plugins in JBDS, ok ?

Thanks for the support.

Comment 6 Ryan Zhang 2015-06-04 04:04:51 UTC
Great, Thanks!

Comment 7 Ryan Zhang 2015-06-05 10:55:09 UTC
Reopen this since it turn out that it is a problem in quickstarts.

Rafael, Thanks for the investigation.

Comment 8 Petr Široký 2015-07-21 17:15:17 UTC
See JDF guidelines where it says that the quickstarts should not have parent POM: https://github.com/jboss-developer/jboss-developer-shared-resources/blob/master/guides/CONTRIBUTING.md

Comment 9 Petr Široký 2015-08-26 22:02:56 UTC
PR created: https://github.com/jboss-developer/jboss-brms-quickstarts/pull/19

Comment 10 Ryan Zhang 2015-09-21 09:06:55 UTC
Thanks Petr for fixing!

Comment 11 Tomas David 2015-10-01 08:36:43 UTC
Verified on 6.2.0.ER3.


Note You need to log in before you can comment on or make changes to this bug.