Bug 1226084 - gdm ignores DisallowTCP=false on F22
Summary: gdm ignores DisallowTCP=false on F22
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: gdm
Version: 23
Hardware: All
OS: Linux
unspecified
urgent
Target Milestone: ---
Assignee: Ray Strode [halfline]
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-05-29 01:25 UTC by Darryl Bond
Modified: 2016-12-20 13:43 UTC (History)
6 users (show)

Fixed In Version: gdm-3.20.1-3.fc24
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-12-20 13:43:15 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
patch for Rawhide gdm to get it working in F-23 (2.16 KB, patch)
2016-01-16 16:29 UTC, Jan Kratochvil
no flags Details | Diff
F-24 clean gdm.spec patch to apply (393 bytes, patch)
2016-06-26 20:41 UTC, Jan Kratochvil
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
GNOME Bugzilla 750026 0 Normal RESOLVED "-listen tcp" is needed for Xorg 1.17 2021-02-19 04:02:26 UTC

Description Darryl Bond 2015-05-29 01:25:43 UTC
Description of problem:
[security]
DisallowTCP=false

is ignored in /etc/gdm/custom.conf

Xserver needs -listen tcp as well


Version-Release number of selected component (if applicable):
gdm-3.16.1.1-1.fc22.x86_64

How reproducible:
Every time

Steps to Reproduce:
0. Set WaylandEnable=false to /etc/gdm/custom.conf
1. add DisallowTCP=false to /etc/gdm/custom.conf [security] stanza
2. Restart display-manager.service
3. observe that -nolisten tcp is still an argument to Xorg

Actual results:
Xserver does not listen to port 6000

Expected results:
Xserver listens to port 6000 for remote connections to the server



Additional info:
Note that I substituted lxdm for gdm to be able to work.
I found that -nolisten tcp had to be removed, but -listen tcp now has to be added. Relevant section from lxdm.conf: Note tcp_listen=1 is not enough.

[server]
## arg used to start xserver, not fully function
arg=/usr/bin/X -background none vt1 -listen tcp

# uncomment this if you really want xserver listen to tcp
tcp_listen=1

Comment 1 papapizza 2015-08-20 09:07:53 UTC
Hello,

Same issue for me, I can't use xdmcp with Xwayland on F22...

Best regards,

Comment 2 Bill 2015-09-22 13:22:55 UTC
Another user encountered this problem. See :

http://forums.fedoraforum.org/showthread.php?p=1743461#post1743461

An arch linux user also used lightdm as a workaround until this is fixed.

Comment 3 Ray Strode [halfline] 2015-09-22 19:56:28 UTC
do you mind filing this on bugzilla.gnome.org ?

what happened is the upstream X server maintainers decided the benefits of the increased security outweighed the compatibility problems changing the interface would cause, and now all the display managers need to be updated to accommodate.

I actually thought I fixed this already but apparently not.  if you file a bug upstream I'll make sure it stays on my radar.

Comment 4 Darryl Bond 2015-09-22 21:14:04 UTC
There is already one there https://bugzilla.gnome.org/show_bug.cgi?id=750026

Comment 5 Ray Strode [halfline] 2015-09-23 12:08:12 UTC
great thanks.

Comment 6 W. Michael Petullo 2016-01-16 15:53:18 UTC
I am having the same problem with Fedora 23, which ships with xorg-x11-server-common-1.18. The upstream bug explains that newer X11 servers support -listen instead of -nolisten (i.e., default off vs. default on). Is it that something in the GDM does not know this yet?

I have set "DisallowTCP=false" in /etc/gdm/custom.conf.

After logging in, I did notice the following in the output of "ps aux":

gdm       4841  0.0  0.2 226516 20252 tty1     Sl+  10:36   0:00 /usr/libexec/Xorg vt1 -displayfd 3 -auth /run/user/42/gdm/Xauthority -nolisten tcp -background none -noreset -keeptty -verbose 3
mike      5132  0.0  0.1 449264 10444 tty3     Ssl+ 10:36   0:00 /usr/libexec/gdm-x-session --run-script --allow-remote-connections /usr/libexec/xinit-compat
mike      5137  1.1  1.1 541744 90852 tty3     Sl+  10:36   0:05 /usr/libexec/Xorg vt3 -displayfd 3 -auth /run/user/1101/gdm/Xauthority -background none -noreset -keeptty -verbose 3

But I see nothing listening on port 6000, even when I disable my host firewall. Note that the third output line above does not contain "-nolisten", but it also does not contain an explicit "-listen".

Comment 7 Jan Kratochvil 2016-01-16 16:29:07 UTC
Created attachment 1115442 [details]
patch for Rawhide gdm to get it working in F-23

You are right I expect I will just rebuild gdm-3.19.2-1.fc24 in F-23 but it does not work.  configure does not define HAVE_XSERVER_THAT_DEFAULTS_TO_LOCAL_ONLY on F-23 so the attached patch forces it.

This is because on F-23 pkg-config does not find 'xorg-server'.

Comment 8 Darryl Bond 2016-01-18 00:50:13 UTC
I implemented a temporary fix by modifying /usr/bin/Xorg which is a shell script.


#!/bin/sh
#
# Execute Xorg.wrap if it exists otherwise execute Xorg directly.
# This allows distros to put the suid wrapper in a separate package.

ARGS=$( echo "$@" | sed 's/nolisten/listen/' )

basedir=/usr/libexec
if [ -x "$basedir"/Xorg.wrap ]; then
	exec "$basedir"/Xorg.wrap "$ARGS"
else
	exec "$basedir"/Xorg "$ARGS"
fi

Comment 9 Slava 2016-05-25 17:13:38 UTC
Is this patch will back-ported to fedora 23 gdm ?

Comment 10 Slava 2016-05-27 01:26:32 UTC
(In reply to Jan Kratochvil from comment #7)
> Created attachment 1115442 [details]
> patch for Rawhide gdm to get it working in F-23
> 
> You are right I expect I will just rebuild gdm-3.19.2-1.fc24 in F-23 but it
> does not work.  configure does not define
> HAVE_XSERVER_THAT_DEFAULTS_TO_LOCAL_ONLY on F-23 so the attached patch
> forces it.
> 
> This is because on F-23 pkg-config does not find 'xorg-server'.

I tried patches/backport to gdm 3.18 version and applied 
https://git.gnome.org/browse/gdm/commit/?id=3f59fa0da5168451898db63e51e312ce894af0c1

and plus on top you patch and fedora 23 still ignored a specially when wealand in place. Please advise. You can try rpms right here are.

http://ftpsrv01.networklab.ca/fedora/23/RPMS/x86_64/

Comment 11 Slava 2016-05-27 13:29:26 UTC
Is not easier add into gdm spec ?

# Disallow=TCP ignored
BuildRequires: xorg-x11-server-Xorg >= 1.17


Package config failing on the check. I tried --exist --libs.

Comment 12 Slava 2016-05-28 03:11:29 UTC
I tested fedora 24 today with gdm 3.20 and situation the same DisallowTCP=false ignored

Comment 13 Roger Wells 2016-05-31 15:56:00 UTC
I implemented the patch in comment 8.
The server fails with:
Fatal Server Error:
Unrecognized option: -listen

Comment 14 Roger Wells 2016-05-31 15:57:39 UTC
sorry, I should have mentioned in comment 13:
Linux rwells-x240 4.4.9-300.fc23.x86_64 #1 SMP Wed May 4 23:56:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

Comment 15 Slava 2016-05-31 18:02:18 UTC
(In reply to Roger Wells from comment #14)
> sorry, I should have mentioned in comment 13:
> Linux rwells-x240 4.4.9-300.fc23.x86_64 #1 SMP Wed May 4 23:56:27 UTC 2016
> x86_64 x86_64 x86_64 GNU/Linux

You need recompile Xorg rpm and enable listen flag.  I have rpms for fedora 23 

http://ftpsrv01.networklab.ca/fedora/23/RPMS/x86_64/

Comment 16 Jan Kratochvil 2016-06-26 20:41:55 UTC
Created attachment 1172652 [details]
F-24 clean gdm.spec patch to apply

F-24 gdm-3.20.1-1.fc24.x86_64 is still buggy, please apply this patch, it adds only one BuildRequires which is enough to fix it.
This patch is not applicable for F-23.

Comment 17 Fedora Update System 2016-06-27 14:10:49 UTC
gdm-3.20.1-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-9633049b73

Comment 18 Fedora Update System 2016-06-28 04:24:37 UTC
gdm-3.20.1-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-9633049b73

Comment 19 Fedora Update System 2016-06-28 17:25:42 UTC
gdm-3.20.1-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-9a33db9a54

Comment 20 Fedora Update System 2016-06-29 22:56:15 UTC
gdm-3.20.1-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-9a33db9a54

Comment 21 Fedora Update System 2016-07-02 15:25:29 UTC
gdm-3.20.1-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 22 Jan Kratochvil 2016-07-03 08:46:28 UTC
F-22 is still not fixed but F-22 will soon be EOLed anyway.
F-23 is still not fixed - this is why I reopen this Bug.
  The F-24 fix is not applicable for F-23.
F-24 is fixed by Bodhi above, F-24 is done.
Rawhide is still NOT fixed - the F-24 fix should be enough for Rawhide.

Comment 23 Fedora End Of Life 2016-07-19 18:53:13 UTC
Fedora 22 changed to end-of-life (EOL) status on 2016-07-19. Fedora 22 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 24 Roger Wells 2016-07-19 22:15:39 UTC
Not fixed on F23

Comment 25 Fedora End Of Life 2016-11-24 11:50:11 UTC
This message is a reminder that Fedora 23 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 23. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '23'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 23 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 26 Fedora End Of Life 2016-12-20 13:43:15 UTC
Fedora 23 changed to end-of-life (EOL) status on 2016-12-20. Fedora 23 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.