Bug 1226406 - Review Request: R-S4Vectors - S4 implementation of vectors and lists
Summary: Review Request: R-S4Vectors - S4 implementation of vectors and lists
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Pierre-YvesChibon
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-05-29 16:54 UTC by Tom "spot" Callaway
Modified: 2016-12-26 13:28 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-12-26 13:28:32 UTC
Type: ---
Embargoed:
pingou: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Tom "spot" Callaway 2015-05-29 16:54:20 UTC
Spec URL: https://spot.fedorapeople.org/R-S4Vectors.spec
SRPM URL: https://spot.fedorapeople.org/R-S4Vectors-0.6.0-1.fc22.src.rpm
Description:
The S4Vectors package defines the Vector and List virtual classes and a set of
generic functions that extend the semantic of ordinary vectors and lists in R.
Package developers can easily implement vector-like or list-like objects as
concrete subclasses of Vector or List. In addition, a few low-level concrete
subclasses of general interest (e.g. DataFrame, Rle, and Hits) are implemented
in the S4Vectors package itself (many more are implemented in the IRanges
package and in other Bioconductor infrastructure packages).
Fedora Account System Username: spot
Koji Rawhide Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9880383

Note: This is a core dep for the majority of the current Bioconductor stack. It currently will only build against Rawhide due to the version requirement of BiocGenerics

Comment 1 Pierre-YvesChibon 2015-06-02 11:03:44 UTC
* Spec is clean
* License Artistic 2.0 is applicable
* Package builds fine on rawhide
* rpmlint is silent:
R-S4Vectors.src: W: spelling-error %description -l en_US subclasses -> sub classes, sub-classes, subclass es
R-S4Vectors.x86_64: W: spelling-error %description -l en_US subclasses -> sub classes, sub-classes, subclass es
R-S4Vectors-devel.x86_64: W: only-non-binary-in-usr-lib
R-S4Vectors-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 4 warnings.
* Sources used:
upstream: f34c0a5adfd6e4f24fb323e0d3c5485be395271bc159c37bbd3c34c492a3f149  S4Vectors_0.6.0.tar.gz
src.rpm : f34c0a5adfd6e4f24fb323e0d3c5485be395271bc159c37bbd3c34c492a3f149  R-S4Vectors-0.6.0-1.fc22.src/S4Vectors_0.6.0.tar.gz

* Sources look clean, no bundling found.

This looks all clean to me :)

This package is APPROVED

Comment 2 Tom "spot" Callaway 2015-06-02 15:02:15 UTC
New Package SCM Request
=======================
Package Name: R-S4Vectors
Short Description: S4 implementation of vectors and lists
Upstream URL: http://www.bioconductor.org/packages/release/bioc/html/S4Vectors.html
Owners: spot
Branches: f22
InitialCC:

Comment 3 Gwyn Ciesla 2015-06-03 04:26:17 UTC
Git done (by process-git-requests).

Comment 4 Pierre-YvesChibon 2016-12-26 13:28:32 UTC
This has been pushed to our current Fedora, so this is fixed :)


Note You need to log in before you can comment on or make changes to this bug.