Bug 1226684
| Summary: | [virt-v2v] Enable curl driver + upstream features + fixes in qemu-kvm and enable https | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Richard W.M. Jones <rjones> | ||||
| Component: | qemu-kvm | Assignee: | Richard W.M. Jones <rjones> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 7.1 | CC: | huding, juzhang, knoel, mazhang, rbalakri, rjones, stefanha, virt-maint, xfu | ||||
| Target Milestone: | rc | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | qemu-kvm-1.5.3-91.el7 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2015-11-19 05:03:25 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Richard W.M. Jones
2015-05-31 18:40:41 UTC
Created attachment 1033369 [details]
differences between curl.c in our 1.5.3 and curl.c upstream
This attachment is just FYI.
As expected quite a large set of differences, including new features.
This is not as easy as it seems. qemu 1.5.3 lacks (1) aio timers, eg. timer_del, aio_timer_init. These seem to be fairly fundamental to the curl block driver. The backport of this feature seems like it could be tricky. (2) bdrv_attach_aio_context, bdrv_detach_aio_context Seems as if this is NOT fundamental, but would like Stefan to check. Stefan: Is the upstream commit 63f0f45f2e89b60ff8245fec81328ddfde42a303 necessary for qemu 1.5.3? Scratch build containing the backported patches: http://brewweb.devel.redhat.com/brew/taskinfo?taskID=9288421 Improved scratch build, this time remembering to enable the drivers in ./configure: http://brewweb.devel.redhat.com/brew/taskinfo?taskID=9288785 Using the scratch build in comment 5, I ran through a VMware vCenter conversion which tests: - curl driver * file.cookie * file.readahead * file.sslverify * file.driver == https * file.timeout - copy-on-read - fstrim - json: URLs (bug 1226697) and it was successful. http://post-office.corp.redhat.com/archives/rhvirt-patches/2015-June/thread.html#00109 http://post-office.corp.redhat.com/archives/rhvirt-patches/2015-June/thread.html#00132 (In reply to Richard W.M. Jones from comment #7) > http://post-office.corp.redhat.com/archives/rhvirt-patches/2015-June/thread. > html#00109 > http://post-office.corp.redhat.com/archives/rhvirt-patches/2015-June/thread. > html#00132 Ignore the above link. Corrected patch series: http://post-office.corp.redhat.com/archives/rhvirt-patches/2015-June/thread.html#00138 http://post-office.corp.redhat.com/archives/rhvirt-patches/2015-June/thread.html#00132 (In reply to Richard W.M. Jones from comment #3) > (2) bdrv_attach_aio_context, bdrv_detach_aio_context > > Seems as if this is NOT fundamental, but would like Stefan to check. > Stefan: Is the upstream commit 63f0f45f2e89b60ff8245fec81328ddfde42a303 > necessary for qemu 1.5.3? bdrv_attach_aio_context/bdrv_detach_aio_context are not needed in RHEL 7.1 qemu-kvm. (They are needed in qemu-kvm-rhev but not qemu-kvm.) The reason is that RHEL 7.1 qemu-kvm uses an older version of the virtio-blk data-plane code that does not use the QEMU block layer's AioContext. Therefore attach/detach are not necessary. Spec file patch (unchanged from before): http://post-office.corp.redhat.com/archives/rhvirt-patches/2015-June/thread.html#00132 v3 of the curl block driver fixes: http://post-office.corp.redhat.com/archives/rhvirt-patches/2015-June/thread.html#00857 Fix included in qemu-kvm-1.5.3-91.el7 qemu-kvm-1.5.3-92.el7.x86_64 I've tested this now and it all seems to be working. (In reply to Richard W.M. Jones from comment #0) > Description of problem: > > For background on this request, please see this virt-devel posting: > https://post-office.corp.redhat.com/mailman/private/virt-devel/2015-May/ > msg00338.html > > We need to enable the curl driver in qemu-kvm, and add some > upstream features and fixes. > > The patches are (from qemu-kvm-rhev): > kvm-block-curl-Improve-type-safety-of-s-timeout.patch (bug 1152901) > kvm-block.curl-adding-timeout-option.patch (bug 1132569) > kvm-curl-Allow-a-cookie-or-cookies-to-be-sent-with-http-.patch (bug 1132569) > kvm-curl-Don-t-deref-NULL-pointer-in-call-to-aio_poll.patch (bug 1132569) > kvm-curl-Add-timeout-and-cookie-options-and-misc.-fix-RH.patch (bug 1132569) Hi Richard, Since qemu-kvm-rhev also has those fixes and has been verified, may I verify this bug refer to the way of bug 1152901 and bug 1132569, is there difference between qemu-kvm-rhev and qemu-kvm? Thanks, Mazhang. We cannot assert that because the same patches are available upstream/ in a later version, therefore the backported patches will work. OTOH I have tested this qemu-kvm binary myself and it works for me. Hi Richard, Could you please have a look at comment#17, is it sufficient for this bug verify? Thanks, Mazhang. *comment 16 Yes, that is sufficient to verify it, thanks. Base on comment 16 and comment 18, set this bug verified. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-2213.html |