Bug 1226705 - openambit allows public access to devices
Summary: openambit allows public access to devices
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: openambit
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Sandro Mani
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1226704
TreeView+ depends on / blocked
 
Reported: 2015-05-31 19:54 UTC by Zbigniew Jędrzejewski-Szmek
Modified: 2015-06-14 17:25 UTC (History)
1 user (show)

Fixed In Version: openambit-0.3-6.git5f2b784.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-06-14 17:24:11 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Zbigniew Jędrzejewski-Szmek 2015-05-31 19:54:59 UTC
Udev rules installed by primesense allow public access to devices. I see that this is some kind of clock based on a web search, so most likely a separate group should be created and users which are supposed to access those devices should be added to the group.

Also, /etc/udev/rules.d is administrator territory. Please move the rules file to /usr/lib/udev/rules.d (aka %{_udevrulesdir}).

Version-Release number of selected component (if applicable):
openambit-libs-0.3-5.git5f2b784.fc23.x86_64

Comment 1 Sandro Mani 2015-06-01 18:31:35 UTC
Check the udev rules path issue [1], as for the access permissions: I don't think a separate group is desirable. This is just an application used to synchronize sports watches, having users first need to add themselves to some group is not very user friendly. Or am I missing something?

[1] http://pkgs.fedoraproject.org/cgit/openambit.git/commit/?id=d75cac7ab11c14ccfca6dcecaaffbba94c942318

Comment 2 Zbigniew Jędrzejewski-Szmek 2015-06-02 02:47:21 UTC
(In reply to Sandro Mani from comment #1)
> Check the udev rules path issue [1]
Looks correct, at least in the sense that if it doesn't work, rpm build will fail.

> as for the access permissions: I don't
> think a separate group is desirable. This is just an application used to
> synchronize sports watches, having users first need to add themselves to
> some group is not very user friendly. Or am I missing something?
Ah, OK, so my google-fu failed me. If it is a pure "user" device (in the sense in which a USB-stick is, or webcam, or an input device), then it should be attached to the seat. I wrote a description of how that is implemented yesterday, it is pasted below. With a device like that, security indeed is not very important, so allowing write access to all users doesn't seem to be a problem. You still might want to modify the rules to attach the device to a seat because in a multi-seat setup, it is better for other users not to "see" the device at all. But it might be overkill here.

> uaccess
Afaik, this isn't really documented anywhere. The process is done in two parts:
1. some package ships rules which set some udev variable on the devices (for example ENV{ID_SOFTWARE_RADIO}="label")
2. 70-uaccess.rules as shipped by systemd has a matching line which adds the uaccess tag based on this variable (ENV{ID_SOFTWARE_RADIO}=="?*", TAG+="uaccess").
So if primesense devices would fit one of the existing groups which already have their variables (ID_SOFTWARE_RADIO, ID_MEDIA_PLAYER, COLOR_MEASUREMENT_DEVICE, ID_INPUT_JOYSTICK, etc), then your rules could make use of that variable. Otherwise, a new variable would be added upstream.

For openambit devices, I don't see a good matching category in http://cgit.freedesktop.org/systemd/systemd/tree/src/login/70-uaccess.rules. ID_PDA comes closest I guess. It seems that we should add a more general tag upstream that can be used for "other" device types.

Comment 3 Sandro Mani 2015-06-02 11:34:13 UTC
Ok. Perhaps even ID_WATCH would make sense, considering the increasing number of such devices in the wild. I'll start by pushing an update to fix the udev path issue.

Comment 4 Fedora Update System 2015-06-02 11:54:56 UTC
openambit-0.3-6.git5f2b784.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/openambit-0.3-6.git5f2b784.fc21

Comment 5 Fedora Update System 2015-06-02 11:56:07 UTC
openambit-0.3-6.git5f2b784.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/openambit-0.3-6.git5f2b784.fc22

Comment 6 Fedora Update System 2015-06-04 20:11:59 UTC
Package openambit-0.3-6.git5f2b784.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing openambit-0.3-6.git5f2b784.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-9412/openambit-0.3-6.git5f2b784.fc22
then log in and leave karma (feedback).

Comment 7 Fedora Update System 2015-06-14 17:24:11 UTC
openambit-0.3-6.git5f2b784.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2015-06-14 17:25:24 UTC
openambit-0.3-6.git5f2b784.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.