RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1226849 - A copy and paste error in virsh's handler for that tray-change event
Summary: A copy and paste error in virsh's handler for that tray-change event
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.2
Hardware: x86_64
OS: Unspecified
unspecified
medium
Target Milestone: rc
: ---
Assignee: Ján Tomko
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-06-01 09:38 UTC by zhenfeng wang
Modified: 2016-04-18 10:45 UTC (History)
5 users (show)

Fixed In Version: libvirt-1.2.16-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-11-19 06:39:31 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2015:2202 0 normal SHIPPED_LIVE libvirt bug fix and enhancement update 2015-11-19 08:17:58 UTC

Description zhenfeng wang 2015-06-01 09:38:07 UTC 
Description of problem:
A copy and paste error in virsh's handler for that tray-change event

Version-Release number of selected component (if applicable):
libvirt-1.2.15-2.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1.Start a guest with cdrom in the first terminal
# virsh dumpxml 7.0 |grep cdrom -A 6
    <disk type='file' device='cdrom'>
      <driver name='qemu' type='raw'/>
      <backingStore/>
      <target dev='hdc' bus='ide'/>
      <readonly/>
      <alias name='ide0-1-0'/>
      <address type='drive' controller='0' bus='1' target='0' unit='0'/>

2.Create a iso file 
#qemu-img create /var/lib/libvirt/image/test.img 100M

3.Open the second terminal, run the 'event-test.py' python script to catch the event

# python /usr/share/doc/libvirt-python-1.2.15/examples/event-test.py qemu:///system
Using uri:qemu:///system

4.Open third terminal, run the virsh event command to catch the events
#virsh event --all --loop

5.Run the change-media command

# virsh change-media 7.0 hdc /var/lib/libvirt/images/test.img
Successfully updated media.

6.Check the events in the second terminal and the third terminal, found they didn't report the same events, the event-test.py report the 'tray-change' events, virsh events command report the 'disk-change' events

# python /usr/share/doc/libvirt-python-1.2.15/examples/event-test.py qemu:///system
Using uri:qemu:///system
myDomainEventTrayChangeCallback: Domain 7.0(39) tray change devAlias: drive-ide0-1-0 reason: 0
myDomainEventTrayChangeCallback: Domain 7.0(39) tray change devAlias: drive-ide0-1-0 reason: 1


# virsh events --all --loop
event 'disk-change' for domain 7.0 disk drive-ide0-1-0: opened
event 'disk-change' for domain 7.0 disk drive-ide0-1-0: closed

Actual results:
A copy and paste error in virsh's handler for that tray-change event

Expected results:
Events get from "event-test.py" python scripts and virsh event command should be coincident

Additional info:
Comment 2 Ján Tomko 2015-06-01 10:17:44 UTC 
Fixed upstream by:
commit 61139c4438bf9f72271c7df08aada844153ba61d
Author:     Ján Tomko <jtomko>
AuthorDate: 2015-05-28 14:04:07 +0200
Commit:     Ján Tomko <jtomko>
CommitDate: 2015-05-28 14:14:47 +0200

    Fix the event name in vshEventTrayChangePrint
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1206114#c5
    
    Reported by: zhenfeng wang <zhwang>

git describe: v1.2.16-rc1-10-g61139c4 contains: v1.2.16-rc2~10
Comment 4 Fangge Jin 2015-07-29 06:35:25 UTC 
I can reproduce this bug on build libvirt-1.2.15-2.el7.x86_64

Verify this bug on build libvirt-1.2.17-2.el7.x86_64

Verify steps:

1.Prepare a running guest with cdrom:
...
    <disk type='file' device='cdrom'>
      <driver name='qemu' type='raw'/>
      <backingStore/>
      <target dev='hdc' bus='ide'/>
      <readonly/>
      <alias name='ide0-1-0'/>
      <address type='drive' controller='0' bus='1' target='0' unit='0'/>
    </disk>
...

2.Create a iso file 
#qemu-img create /var/lib/libvirt/image/test.img 100M

3.Open the second terminal, run the 'event-test.py' python script to catch the event

# /usr/share/doc/libvirt-python-1.2.17/examples/event-test.py
Using uri:qemu:///system

4.Open third terminal, run the virsh event command to catch the events
#virsh event --all --loop

5.Run the change-media command:
# virsh change-media rhel7-4 hdc /var/lib/libvirt/images/test.img 
Successfully updated media.

6.Check the events in the second terminal:

myDomainEventTrayChangeCallback: Domain rhel7-4(533) tray change devAlias: drive-ide0-1-0 reason: 0
myDomainEventTrayChangeCallback: Domain rhel7-4(533) tray change devAlias: drive-ide0-1-0 reason: 1

7.Check the events in the third terminal:

event 'tray-change' for domain rhel7-4 disk drive-ide0-1-0: opened
event 'tray-change' for domain rhel7-4 disk drive-ide0-1-0: closed


The events reported by event-test.py and virsh command are both "tray-change". So move to verified.
Comment 6 errata-xmlrpc 2015-11-19 06:39:31 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-2202.html
Note You need to log in before you can comment on or make changes to this bug.