Currently libpeas ships both (py2 and py3) python .so files inside one package, that generates following requires for package: libpython2.7.so.1.0()(64bit) libpython3.4m.so.1.0()(64bit) This is not wanted as we want to make fedora live iso python3 only. Please split libpeas into subpackages.
Created attachment 1043052 [details] packaging patch to split out python loaders This patch splits out the Python 2 and 3 loaders into separate subpackages. It likely means that any packages which use libpeas with Python plugins need to explicitly declare dependencies on the loaders, at the same time as this patch would be merged. At least the following packages would need checking: entangle eog gedit gedit-code-assistance gitg gtranslator rhythmbox totem
Created attachment 1045784 [details] rebased package split patch against current master
I did a bit of investigation of plugins provided with the listed projects: * entangle has only Python 3 plugins * eog has only C plugins (no changes required) ** eog-plugins has C and Python 3 plugins * gedit has C and Python 3 plugins ** gedit-plugins also has C and Python 3 plugins * gedit-code-assistance is a C plugin (no change required) * gitg has only C plugins (no change required) * gtranslator has C and Python 2(!) plugins * Rhythmbox has C and Python 3 plugins * totem has C and Python 3 plugins As only gtranslator requires Python 2 for one of its plugins, splitting the Python loaders out into subpackages should avoid another user of Python 2 on the live image (as gtranslator is not installed there).
Thanks David. I think the approach to split out individual loaders makes sense, but I am not sure about the naming. You've used python-%{name} and python3-%{name} here, but that's the naming scheme that's usually reserved for python modules (such as if you do 'import peas' in python, you'd have python-peas package that adds the import). For libpeas loaders, it might be better to use the same naming scheme as opensuse has: libpeas-loader-python, libpeas-loader-python3, libpeas-loader-lua51. https://build.opensuse.org/package/view_file/GNOME:Factory/libpeas/libpeas.spec?expand=1
Created attachment 1045824 [details] use better names for the subpackages Thanks for the clarification about the package naming, and especially about being consisten with the openSUSE naming! I updated the patch based on your comments. What is the best way to coordinate changes to the other packages?
Thanks, looks good to me! If you build it for rawhide, I can help fix up the other packages. It's not a huge list.
I built libpeas-1.15.0-3.fc23 for Rawhide with the patch.
Should be all fixed up: http://pkgs.fedoraproject.org/cgit/entangle.git/commit/?id=5f6d7e51c7ebf30fa5e1bb46b5a644a805004e11 http://pkgs.fedoraproject.org/cgit/eog-plugins.git/commit/?id=a5c21a779e380a940a92fe682c1e085f8e67b59f http://pkgs.fedoraproject.org/cgit/gedit.git/commit/?id=bedb6ad1cfe269f7f7cd6b09cb877299c541f760 http://pkgs.fedoraproject.org/cgit/gedit-plugins.git/commit/?id=e74e9a27513236f737ad2677028d6e03c1e83eb7 http://pkgs.fedoraproject.org/cgit/gtranslator.git/commit/?id=672091535328538c28783488bb7f716a4efb2cd4 http://pkgs.fedoraproject.org/cgit/rhythmbox.git/commit/?id=b730a05658cfa5a672660588c11eec5345e2cc53 http://pkgs.fedoraproject.org/cgit/totem.git/commit/?id=d5d3fee4275ce576c55716c5f370089e3d549355