Bug 1226974
| Summary: | [RFE] - Implement 'Sync MoM policy' support in REST API | |||
|---|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Shira Maximov <mshira> | |
| Component: | RestAPI | Assignee: | Nobody <nobody> | |
| Status: | CLOSED DEFERRED | QA Contact: | Liran Rotenberg <lrotenbe> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | 3.5.3 | CC: | bugs, dfediuck, jentrena, juan.hernandez, lrotenbe, lsurette, mavital, mkalinin, pdwyer, Rhev-m-bugs, srevivo, ykaul | |
| Target Milestone: | --- | Keywords: | FutureFeature, ZStream | |
| Target Release: | --- | Flags: | ylavi:
ovirt-future?
mavital: testing_plan_complete? ylavi: planning_ack? ylavi: devel_ack? ylavi: testing_ack? |
|
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | Doc Type: | Enhancement | ||
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1499181 (view as bug list) | Environment: | ||
| Last Closed: | 2020-04-01 14:44:38 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | Virt | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1499181 | |||
|
Description
Shira Maximov
2015-06-01 15:01:04 UTC
Juan, currently there are no hosts under a specific cluster. Where would it be best to add this action? I'll need to understand whth "sync mom policy" means in order to answer. Can you elaborate? (In reply to Juan Hernández from comment #2) > I'll need to understand whth "sync mom policy" means in order to answer. Can > you elaborate? Sure. This button triggers sending a command to the relevant VDS with latest information on KSM and ballooning: org.ovirt.engine.core.bll.UpdateMomPolicyCommand The idea is that we usually update mom policy when a host becomes operational (up). However in case of emergency you can issue a command to enable/disable the relevant feature in the selected host. If I understand correctly then this should be an operation of the "host" resource:
POST /hosts/{host:id}/syncmompolicy
(In reply to Juan Hernández from comment #4) > If I understand correctly then this should be an operation of the "host" > resource: > > POST /hosts/{host:id}/syncmompolicy This is what I had in mind. The only issue is that in the UI this option is only available in the cluster main tab (hosts sub tab), and you will not see it in the hosts tab. If you use your suggestion will it make an anomaly compared to the UI? The RESTAPI doesn't need to mirror the UI.
The UI is volatile, and the graphical designers may decide to move the button to somewhere else in the future. On the other hand the RESTAPI needs to be stable and backwards compatible. We can't make design decisions based on what the UI does.
If the operation affects a host then its place is the /hosts/{host:id} resource.
Alternatively, if the operation affects all the hosts in a cluster, then it can be added to the /clusters/{cluster:id} resource, but my understanding is that it is an operation that affects a individual host.
(In reply to Juan Hernández from comment #6) > > If the operation affects a host then its place is the /hosts/{host:id} > resource. > > Alternatively, if the operation affects all the hosts in a cluster, then it > can be added to the /clusters/{cluster:id} resource, but my understanding is > that it is an operation that affects a individual host. This is acceptable. Thanks. change SLA team to virt, we're not tracking SLA separately anymore We didn't get to this bug for more than 2 years, and it's not being considered for the upcoming 4.4. It's unlikely that it will ever be addressed so I'm suggesting to close it. If you feel this needs to be addressed and want to work on it please remove cond nack and target accordingly. ok, closing. Please reopen if still relevant/you want to work on it. ok, closing. Please reopen if still relevant/you want to work on it. |