Spec URL: http://acksyn.org/files/rpms/python-jellyfish/python-jellyfish.spec SRPM URL: http://acksyn.org/files/rpms/python-jellyfish/python-jellyfish-0.5.0-1.fc22.src.rpm Description: Jellyfish does approximate and phonetic string matching. It includes the following string comparison algorithms: Levenshtein Distance, Damerau-Levenshtein Distance, Jaro Distance, Jaro-Winkler Distance, Match Rating Approach Comparison and Hamming Distance And the following phonetic encodings: American Soundex, Metaphone, NYSIIS (New York State Identification and Intelligence System), Match Rating Codex
- %defattr is not needed - I'd suggest adding %global _docdir_fmt %{name} to share license and doc dirs between subpackages - Afaics, the source is python 2/3 compatible, and 2to3 is not used. This means that most likely everything can be built from the same directory. So the whole thing with %{py3dir} can be removed.
Hi Zbigniew, (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > - %defattr is not needed Done > - I'd suggest adding %global _docdir_fmt %{name} to share license and doc > dirs between subpackages Makes sense, done > - Afaics, the source is python 2/3 compatible, and 2to3 is not used. This > means that most likely everything can be built from the same directory. So > the whole thing with %{py3dir} can be removed. I have done this as well. I have tested both packages and they work okay. Spec URL: http://acksyn.org/files/rpms/python-jellyfish/python-jellyfish.spec SRPM URL: http://acksyn.org/files/rpms/python-jellyfish/python-jellyfish-0.5.0-2.fc22.src.rpm Thanks for the review, much appreciated. Michele
===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 8 files have unknown license. Detailed output of licensecheck in /var/tmp/1227022-python- jellyfish/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 10 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep Rpmlint ------- Checking: python-jellyfish-0.5.0-2.fc23.noarch.rpm python3-jellyfish-0.5.0-2.fc23.noarch.rpm python-jellyfish-0.5.0-2.fc23.src.rpm python-jellyfish.noarch: W: spelling-error %description -l en_US Levenshtein -> Liechtenstein python-jellyfish.noarch: W: spelling-error %description -l en_US encodings -> encoding, encoding s, recordings python3-jellyfish.noarch: W: spelling-error %description -l en_US Levenshtein -> Liechtenstein python3-jellyfish.noarch: W: spelling-error %description -l en_US encodings -> encoding, encoding s, recordings python-jellyfish.src: W: spelling-error %description -l en_US Levenshtein -> Liechtenstein python-jellyfish.src: W: spelling-error %description -l en_US encodings -> encoding, encoding s, recordings 3 packages and 0 specfiles checked; 0 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- python-jellyfish.noarch: W: spelling-error %description -l en_US Levenshtein -> Liechtenstein python-jellyfish.noarch: W: spelling-error %description -l en_US encodings -> encoding, encoding s, recordings python3-jellyfish.noarch: W: spelling-error %description -l en_US Levenshtein -> Liechtenstein python3-jellyfish.noarch: W: spelling-error %description -l en_US encodings -> encoding, encoding s, recordings 2 packages and 0 specfiles checked; 0 errors, 4 warnings. All OK. Package is APPROVED.
New Package SCM Request ======================= Package Name: python-jellyfish Short Description: A python library for doing approximate and phonetic matching of strings Upstream URL: https://github.com/sunlightlabs/jellyfish Owners: mbaldessari Branches: f22 f23 InitialCC:
Git done (by process-git-requests).
python-jellyfish-0.5.0-2.fc22,beets-1.3.13-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-jellyfish-0.5.0-2.fc22,beets-1.3.13-1.fc22
Odd not sure how this did not get autoclosed. Closing