Bug 1227191 - SingleFileStore.process() should use sequential access
Summary: SingleFileStore.process() should use sequential access
Keywords:
Status: VERIFIED
Alias: None
Product: JBoss Data Grid 6
Classification: JBoss
Component: Infinispan
Version: 6.4.1
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ER1
: 6.5.1
Assignee: Tristan Tarrant
QA Contact: Martin Gencur
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-06-02 06:09 UTC by Dan Berindei
Modified: 2022-05-31 22:24 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker ISPN-5141 0 Major Resolved SingleFileStore.process() should use sequential access 2017-06-13 19:51:27 UTC

Description Dan Berindei 2015-06-02 06:09:44 UTC
SingleFileStore.process() iterates over its keys in pseudo-random order. (It puts all the entries in a HashSet and iterates it to minimize the amount of time it keeps the global lock.)

It should instead either iterate the entries directly from the disk, or at least sort the entries by their offset when iterating.

Since SingleFileStore.process() is used during state transfer, this change should improve state transfer performance with a SingleFileStore.


Note You need to log in before you can comment on or make changes to this bug.