Bug 1227708 - Provide an additional sub-package with a skydns binary
Summary: Provide an additional sub-package with a skydns binary
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: golang-github-skynetservices-skydns
Version: 23
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fridolín Pokorný
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-06-03 11:06 UTC by Peter Lemenkov
Modified: 2016-01-08 09:27 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-01-08 09:27:06 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Peter Lemenkov 2015-06-03 11:06:35 UTC
Hello!
This packagew right now provides only a devel-package, totally ignoring its one of the main purposes - skydns binary. Let's modify the package and introduce an additional sub-package - with skydns executable.

Comment 1 Jan Chaloupka 2015-06-03 11:33:31 UTC
Hi Peter,

this was intentional as skydns depends on kubernetes and visa verse.

The latest tarball no longer depends on kubernetes.

skydns-6c94cbe92349cf550e64752a7cb72c98bcc44325]$ gofed ggi --importpath=github.com/skynetservices/skydns
	github.com/coreos/go-etcd/etcd
	github.com/coreos/go-systemd/activation
	github.com/miekg/dns
	github.com/prometheus/client_golang/prometheus
	github.com/rcrowley/go-metrics
	github.com/rcrowley/go-metrics/stathat


But still there is no Godeps.json file or similar one listing commits of imported packages.

I will take a look at that.

Comment 2 Jan Chaloupka 2015-06-03 11:36:45 UTC
https://github.com/skynetservices/skydns/issues/184

Comment 3 Jan Chaloupka 2015-06-04 12:48:00 UTC
Peter,

can you checkout out the builds? I have added skydns.conf and skydns.service files. SkyDNS is running over etcd so it has to be installed as well.

At the moment service file fails as I don't see more deeply into it. Can you play with it and update service file (possibly skydns.conf file) to make it work?

It there are other dependencies just let me know.

[1] http://koji.fedoraproject.org/koji/taskinfo?taskID=9945220

Thanks
Jan

Comment 4 Jan Chaloupka 2015-06-04 12:49:46 UTC
Anyway what release of skydns would you like to have? I have taken the latest commit. The latest release is 2.5.0b.

Comment 5 Peter Lemenkov 2015-06-04 12:56:05 UTC
(In reply to Jan Chaloupka from comment #3)
> Peter,
> 
> can you checkout out the builds? I have added skydns.conf and skydns.service
> files. SkyDNS is running over etcd so it has to be installed as well.
> 
> At the moment service file fails as I don't see more deeply into it. Can you
> play with it and update service file (possibly skydns.conf file) to make it
> work?

Jan, thanks for building this - I'll try it and post the results later.

(In reply to Jan Chaloupka from comment #4)
> Anyway what release of skydns would you like to have? I have taken the
> latest commit. The latest release is 2.5.0b.

Latest one is fine for me. Actually I don't have any preferences yet.(In reply to Jan Chaloupka from comment #3)

Comment 6 Jan Chaloupka 2015-06-16 08:00:32 UTC
Hi Peter, any positive/negative results?

Comment 7 Peter Lemenkov 2015-06-21 10:39:51 UTC
(In reply to Jan Chaloupka from comment #6)
> Hi Peter, any positive/negative results?

Hello Jan!
The package works fine. However one has to setup at least ETCD_MACHINES variable.

Also if something already opened port 53 (dnsmasq perhaps) then the default configuration will fail. Note that 5353 will be likely occupied as well (Avahi).

And the last issue is that you wrongly attributed %pre section - it should belong to skydns package. So if someone installs only skydns then the skydns user/group isn't exists.

systemd file I believe needs more improvements:

* Skydns can start using socket activation
* We should also specify a group (skydns), not only user. Although I don't use it but I can imagine that someone adds some monitoring toos to skydns group to retrieve some more details.
* How about dropping config file entirely? Let's use environment variables stated in *service file explicitly. My personal biased opinion that it's better because it makes package even simplier. A system administrator then adds /etc/systemd/system/skydns.service.d/Something.conf if necessary (and only if necessary).\

Apart from that it works fine!

Comment 8 Jan Chaloupka 2015-06-22 06:31:26 UTC
> one has to setup at least ETCD_MACHINES variable.

Already set in skydns.conf. Is it not working?

> Also if something already opened port 53 (dnsmasq perhaps) then the default
> configuration will fail. Note that 5353 will be likely occupied as well (Avahi).

Would be great to have a list of all ports used by atomic and find one that is reasonable and not conflicting with standard services. Any suggestions what port it could be?

> systemd file I believe needs more improvements:
> 
> * Skydns can start using socket activation

How does it change the current service file?

> * How about dropping config file entirely? Let's use environment variables stated
> in *service file explicitly.

I am not againts. What envs we should then set? At the moment we have only ETCD_MACHINES="http://127.0.0.1:4001".

Comment 9 Jan Kurik 2015-07-15 14:03:56 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle.
Changing version to '23'.

(As we did not run this process for some time, it could affect also pre-Fedora 23 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23

Comment 10 Fedora Admin XMLRPC Client 2015-07-29 13:43:47 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 11 Peter Lemenkov 2016-01-08 09:27:06 UTC
I think it's safe to close this - skydns is packaged and available in Fedora:


[root@lemenkov ~]# dnf list skydns
Last metadata expiration check performed 0:59:25 ago on Fri Jan  8 09:27:08 2016.
Available Packages
skydns.x86_64                                                                                  2.5.3-0.1.a.git8688008.fc23                                                                                  updates
[root@lemenkov ~]#


Note You need to log in before you can comment on or make changes to this bug.