Bug 1227945 - Automate - Fix RedHat ServiceQuota issue
Summary: Automate - Fix RedHat ServiceQuota issue
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Automate
Version: 5.5.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: GA
: 5.5.0
Assignee: Tina Fitzgerald
QA Contact: Taras Lehinevych
URL:
Whiteboard:
Depends On: 1248747
Blocks: 1231855
TreeView+ depends on / blocked
 
Reported: 2015-06-03 22:11 UTC by Tina Fitzgerald
Modified: 2016-08-03 01:32 UTC (History)
10 users (show)

Fixed In Version: 5.5.0.1
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1231855 (view as bug list)
Environment:
Last Closed: 2015-12-08 13:15:55 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
test automate method. (3.33 KB, text/plain)
2015-06-04 22:00 UTC, Tina Fitzgerald
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2015:2551 0 normal SHIPPED_LIVE Moderate: CFME 5.5.0 bug fixes and enhancement update 2015-12-08 17:58:09 UTC

Description Tina Fitzgerald 2015-06-03 22:11:43 UTC
Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Greg McCullough 2015-06-04 14:09:04 UTC
Tina - This ticket needs details about the issue so it can be tested and validated.

Comment 3 Tina Fitzgerald 2015-06-04 22:00:10 UTC
Created attachment 1034948 [details]
test automate method.

Comment 4 Tina Fitzgerald 2015-06-04 22:01:13 UTC
Service Quota has the ability to accept quota values from the use of tags and/or automate model values.

Attached is an automate method that Kevin wrote to help with testing. Place the automate method in a writable domain and create an instance to call the method, then run simulate call_instance and specify the method namespace/class/instance.
This should create tags for default quota values. 

Testing should be done using tags and automate model values.

ServiceQuota is turned off by default. 

Copy the /Redhat/Service/Provisioning/StateMachines/ServiceProvisionRequestQuotaValidation/ class to a writable domain.

Modify the class schema:
Set manage_quotas to 'true'
Select default quota values for your test. 

Provision the service 2 times, once for passing and once for quota failure.
Should repeat above directions for other quota values.

Let me know if you have any questions.

Comment 5 CFME Bot 2015-06-12 21:09:26 UTC
New commit detected on cfme_productization/master:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme_productization.git;a=commit;h=3ac1252e34ce2821e77fa821eb6ae24f0e232b3f

commit 3ac1252e34ce2821e77fa821eb6ae24f0e232b3f
Author:     Tina Fitzgerald <tfitzger>
AuthorDate: Thu Jun 4 12:01:27 2015 -0400
Commit:     Tina Fitzgerald <tfitzger>
CommitDate: Mon Jun 8 13:37:03 2015 -0400

    Fixed service quota issues.
    
    Added ability to get quota values from automate model instance,
    corrected reporting of quota type, improved logging,
    removed the set of the object reason attribute.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1227945

 .../service_request_quota_validation.rb            | 148 +++++++++++----------
 1 file changed, 79 insertions(+), 69 deletions(-)

Comment 6 CFME Bot 2015-06-12 21:09:33 UTC
New commit detected on cfme_productization/master:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme_productization.git;a=commit;h=f2e48914d2979da810123f1a5984294f84740a6e

commit f2e48914d2979da810123f1a5984294f84740a6e
Merge: 057dc58 8450d8a
Author:     Madhu Kanoor <mkanoor>
AuthorDate: Fri Jun 12 17:06:53 2015 -0400
Commit:     Madhu Kanoor <mkanoor>
CommitDate: Fri Jun 12 17:06:53 2015 -0400

    Merge branch 'bz_1227945' into 'master'
    
    Service Quota Fixes
    
    Added ability to get quota values from automate model instance,
    corrected reporting of quota type, improved logging,
    removed the set of the object reason attribute.
    Made very minor changes to quota email methods.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1227945
    
    See merge request !59

 .../servicetemplateprovisionrequest_denied.rb      |   8 +-
 .../servicetemplateprovisionrequest_warning.rb     |   2 +-
 .../service_request_quota_validation.rb            | 148 +++++++++++----------
 3 files changed, 84 insertions(+), 74 deletions(-)

Comment 7 CFME Bot 2015-06-15 15:16:54 UTC
New commit detected on cfme_productization/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme_productization.git;a=commit;h=432cb9af6c1cf70959269dd623415d648a39de1e

commit 432cb9af6c1cf70959269dd623415d648a39de1e
Merge: 43cc3a6 38a98f8
Author:     Madhu Kanoor <mkanoor>
AuthorDate: Mon Jun 15 11:15:35 2015 -0400
Commit:     Madhu Kanoor <mkanoor>
CommitDate: Mon Jun 15 11:15:35 2015 -0400

    Merge branch 'cherry_pick_1227945' into '5.4.z'
    
    Service quota email cleanup.
    
    BZ:
    https://bugzilla.redhat.com/show_bug.cgi?id=1231855
    
    Original MR:
    http://gitlab.cloudforms.lab.eng.rdu2.redhat.com/cloudforms/cfme_productization/merge_requests/59
    
    Original BZ:
    https://bugzilla.redhat.com/show_bug.cgi?id=1227945
    
    Clean cherry-pick
    
    See merge request !67

 .../__methods__/servicetemplateprovisionrequest_denied.rb         | 8 ++++----
 .../__methods__/servicetemplateprovisionrequest_warning.rb        | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

Comment 8 CFME Bot 2015-06-15 15:25:54 UTC
New commit detected on cfme_productization/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme_productization.git;a=commit;h=432cb9af6c1cf70959269dd623415d648a39de1e

commit 432cb9af6c1cf70959269dd623415d648a39de1e
Merge: 43cc3a6 38a98f8
Author:     Madhu Kanoor <mkanoor>
AuthorDate: Mon Jun 15 11:15:35 2015 -0400
Commit:     Madhu Kanoor <mkanoor>
CommitDate: Mon Jun 15 11:15:35 2015 -0400

    Merge branch 'cherry_pick_1227945' into '5.4.z'
    
    Service quota email cleanup.
    
    BZ:
    https://bugzilla.redhat.com/show_bug.cgi?id=1231855
    
    Original MR:
    http://gitlab.cloudforms.lab.eng.rdu2.redhat.com/cloudforms/cfme_productization/merge_requests/59
    
    Original BZ:
    https://bugzilla.redhat.com/show_bug.cgi?id=1227945
    
    Clean cherry-pick
    
    See merge request !67

 .../__methods__/servicetemplateprovisionrequest_denied.rb         | 8 ++++----
 .../__methods__/servicetemplateprovisionrequest_warning.rb        | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

Comment 10 Taras Lehinevych 2015-11-20 13:47:44 UTC
Verified fixed in version 5.5.0.11

Comment 12 errata-xmlrpc 2015-12-08 13:15:55 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2015:2551


Note You need to log in before you can comment on or make changes to this bug.