Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1228045

Summary:	Scrubber should be disabled once bitrot is reset
Product:	[Community] GlusterFS	Reporter:	Gaurav Kumar Garg <ggarg>
Component:	bitrot	Assignee:	Gaurav Kumar Garg <ggarg>
Status:	CLOSED CURRENTRELEASE	QA Contact:	RajeshReddy <rmekala>
Severity:	unspecified	Docs Contact:	bugs <bugs>
Priority:	unspecified
Version:	3.7.0	CC:	bugs, mzywusko, rmekala, smohan
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1220713	Environment:
Last Closed:	2015-06-20 09:49:48 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1220713
Bug Blocks:

Description Gaurav Kumar Garg 2015-06-04 06:44:12 UTC

+++ This bug was initially created as a clone of Bug #1220713 +++

Description of problem:
=================================
Scrubber should be disabled once bitrot is reset 


Version-Release number of selected component (if applicable):
======================================
glusterfs-server-3.7.0beta1-0.69.git1a32479.el6.x86_64


How reproducible:
======================
always 


Steps to Reproduce:
======================
1.Enable bitrot on volume as part of this both bitd and scrub demons will be started 
2.using gluster vol reset command reset bitrot, but only bitrot is reset to default (disable) and still scrubber is active state 

root@rhs-client37 beta2]# gluster vol reset ECVOL bitrot
volume reset: failed: 'features.bitrot' is protected. To reset use 'force'.
[root@rhs-client37 beta2]# gluster vol reset ECVOL bitrot force
volume reset: success: reset volume successful
[root@rhs-client37 beta2]# gluster vol info ECVOL
 
Volume Name: ECVOL
Type: Disperse
Volume ID: f8f88610-17fb-4db5-9ced-4dcb215d8e2c
Status: Started
Number of Bricks: 1 x (4 + 2) = 6
Transport-type: tcp
Bricks:
Brick1: 10.70.33.235:/rajesh3/brick7
Brick2: 10.70.33.235:/rajesh3/brick8
Brick3: 10.70.33.235:/rajesh3/brick9
Brick4: 10.70.33.229:/rajesh3/brick7
Brick5: 10.70.33.229:/rajesh3/brick8
Brick6: 10.70.33.229:/rajesh3/brick9
Options Reconfigured:
features.scrub-throttle: aggressive
features.scrub: Active
features.uss: enable


Expected results:
========================
Scrub also should be reset to default (disable) once bitrot is reset

Additional info:

--- Additional comment from Anand Avati on 2015-05-27 05:13:18 EDT ---

REVIEW: http://review.gluster.org/10936 (bitrot/glusterd: scrub option should be disabled once bitrot option is reset) posted (#1) for review on master by Gaurav Kumar Garg (ggarg)

--- Additional comment from Anand Avati on 2015-05-28 00:54:11 EDT ---

REVIEW: http://review.gluster.org/10936 (bitrot/glusterd: scrub option should be disabled once bitrot option is reset) posted (#2) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Anand Avati on 2015-05-28 05:49:39 EDT ---

REVIEW: http://review.gluster.org/10936 (bitrot/glusterd: scrub option should be disabled once bitrot option is reset) posted (#4) for review on master by Gaurav Kumar Garg (ggarg)

--- Additional comment from Anand Avati on 2015-05-28 05:59:46 EDT ---

REVIEW: http://review.gluster.org/10936 (bitrot/glusterd: scrub option should be disabled once bitrot option is reset) posted (#5) for review on master by Gaurav Kumar Garg (ggarg)

--- Additional comment from Anand Avati on 2015-06-03 05:25:40 EDT ---

REVIEW: http://review.gluster.org/10936 (bitrot/glusterd: scrub option should be disabled once bitrot option is reset) posted (#6) for review on master by Gaurav Kumar Garg (ggarg)

--- Additional comment from Anand Avati on 2015-06-04 02:38:03 EDT ---

COMMIT: http://review.gluster.org/10936 committed in master by Venky Shankar (vshankar) 
------
commit 79d8916929f7d5b85a09ae9b75eadf945a3e11fb
Author: Gaurav Kumar Garg <ggarg>
Date:   Wed May 27 14:36:24 2015 +0530

    bitrot/glusterd: scrub option should be disabled once bitrot option is reset
    
    Scrubber options should be disabled from the dictionary if user reset
    bitrot option.
    
    Change-Id: Ic7e390cf88b9b749f0ada8bbd4632f4cc0c4aff9
    BUG: 1220713
    Signed-off-by: Gaurav Kumar Garg <ggarg>
    Reviewed-on: http://review.gluster.org/10936
    Reviewed-by: Atin Mukherjee <amukherj>
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Venky Shankar <vshankar>

Comment 1 Anand Avati 2015-06-04 06:45:47 UTC

REVIEW: http://review.gluster.org/11079 (bitrot/glusterd: scrub option should be disabled once bitrot option is reset) posted (#1) for review on release-3.7 by Gaurav Kumar Garg (ggarg)

Comment 2 Anand Avati 2015-06-05 12:04:14 UTC

COMMIT: http://review.gluster.org/11079 committed in release-3.7 by Venky Shankar (vshankar) 
------
commit e2fc345edcf393969c4ff2c6a5b0bead2bf51d5d
Author: Gaurav Kumar Garg <ggarg>
Date:   Wed May 27 14:36:24 2015 +0530

    bitrot/glusterd: scrub option should be disabled once bitrot option is reset
    
    Scrubber options should be disabled from the dictionary if user reset
    bitrot option.
    
    Change-Id: Ic7e390cf88b9b749f0ada8bbd4632f4cc0c4aff9
    BUG: 1228045
    Signed-off-by: Gaurav Kumar Garg <ggarg>
    Reviewed-on: http://review.gluster.org/10936
    Reviewed-by: Atin Mukherjee <amukherj>
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Venky Shankar <vshankar>
    (cherry picked from commit 79d8916929f7d5b85a09ae9b75eadf945a3e11fb)
    Reviewed-on: http://review.gluster.org/11079
    Tested-by: Gluster Build System <jenkins.com>

Comment 3 Niels de Vos 2015-06-20 09:49:48 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.2, please reopen this bug report.

glusterfs-3.7.2 has been announced on the Gluster Packaging mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://www.gluster.org/pipermail/packaging/2015-June/000006.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user