Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/9b64e8d9e77226c901cccd407650f5ad1d89c9d9/php/zeta/php-zetacomponents-graph/php-zetacomponents-graph.spec SRPM URL: http://rpms.famillecollet.com/SRPMS/php-zetacomponents-graph-1.5.2-2.remi.src.rpm Description: A component for creating pie charts, line graphs and other kinds of diagrams. Fedora Account System Username: remi
Created attachment 1050885 [details] phpcompatinfo-full.txt phpCompatInfo version 4.3.0 DB built Jun 16 2015 12:31:49 CEST
Created attachment 1050886 [details] phpcompatinfo-src.txt phpCompatInfo version 4.3.0 DB built Jun 16 2015 12:31:49 CEST
Created attachment 1050887 [details] fedora-review.txt Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1228090 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, PHP, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [!]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [!]: Buildroot is not present Note: Buildroot: present but not needed [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required No blocker... as usual, remove EPEL5 bits after initial import. Issues: ======= - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 3932160 bytes in 127 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation There are almost 4M of docs which should be subpackaged. [!]: Sources contain only permissible code or content. [!]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files docs/tutorial/tutorial_font.fdb (?) docs/tutorial/tutorial_font.pfb docs/tutorial/tutorial_font.ttf I believe these should be removed... so probably the entire tutorial dir should be removed as well unless just the tutorial portions that use these font files can be removed. For library autoloader generated in %build, shouldn't require_once 'ezc/Base/autoloader.php'; be require_once '%{ezcdir}/Base/autoloader.php'; For the tests autoloader generated in %check, shouldn't require '$PWD/src/autoloader.php'; be require '%{buildroot}%{ezcdir}/%{gh_project}/autoloader.php'; so the tests verify what will be installed?
Thanks, Fix: https://github.com/remicollet/remirepo/commit/4cfba970a6ce55e302258914c9b8dcfe9e8cab4d Spec: https://raw.githubusercontent.com/remicollet/remirepo/4cfba970a6ce55e302258914c9b8dcfe9e8cab4d/php/zeta/php-zetacomponents-graph/php-zetacomponents-graph.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-zetacomponents-graph-1.5.2-3.remi.src.rpm
[x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Sources contain only permissible code or content. [x]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files Blockers fixed. ===== APPROVED =====
Thanks for the review! New Package SCM Request ======================= Package Name: php-zetacomponents-graph Short Description: Zeta Graph Component Upstream URL: http://zetacomponents.org/ Owners: remi Branches: f21 f22 el6 epel7 InitialCC:
New Package SCM Request ======================= Package Name: php-zetacomponents-graph Short Description: Zeta Graph Component Upstream URL: http://zetacomponents.org/ Owners: remi Branches: f21 f22 f23 el6 epel7 InitialCC:
Git done (by process-git-requests).
Can you please check, https://admin.fedoraproject.org/pkgdb/package/php-zetacomponents-graph/ => OK http://pkgs.fedoraproject.org/cgit/php-zetacomponents-graph.git => MISSING $ fedpkg clone php-zetacomponents-graph Clonage dans 'php-zetacomponents-graph'... FATAL: R any php-zetacomponents-graph remi DENIED by fallthru (or you mis-spelled the reponame) fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. Could not execute clone: Command '['git', 'clone', 'ssh://remi.org/php-zetacomponents-graph', '--origin', 'origin']' returned non-zero exit status 128
Seems auto-fixed...
php-zetacomponents-graph-1.5.2-3.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/php-zetacomponents-graph-1.5.2-3.fc22
php-zetacomponents-graph-1.5.2-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/php-zetacomponents-graph-1.5.2-3.fc21
php-zetacomponents-graph-1.5.2-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-zetacomponents-graph-1.5.2-3.el6
php-zetacomponents-graph-1.5.2-3.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/php-zetacomponents-graph-1.5.2-3.el7
php-zetacomponents-graph-1.5.2-3.el6 has been pushed to the Fedora EPEL 6 testing repository.
php-zetacomponents-graph-1.5.2-3.fc22 has been pushed to the Fedora 22 stable repository.
php-zetacomponents-graph-1.5.2-3.fc21 has been pushed to the Fedora 21 stable repository.
php-zetacomponents-graph-1.5.2-3.el6 has been pushed to the Fedora EPEL 6 stable repository.
php-zetacomponents-graph-1.5.2-3.el7 has been pushed to the Fedora EPEL 7 stable repository.