Spec URL: https://ihrachyshka.fedorapeople.org/openstack-neutron-lbaas.spec SRPM URL: https://ihrachyshka.fedorapeople.org/openstack-neutron-lbaas-2015.1.0-3.fc22.src.rpm Description: This is a LBaaS service plugin for Openstack Neutron (Networking) service. Fedora Account System Username: ihrachyshka
It's month+ since I've uploaded the review, and no action is seen. Can we push it somehow?
>%{_bindir}/%{servicename}-agent >%{_bindir}/%{servicename}v2-agent It would be really nice, if you would cooperate with upstream and provide man pages for those two executables. - Package uses either %{buildroot} or $RPM_BUILD_ROOT Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros Package requires other packages for directories it uses. Note: No known owner of /usr/share/neutron/server Either require package which owns this directory or own it yourself. python-neutron-lbaas.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/neutron_lbaas/db/migration/alembic_migrations/versions/364f9b6064f0_agentv2.py Either remove executable flag or add shebang.
For man pages, my response is the same as always: upstream won't provide man pages. For directories, they are owned by openstack-neutron package that we depend on. For alembic script, I sent a review in upstream: https://review.openstack.org/222660 Fixed buildroot issue in the .spec file. Please comment.
social's scratch build of openstack-puppet-modules?#db4e135626252ebf0b23b8a0e6e98ce0dcf2f9e6 for git://pkgs.fedoraproject.org/openstack-puppet-modules?#db4e135626252ebf0b23b8a0e6e98ce0dcf2f9e6 and rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11426591
The will to write man page (or other documentation) is blocker for me. I'm stepping back. Maybe somebody else will make you the review.
Approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 21 files have unknown license. Detailed output of licensecheck in /home/haikel/1228106-openstack-neutron-vpnaas/1228115 -openstack-neutron-lbaas/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /etc/neutron, /usr/share/neutron/rootwrap, /usr/share/neutron, /usr/share/neutron/server [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/neutron, /usr/share/neutron/rootwrap, /usr/share/neutron/server, /usr/lib/systemd/system, /etc/neutron, /usr/lib/systemd [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python- neutron-lbaas , python-neutron-lbaas-tests [x]: Package functions as described. [x]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: openstack-neutron-lbaas-2015.1.0-3.el7.noarch.rpm python-neutron-lbaas-2015.1.0-3.el7.noarch.rpm python-neutron-lbaas-tests-2015.1.0-3.el7.noarch.rpm openstack-neutron-lbaas-2015.1.0-3.el7.src.rpm openstack-neutron-lbaas.noarch: W: non-standard-gid /usr/share/neutron/neutron-lbaas-dist.conf neutron openstack-neutron-lbaas.noarch: E: non-readable /usr/share/neutron/neutron-lbaas-dist.conf 640 openstack-neutron-lbaas.noarch: W: non-standard-gid /etc/neutron/lbaas_agent.ini neutron openstack-neutron-lbaas.noarch: E: non-readable /etc/neutron/lbaas_agent.ini 640 openstack-neutron-lbaas.noarch: W: non-standard-gid /etc/neutron/neutron_lbaas.conf neutron openstack-neutron-lbaas.noarch: E: non-readable /etc/neutron/neutron_lbaas.conf 640 openstack-neutron-lbaas.noarch: W: non-standard-gid /etc/neutron/services_lbaas.conf neutron openstack-neutron-lbaas.noarch: E: non-readable /etc/neutron/services_lbaas.conf 640 openstack-neutron-lbaas.noarch: W: no-manual-page-for-binary neutron-lbaasv2-agent openstack-neutron-lbaas.noarch: W: no-manual-page-for-binary neutron-lbaas-agent python-neutron-lbaas.noarch: W: no-documentation python-neutron-lbaas.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/neutron_lbaas/db/migration/alembic_migrations/versions/364f9b6064f0_agentv2.py python-neutron-lbaas-tests.noarch: W: no-documentation 4 packages and 0 specfiles checked; 5 errors, 8 warnings. Rpmlint (installed packages) ---------------------------- python-neutron-lbaas-tests.noarch: W: invalid-url URL: http://launchpad.net/neutron/ <urlopen error [Errno -2] Name or service not known> python-neutron-lbaas-tests.noarch: W: no-documentation python-neutron-lbaas.noarch: W: invalid-url URL: http://launchpad.net/neutron/ <urlopen error [Errno -2] Name or service not known> python-neutron-lbaas.noarch: W: no-documentation python-neutron-lbaas.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/neutron_lbaas/db/migration/alembic_migrations/versions/364f9b6064f0_agentv2.py openstack-neutron-lbaas.noarch: W: invalid-url URL: http://launchpad.net/neutron/ <urlopen error [Errno -2] Name or service not known> openstack-neutron-lbaas.noarch: W: only-non-binary-in-usr-lib openstack-neutron-lbaas.noarch: W: non-standard-gid /etc/neutron/lbaas_agent.ini neutron openstack-neutron-lbaas.noarch: E: non-readable /etc/neutron/lbaas_agent.ini 0640L openstack-neutron-lbaas.noarch: W: non-standard-gid /etc/neutron/neutron_lbaas.conf neutron openstack-neutron-lbaas.noarch: E: non-readable /etc/neutron/neutron_lbaas.conf 0640L openstack-neutron-lbaas.noarch: W: non-standard-gid /etc/neutron/services_lbaas.conf neutron openstack-neutron-lbaas.noarch: E: non-readable /etc/neutron/services_lbaas.conf 0640L openstack-neutron-lbaas.noarch: W: non-standard-gid /usr/share/neutron/neutron-lbaas-dist.conf neutron openstack-neutron-lbaas.noarch: E: non-readable /usr/share/neutron/neutron-lbaas-dist.conf 0640L openstack-neutron-lbaas.noarch: W: no-manual-page-for-binary neutron-lbaasv2-agent openstack-neutron-lbaas.noarch: W: no-manual-page-for-binary neutron-lbaas-agent 3 packages and 0 specfiles checked; 5 errors, 12 warnings. Diff spec file in url and in SRPM --------------------------------- --- /home/haikel/1228106-openstack-neutron-vpnaas/1228115-openstack-neutron-lbaas/srpm/openstack-neutron-lbaas.spec 2016-09-01 16:58:27.349747997 +0200 +++ /home/haikel/1228106-openstack-neutron-vpnaas/1228115-openstack-neutron-lbaas/srpm-unpacked/openstack-neutron-lbaas.spec 2015-06-04 13:54:36.000000000 +0200 @@ -98,5 +98,5 @@ export PBR_VERSION=%{version} export SKIP_PIP_INSTALL=1 -%{__python2} setup.py install -O1 --skip-build --root %{buildroot} +%{__python2} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT # Move rootwrap files to proper location Requires -------- python-neutron-lbaas-tests (rpmlib, GLIBC filtered): /bin/bash python(abi) python-neutron-lbaas python-neutron-lbaas (rpmlib, GLIBC filtered): pyOpenSSL python(abi) python-alembic python-barbicanclient python-eventlet python-netaddr python-neutron python-oslo-config python-oslo-db python-oslo-log python-oslo-messaging python-oslo-serialization python-oslo-utils python-pbr python-pyasn1 python-pyasn1-modules python-requests python-six python-sqlalchemy openstack-neutron-lbaas (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python2 config(openstack-neutron-lbaas) openstack-neutron python-neutron-lbaas Provides -------- python-neutron-lbaas-tests: python-neutron-lbaas-tests python-neutron-lbaas: python-neutron-lbaas openstack-neutron-lbaas: config(openstack-neutron-lbaas) openstack-neutron-lbaas Source checksums ---------------- http://launchpad.net/neutron/kilo/2015.1.0/+download/neutron-lbaas-2015.1.0.tar.gz : CHECKSUM(SHA256) this package : 75ab2d1e1013ae90a718c8091300a72dbc61ab21920a1ed0c1b2c5d58d16772a CHECKSUM(SHA256) upstream package : 75ab2d1e1013ae90a718c8091300a72dbc61ab21920a1ed0c1b2c5d58d16772a Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1228115 -m rdo-mitaka-el7 Buildroot used: cloud7-openstack-mitaka-el7-build Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6