Bug 1229218 - Conflicting default keyboard shortcuts
Summary: Conflicting default keyboard shortcuts
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: libxfce4ui
Version: 24
Hardware: All
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-06-08 09:41 UTC by Laurentiu Pancescu
Modified: 2016-07-24 15:02 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-07-24 15:02:56 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Xfce 11979 0 None None None Never

Description Laurentiu Pancescu 2015-06-08 09:41:41 UTC
Description of problem:
The XFCE default keyboard shortcuts in Fedora 22 bind Ctrl-Alt-L to both "show the logout dialog" (xfce4-session-logout) and "lock the screen" (xflock4).

Version-Release number of selected component (if applicable):
4.12.0-5.fc22

How reproducible:
Always

Steps to Reproduce:
1. Press Ctrl-Alt-L

Actual results:
The system either locks the screen or shows the logout dialog. Which of the two happens seems to be randomly selected at login.

Expected results:
The system always shows the logout dialog, like in Fedora 21 and previous versions.

Additional info:
The workaround is to delete the Ctrl-Alt-L binding from xflock4, using xfce4-keyboard-settings, and then login again (the removal doesn't seem to apply before logout).

Comment 1 Kevin Fenzi 2015-06-10 20:10:54 UTC
I can confirm there's something odd going on here, I just haven't had time to dig into it yet. 

Here when I 'reset to defaults' I actually get 2 xflock4 entries... one with control-alt-delete and one with control-alt-l. ;( 

I'll try and track it down, or you are welcome to file an upstream bug to see if they can find it sooner.

Comment 2 Laurentiu Pancescu 2015-06-10 22:25:26 UTC
It seems that xfce4-settings gets its defaults from libxfce4kbd-private (part of libxfce4ui, where they are stored in the xfce4-keyboard-shortcuts.xml file).  The conflicting keyboard shortcut was added by upstream last summer [1], after an enhancement request [2].

Should I file a bug directly in the XFCE Bugzilla?

[1] http://git.xfce.org/xfce/libxfce4ui/commit/libxfce4kbd-private/xfce4-keyboard-shortcuts.xml?id=635521fe76d5969d49f2da98a8013e32fa394848
[2] https://bugzilla.xfce.org/show_bug.cgi?id=10728

Comment 3 Kevin Fenzi 2015-06-11 15:02:50 UTC
Ah, it seems that we are carrying a Fedora specific patch that adds the shortcut for control-alt-l showing the logout dialog. ;( 

I'll have to dig into history and see why we added this and didn't try and upstream it, but it leaves us in a bad place. Do we drop our control-alt-l for logout in favor of the now upstreamed xfce4-lock shortcut? Or do we try and get upstream to change?

Comment 4 Laurentiu Pancescu 2015-06-11 16:28:53 UTC
Consistency with Gnome apparently played a role in upstream's acceptance of that enhancement request, but I'm not sure to which extent they actively try to follow Gnome.  There is only some overlap with the current Gnome3 keyboard shortcuts [1], but less than during Gnome 2, and Gnome 3 dropped many of their Ctrl+Alt shortcuts in favor of Super+, e.g. Ctrl+Alt+L became Super+L for locking the screen (just like Windows 2000, if I remember correctly, and probably easier to type).  I think Ctrl+Alt+Del produced a multiple-button dialog in Windows, similar to the logout dialog in XFCE; in Gnome 3, that shows the poweroff dialog, but their wiki mentions changing that to Super+F4. [2]

I think a shortcut for the logoff dialog is nice, whatever that may be (as long as there is one).  Probably Super+L to lock the screen and Ctrl+Alt+Del to logout would be the most similar to both Gnome and Windows, assuming the upstream wants to change anything at all.

[1] https://help.gnome.org/users/gnome-help/stable/keyboard-shortcuts-set.html.en
[2] https://wiki.gnome.org/Design/OS/KeyboardShortcuts

Comment 5 Kevin Fenzi 2015-06-11 19:00:49 UTC
Would you be willing to file an upstream bug explaining things? 

Otherwise I can do so this weekend...

Comment 6 Laurentiu Pancescu 2015-06-12 07:49:03 UTC
Opened upstream bug #11979:
https://bugzilla.xfce.org/show_bug.cgi?id=11979

Comment 7 Fedora End Of Life 2016-07-19 20:10:10 UTC
Fedora 22 changed to end-of-life (EOL) status on 2016-07-19. Fedora 22 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 8 Laurentiu Pancescu 2016-07-21 17:55:02 UTC
The issue is still valid in Fedora 23 and 24, since nothing has changed in the Fedora-specific patch.  The fix would be trivial, given a decision about the extra shortcuts.  Unfortunately, there has been no reaction from upstream until now - it's probably unlikely that they'll still answer.

I would also be ok with not having any key shortcut for logging out, since it's not something I do that often and it would be consistent with upstream (one can also use Alt-F1 <UpArrow> <Enter> to trigger the logout dialog, or the power button, if configured like this in xfce4-power-manager).

Comment 9 Kevin Fenzi 2016-07-24 00:15:42 UTC
ok, lets just drop the logout one. 

I've now built that in rawhide. Do you want it in stable releases as well?

Comment 10 Laurentiu Pancescu 2016-07-24 04:56:24 UTC
Not necessarily, it only affects the first login in XFCE (I normally restore the entire home directory from backups, so I seldom see it). Thanks! :)

Comment 11 Kevin Fenzi 2016-07-24 15:02:56 UTC
ok. Let us know if you spot anything further here. Thanks for your patience.


Note You need to log in before you can comment on or make changes to this bug.