Spec URL: http://www.vermillionskye.com/drop/docker-client.spec SRPM URL: http://www.vermillionskye.com/drop/docker-client-2.7.18-1.src.rpm Description: This is the Docker Client Java API library used to communicate with a Docker daemon. Fedora Account System Username: jjohnstn
I'll take this one.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable Issues: ======= - Dist tag is missing - License file is not installed. Add `%license LICENSE` to files section - Docs are missing. Add `%doc NOTICE README.md` to files section - Consider dropping the Requires. They will be properly autogenerated in all cases. All small issues so once fixed I'll approve. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: docker-client-2.7.18-1.noarch.rpm docker-client-2.7.18-1.src.rpm docker-client.noarch: W: no-documentation docker-client.src:13: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 13) 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- docker-client.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Requires -------- docker-client (rpmlib, GLIBC filtered): aopalliance apache-commons-codec apache-commons-compress apache-commons-logging atinject base64coder bean-validation-api bouncycastle bouncycastle-pkix glassfish-annotation-api glassfish-hk2-api glassfish-hk2-locator glassfish-hk2-utils glassfish-jax-rs-api glassfish-jaxb-api guava jackson-annotations jackson-core jackson-databind jackson-dataformat-yaml jackson-datatype-guava jackson-jaxrs-json-provider jackson-jaxrs-providers jackson-module-jaxb-annotations java-headless javassist jersey jffi jnr-constants jnr-enxio jnr-ffi jnr-posix jnr-unixsocket jnr-x86asm jpackage-utils mvn(com.fasterxml.jackson.core:jackson-databind) mvn(com.fasterxml.jackson.dataformat:jackson-dataformat-yaml) mvn(com.fasterxml.jackson.datatype:jackson-datatype-guava) mvn(com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider) mvn(com.github.jnr:jnr-unixsocket) mvn(com.google.guava:guava) mvn(commons-lang:commons-lang) mvn(org.apache.commons:commons-compress) mvn(org.apache.httpcomponents:httpclient) mvn(org.bouncycastle:bcpkix-jdk15on) mvn(org.glassfish.jersey.connectors:jersey-apache-connector) mvn(org.glassfish.jersey.core:jersey-client) mvn(org.glassfish.jersey.media:jersey-media-json-jackson) mvn(org.slf4j:slf4j-api) objectweb-asm osgi-resource-locator slf4j snakeyaml tiger-types Provides -------- docker-client: docker-client mvn(com.spotify:docker-client) mvn(com.spotify:docker-client:pom:) osgi(com.spotify.docker.client)
And one more thing I forgot: * Update to latest upstream version - 2.7.26 is what I found upstream
Package updated. I removed .qualifier from MANIFEST.MF bundle-version as well as address the comments above. Spec URL: http://www.vermillionskye.com/drop/docker-client.spec SRPM URL: http://www.vermillionskye.com/drop/docker-client-2.7.26-1.fc23.src.rpm bash $ rpmlint docker-client-2.7.26-1.fc23.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. bash $ rpmlint docker-client-2.7.26-1.fc23.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Thanks, Package is APPROVED.
New Package SCM Request ======================= Package Name: docker-client Short Description: Eclipse Docker Management Plug-ins Upstream URL: https://github.com/spotify/docker-client Owners: jjohnstn Branches: InitialCC: akurtako
Git done (by process-git-requests).
Jeff, Please make sure to close bugs in timely manner as otherwise they just pollute our queries.